[PATCH] drm/tilcdc: Fix type mismatch

Kory Maincent posted 1 patch 1 month ago
drivers/gpu/drm/tilcdc/tilcdc_panel_legacy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] drm/tilcdc: Fix type mismatch
Posted by Kory Maincent 1 month ago
From: "Kory Maincent (TI)" <kory.maincent@bootlin.com>

cpu_to_be32() returns a __be32 big-endian value, but the compound literals
passed to tilcdc_panel_update_prop() were typed as u32. This causes a
sparse type mismatch warning. Fix it by using __be32 as the compound
literal type to match the return type of cpu_to_be32().

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202602200130.LjofC7YE-lkp@intel.com/
Fixes: 0ff223d991477 ("drm/tilcdc: Convert legacy panel binding via DT overlay at boot time")
Signed-off-by: Kory Maincent (TI) <kory.maincent@bootlin.com>
---
 drivers/gpu/drm/tilcdc/tilcdc_panel_legacy.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel_legacy.c b/drivers/gpu/drm/tilcdc/tilcdc_panel_legacy.c
index 37a69b3cf04b2..2e7b3e87fea18 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_panel_legacy.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_panel_legacy.c
@@ -105,14 +105,14 @@ static int __init tilcdc_panel_copy_props(struct device_node *old_panel,
 
 	if (!invert_pxl_clk) {
 		ret = tilcdc_panel_update_prop(&ocs, new_timing, "pixelclk-active",
-					       &(u32){cpu_to_be32(1)}, sizeof(u32));
+					       &(__be32){cpu_to_be32(1)}, sizeof(__be32));
 		if (ret)
 			goto destroy_ocs;
 	}
 
 	if (!sync_edge) {
 		ret = tilcdc_panel_update_prop(&ocs, new_timing, "syncclk-active",
-					       &(u32){cpu_to_be32(1)}, sizeof(u32));
+					       &(__be32){cpu_to_be32(1)}, sizeof(__be32));
 		if (ret)
 			goto destroy_ocs;
 	}
-- 
2.43.0
Re: [PATCH] drm/tilcdc: Fix type mismatch
Posted by Luca Ceresoli 3 weeks, 2 days ago
On Thu, 05 Mar 2026 17:39:06 +0100, Kory Maincent wrote:
> cpu_to_be32() returns a __be32 big-endian value, but the compound literals
> passed to tilcdc_panel_update_prop() were typed as u32. This causes a
> sparse type mismatch warning. Fix it by using __be32 as the compound
> literal type to match the return type of cpu_to_be32().
> 
> 

Applied, thanks!

[1/1] drm/tilcdc: Fix type mismatch
      commit: 27a39e135f5c1ceaf73e64648eccdb42b751d5c7

Best regards,
-- 
Luca Ceresoli <luca.ceresoli@bootlin.com>
Re: [PATCH] drm/tilcdc: Fix type mismatch
Posted by Luca Ceresoli 3 weeks, 6 days ago
On Thu Mar 5, 2026 at 5:39 PM CET, Kory Maincent wrote:
> From: "Kory Maincent (TI)" <kory.maincent@bootlin.com>
>
> cpu_to_be32() returns a __be32 big-endian value, but the compound literals
> passed to tilcdc_panel_update_prop() were typed as u32. This causes a
> sparse type mismatch warning. Fix it by using __be32 as the compound
> literal type to match the return type of cpu_to_be32().
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202602200130.LjofC7YE-lkp@intel.com/
> Fixes: 0ff223d991477 ("drm/tilcdc: Convert legacy panel binding via DT overlay at boot time")
> Signed-off-by: Kory Maincent (TI) <kory.maincent@bootlin.com>

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com