Fix a typo for T7 gp1 pll.
Signed-off-by: Jian Hu <jian.hu@amlogic.com>
---
.../devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
index 49c61f65deff..b488d92b7984 100644
--- a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
+++ b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
@@ -72,7 +72,7 @@ allOf:
contains:
enum:
- amlogic,t7-gp0-pll
- - amlogic,t7-gp1--pll
+ - amlogic,t7-gp1-pll
- amlogic,t7-hifi-pll
- amlogic,t7-pcie-pll
- amlogic,t7-mpll
--
2.47.1
On Thu, Mar 05, 2026 at 03:43:25PM +0800, Jian Hu wrote: > Fix a typo for T7 gp1 pll. > And also Fixes tag. > Signed-off-by: Jian Hu <jian.hu@amlogic.com> > --- > .../devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml > index 49c61f65deff..b488d92b7984 100644 > --- a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml > +++ b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml > @@ -72,7 +72,7 @@ allOf: > contains: > enum: > - amlogic,t7-gp0-pll > - - amlogic,t7-gp1--pll > + - amlogic,t7-gp1-pll > - amlogic,t7-hifi-pll > - amlogic,t7-pcie-pll > - amlogic,t7-mpll > -- > 2.47.1 >
Hi, Krzysztof
Thanks for your review.
On 3/6/2026 4:11 PM, Krzysztof Kozlowski wrote:
> [You don't often get email from krzk@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> [ EXTERNAL EMAIL ]
>
> On Thu, Mar 05, 2026 at 03:43:25PM +0800, Jian Hu wrote:
>> Fix a typo for T7 gp1 pll.
>>
> And also Fixes tag.
Ok, I will add the Fixes tag:
Fixes: 5437753728ac ("dt-bindings: clock: add Amlogic T7 PLL clock
controller")
>> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
>> ---
>> .../devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
>> index 49c61f65deff..b488d92b7984 100644
>> --- a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
>> @@ -72,7 +72,7 @@ allOf:
>> contains:
>> enum:
>> - amlogic,t7-gp0-pll
>> - - amlogic,t7-gp1--pll
>> + - amlogic,t7-gp1-pll
>> - amlogic,t7-hifi-pll
>> - amlogic,t7-pcie-pll
>> - amlogic,t7-mpll
>> --
>> 2.47.1
>>
On jeu. 05 mars 2026 at 15:43, Jian Hu <jian.hu@amlogic.com> wrote: > Fix a typo for T7 gp1 pll. Patch title is too vague Credit is due to Ronald for finding and reporting the issue initially. This can be viewed as a clean of his original patch so the change should have his Signed-off-by IMO. > > Signed-off-by: Jian Hu <jian.hu@amlogic.com> > --- > .../devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml > index 49c61f65deff..b488d92b7984 100644 > --- a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml > +++ b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml > @@ -72,7 +72,7 @@ allOf: > contains: > enum: > - amlogic,t7-gp0-pll > - - amlogic,t7-gp1--pll > + - amlogic,t7-gp1-pll > - amlogic,t7-hifi-pll > - amlogic,t7-pcie-pll > - amlogic,t7-mpll -- Jerome
Hi, Jerome Thanks for your review. On 3/5/2026 4:57 PM, Jerome Brunet wrote: > [ EXTERNAL EMAIL ] > > On jeu. 05 mars 2026 at 15:43, Jian Hu <jian.hu@amlogic.com> wrote: > >> Fix a typo for T7 gp1 pll. > Patch title is too vague > > Credit is due to Ronald for finding and reporting the issue initially. > This can be viewed as a clean of his original patch so the change should > have his Signed-off-by IMO. OK, I will update the patch title to: Fix redundant hyphen in "amlogic,t7-gp1--pll" string. Thanks to Ronald for finding and reporting this issue. I had obtained his consent before submitting this patch. I agree with you and will add his Signed-off-by in the next version. >> Signed-off-by: Jian Hu <jian.hu@amlogic.com> >> --- >> .../devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml >> index 49c61f65deff..b488d92b7984 100644 >> --- a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml >> +++ b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml >> @@ -72,7 +72,7 @@ allOf: >> contains: >> enum: >> - amlogic,t7-gp0-pll >> - - amlogic,t7-gp1--pll >> + - amlogic,t7-gp1-pll >> - amlogic,t7-hifi-pll >> - amlogic,t7-pcie-pll >> - amlogic,t7-mpll > -- > Jerome
© 2016 - 2026 Red Hat, Inc.