[PATCH v5 0/2] media: synopsys: csi2rx: add support for rk3588 variant

Michael Riesch via B4 Relay posted 2 patches 1 month, 1 week ago
.../bindings/media/rockchip,rk3568-mipi-csi2.yaml  | 11 +++--
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi      | 52 ++++++++++++++++++++++
2 files changed, 60 insertions(+), 3 deletions(-)
[PATCH v5 0/2] media: synopsys: csi2rx: add support for rk3588 variant
Posted by Michael Riesch via B4 Relay 1 month, 1 week ago
Habidere,

The Rockchip RK3588 features six MIPI CSI-2 receiver units:
 - MIPI0: connected to MIPI DCPHY0
 - MIPI1: connected to MIPI DCPHY1
 - MIPI2: connected to MIPI DPHY0
 - MIPI3: connected to MIPI DPHY0-1 (only with split DPHY0)
 - MIPI4: connected to MIPI DPHY1
 - MIPI5: connected to MIPI DPHY1-1 (only with split DPHY1)

The MIPI DCPHYs (at least the CSI-2 features of them) as well as the split
DPHY mode of the DPHYs are not yet supported by mainline. However, we can 
already provide support for the MIPI2 and MIPI4 units.

When support for the split DPHY mode is introduced, the DPHY nodes should 
have the property
    #phy-cells = <1>;
and the MIPI CSI-2 receiver nodes should have the property
    phys = <&csi_dphy{0,1} {0,1}>;
in case the split mode is desired. Since this is a board specific hardware 
design, the properties need to be changed in the board device tree (or any 
overlays).

As reasonable default, however, we can define, e.g., 
    #phy-cells = <0>;
and
    phys = <&csi_dphy{0,1}>;
in the SoC device tree include. This series introduces initial support for 
this default configuration.

Looking forward to your comments!

Signed-off-by: Michael Riesch <michael.riesch@collabora.com>
---
Changes in v5:
- rebased onto new media-committers/next (= v7.1-rc1)
- reflowed commit messages (Sakari)
- Link to v4: https://lore.kernel.org/r/20260305-rk3588-csi2rx-v4-0-81c6bcfefa63@collabora.com

Changes in v4:
- rebased onto media-commiters/next again (as Frank's patches
  are now there)
- changed "oneOf entries to enum in dt binding (Rob)
- Link to v3: https://lore.kernel.org/r/20260305-rk3588-csi2rx-v3-0-754473981f39@collabora.com

Changes in v3:
- rebased onto Sakari's cleanup branch (as Frank's patches were merged)
  (Sakari)
- added Rob's Acked-by
- Link to v2: https://lore.kernel.org/r/20260305-rk3588-csi2rx-v2-0-79d01b615486@collabora.com

Changes in v2:
- use fallback compatible instead of separate compatible (Krzysztof)
- dropped patch 2 and 4 (as a consequence thereof)
- Link to v1: https://lore.kernel.org/r/20260305-rk3588-csi2rx-v1-0-0cd8d2bf28c0@collabora.com

---
Michael Riesch (2):
      media: dt-bindings: rockchip,rk3568-mipi-csi2: add rk3588 compatible
      arm64: dts: rockchip: add mipi csi-2 receiver nodes to rk3588

 .../bindings/media/rockchip,rk3568-mipi-csi2.yaml  | 11 +++--
 arch/arm64/boot/dts/rockchip/rk3588-base.dtsi      | 52 ++++++++++++++++++++++
 2 files changed, 60 insertions(+), 3 deletions(-)
---
base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
change-id: 20260305-rk3588-csi2rx-a11f7c15a40a

Best regards,
-- 
Michael Riesch <michael.riesch@collabora.com>
Re: (subset) [PATCH v5 0/2] media: synopsys: csi2rx: add support for rk3588 variant
Posted by Heiko Stuebner 1 month ago
On Tue, 28 Apr 2026 09:27:22 +0200, Michael Riesch wrote:
> Habidere,
> 
> The Rockchip RK3588 features six MIPI CSI-2 receiver units:
>  - MIPI0: connected to MIPI DCPHY0
>  - MIPI1: connected to MIPI DCPHY1
>  - MIPI2: connected to MIPI DPHY0
>  - MIPI3: connected to MIPI DPHY0-1 (only with split DPHY0)
>  - MIPI4: connected to MIPI DPHY1
>  - MIPI5: connected to MIPI DPHY1-1 (only with split DPHY1)
> 
> [...]

Applied, thanks!

[2/2] arm64: dts: rockchip: add mipi csi-2 receiver nodes to rk3588
      commit: 5052c99cf05271b91fe2b4e6540f7a7d9b6db62f

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>