[PATCH 0/2] nfs: delegated attribute fixes

Jeff Layton posted 2 patches 1 month ago
There is a newer version of this series
fs/nfs/inode.c          |  9 +--------
fs/nfs/nfs42proc.c      | 18 ++++++++++++++++--
fs/nfs/nfs42xdr.c       | 10 ++++++++--
include/linux/nfs_xdr.h |  3 +++
4 files changed, 28 insertions(+), 12 deletions(-)
[PATCH 0/2] nfs: delegated attribute fixes
Posted by Jeff Layton 1 month ago
This patchset fixes a couple of test failures in xfstests when delegated
timestamps are enabled. Please consider for v7.1!

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
Jeff Layton (2):
      nfs: fix utimensat() for atime with delegated timestamps
      nfs: update inode ctime after removexattr operation

 fs/nfs/inode.c          |  9 +--------
 fs/nfs/nfs42proc.c      | 18 ++++++++++++++++--
 fs/nfs/nfs42xdr.c       | 10 ++++++++--
 include/linux/nfs_xdr.h |  3 +++
 4 files changed, 28 insertions(+), 12 deletions(-)
---
base-commit: c107785c7e8dbabd1c18301a1c362544b5786282
change-id: 20260305-nfs-7-1-9f71bcde58c5

Best regards,
-- 
Jeff Layton <jlayton@kernel.org>
Re: [PATCH 0/2] nfs: delegated attribute fixes
Posted by Anna Schumaker 3 weeks, 6 days ago
Hi Jeff,

On Thu, Mar 5, 2026, at 1:53 PM, Jeff Layton wrote:
> This patchset fixes a couple of test failures in xfstests when delegated

Can you add fixes tags to the patches?

Anna

> timestamps are enabled. Please consider for v7.1!
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> Jeff Layton (2):
>       nfs: fix utimensat() for atime with delegated timestamps
>       nfs: update inode ctime after removexattr operation
>
>  fs/nfs/inode.c          |  9 +--------
>  fs/nfs/nfs42proc.c      | 18 ++++++++++++++++--
>  fs/nfs/nfs42xdr.c       | 10 ++++++++--
>  include/linux/nfs_xdr.h |  3 +++
>  4 files changed, 28 insertions(+), 12 deletions(-)
> ---
> base-commit: c107785c7e8dbabd1c18301a1c362544b5786282
> change-id: 20260305-nfs-7-1-9f71bcde58c5
>
> Best regards,
> -- 
> Jeff Layton <jlayton@kernel.org>
Re: [PATCH 0/2] nfs: delegated attribute fixes
Posted by Jeff Layton 3 weeks, 6 days ago
On Fri, 2026-03-13 at 13:48 -0400, Anna Schumaker wrote:
> Hi Jeff,
> 
> On Thu, Mar 5, 2026, at 1:53 PM, Jeff Layton wrote:
> > This patchset fixes a couple of test failures in xfstests when delegated
> 
> Can you add fixes tags to the patches?
> 
> 

Sure.

> > timestamps are enabled. Please consider for v7.1!
> > 
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> > Jeff Layton (2):
> >       nfs: fix utimensat() for atime with delegated timestamps

I think this one maybe?

    Fixes: 40f45ab3814f ("NFS: Further fixes to attribute delegation a/mtime changes")

> >       nfs: update inode ctime after removexattr operation

I'm a little less sure on this one.

Technically, this worked until delegated timestamps were introduced,
but ISTM that omitting the GETATTR in the first place was a mistake:

    Fixes: 3e1f02123fba ("NFSv4.2: add client side XDR handling for extended attributes")

> 
Can you tack those onto the patches or do you need me to resend?

Thanks,
-- 
Jeff Layton <jlayton@kernel.org>
Re: [PATCH 0/2] nfs: delegated attribute fixes
Posted by Olga Kornievskaia 3 weeks, 6 days ago
I can confirm that generic/221 and generic/728 no longer fail with
this patch series applied.

On Thu, Mar 5, 2026 at 1:53 PM Jeff Layton <jlayton@kernel.org> wrote:
>
> This patchset fixes a couple of test failures in xfstests when delegated
> timestamps are enabled. Please consider for v7.1!
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> Jeff Layton (2):
>       nfs: fix utimensat() for atime with delegated timestamps
>       nfs: update inode ctime after removexattr operation
>
>  fs/nfs/inode.c          |  9 +--------
>  fs/nfs/nfs42proc.c      | 18 ++++++++++++++++--
>  fs/nfs/nfs42xdr.c       | 10 ++++++++--
>  include/linux/nfs_xdr.h |  3 +++
>  4 files changed, 28 insertions(+), 12 deletions(-)
> ---
> base-commit: c107785c7e8dbabd1c18301a1c362544b5786282
> change-id: 20260305-nfs-7-1-9f71bcde58c5
>
> Best regards,
> --
> Jeff Layton <jlayton@kernel.org>
>