[PATCH] staging: greybus: Prefer 'unsigned long long' over 'unsigned long long int'

Tomasz Unger posted 1 patch 1 month ago
drivers/staging/greybus/Documentation/firmware/authenticate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] staging: greybus: Prefer 'unsigned long long' over 'unsigned long long int'
Posted by Tomasz Unger 1 month ago
Remove redundant 'int' keyword from 'unsigned long long int' type cast.
'unsigned long long' and 'unsigned long long int' are identical types
in C. Prefer the shorter form as suggested by checkpatch.pl --strict.

Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
 drivers/staging/greybus/Documentation/firmware/authenticate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/Documentation/firmware/authenticate.c b/drivers/staging/greybus/Documentation/firmware/authenticate.c
index 3d2c6f88a138..0ef88b7d24de 100644
--- a/drivers/staging/greybus/Documentation/firmware/authenticate.c
+++ b/drivers/staging/greybus/Documentation/firmware/authenticate.c
@@ -58,7 +58,7 @@ int main(int argc, char *argv[])
 		goto close_fd;
 	}
 
-	printf("UID received: 0x%llx\n", *(unsigned long long int *)(uid.uid));
+	printf("UID received: 0x%llx\n", *(unsigned long long *)(uid.uid));
 
 	/* Get certificate */
 	printf("Get IMS certificate\n");

---
base-commit: 6ae79e7736ee6a5f920867e5346d8a106cd1db74
change-id: 20260305-greybus-unsigned-long-long-e7465302d3fa

Best regards,
-- 
Tomasz Unger <tomasz.unger@yahoo.pl>
Re: [PATCH] staging: greybus: Prefer 'unsigned long long' over 'unsigned long long int'
Posted by Greg Kroah-Hartman 1 month ago
On Thu, Mar 05, 2026 at 09:58:19AM +0100, Tomasz Unger wrote:
> Remove redundant 'int' keyword from 'unsigned long long int' type cast.
> 'unsigned long long' and 'unsigned long long int' are identical types
> in C. Prefer the shorter form as suggested by checkpatch.pl --strict.
> 
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
>  drivers/staging/greybus/Documentation/firmware/authenticate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/Documentation/firmware/authenticate.c b/drivers/staging/greybus/Documentation/firmware/authenticate.c
> index 3d2c6f88a138..0ef88b7d24de 100644
> --- a/drivers/staging/greybus/Documentation/firmware/authenticate.c
> +++ b/drivers/staging/greybus/Documentation/firmware/authenticate.c
> @@ -58,7 +58,7 @@ int main(int argc, char *argv[])
>  		goto close_fd;
>  	}
>  
> -	printf("UID received: 0x%llx\n", *(unsigned long long int *)(uid.uid));
> +	printf("UID received: 0x%llx\n", *(unsigned long long *)(uid.uid));
>  
>  	/* Get certificate */
>  	printf("Get IMS certificate\n");
> 
> ---
> base-commit: 6ae79e7736ee6a5f920867e5346d8a106cd1db74
> change-id: 20260305-greybus-unsigned-long-long-e7465302d3fa
> 
> Best regards,
> -- 
> Tomasz Unger <tomasz.unger@yahoo.pl>
> 

Someone sent this just before you did:
	https://lore.kernel.org/r/20260304193206.4992-1-rayfraytech@gmail.com

sorry,

greg k-h