[PATCH 0/6] gpiolib: unify gpio-hog code

Bartosz Golaszewski posted 6 patches 1 month ago
There is a newer version of this series
Documentation/driver-api/gpio/board.rst |  16 ---
arch/arm/mach-omap1/board-ams-delta.c   |  32 ++++-
drivers/gpio/gpio-sim.c                 | 200 +++++++++++++++-----------------
drivers/gpio/gpiolib-acpi-core.c        |  70 -----------
drivers/gpio/gpiolib-of.c               | 148 +++--------------------
drivers/gpio/gpiolib-of.h               |   9 ++
drivers/gpio/gpiolib.c                  | 139 +++++++++++++---------
drivers/gpio/gpiolib.h                  |   3 +
include/linux/gpio/machine.h            |  33 ------
9 files changed, 233 insertions(+), 417 deletions(-)
[PATCH 0/6] gpiolib: unify gpio-hog code
Posted by Bartosz Golaszewski 1 month ago
GPIO hogs are handled separately in three places: for OF, ACPI and
machine lookup. In addition hogs cannot be set up using software nodes.
A lot of that code is actually redundant and - except for some special
handling of OF nodes - can be unified in one place.

This series moves hogging into GPIO core and bases it on fwnode API
(with a single helper from OF to translate devicetree properties into
lookup flags), converts the two remaining users of machine hogs to using
software node approach and removes machine hog support entirely. In
addition, there's a patch extending the configurability of gpio-sim now
that it uses software nodes for hogs.

For merging: I think this should go through the GPIO tree with an Ack
from OMAP1 maintainers.

Even with the new feature for gpio-sim, this series still removes twice
the number of lines, it adds.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
Bartosz Golaszewski (6):
      gpio: of: clear OF_POPULATED on hog nodes in remove path
      gpio: move hogs into GPIO core
      gpio: sim: use fwnode-based GPIO hogs
      ARM: omap1: ams-delta: convert GPIO hogs to using firmware nodes
      gpio: remove machine hogs
      gpio: sim: allow to define the active-low setting of a simulated hog

 Documentation/driver-api/gpio/board.rst |  16 ---
 arch/arm/mach-omap1/board-ams-delta.c   |  32 ++++-
 drivers/gpio/gpio-sim.c                 | 200 +++++++++++++++-----------------
 drivers/gpio/gpiolib-acpi-core.c        |  70 -----------
 drivers/gpio/gpiolib-of.c               | 148 +++--------------------
 drivers/gpio/gpiolib-of.h               |   9 ++
 drivers/gpio/gpiolib.c                  | 139 +++++++++++++---------
 drivers/gpio/gpiolib.h                  |   3 +
 include/linux/gpio/machine.h            |  33 ------
 9 files changed, 233 insertions(+), 417 deletions(-)
---
base-commit: c025f6cf4209e1542ec2afebe49f42bbaf1a5c7b
change-id: 20260224-gpio-hog-fwnode-b46a53196253

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Re: [PATCH 0/6] gpiolib: unify gpio-hog code
Posted by Andy Shevchenko 1 month ago
On Thu, Mar 05, 2026 at 10:51:25AM +0100, Bartosz Golaszewski wrote:
> GPIO hogs are handled separately in three places: for OF, ACPI and
> machine lookup. In addition hogs cannot be set up using software nodes.
> A lot of that code is actually redundant and - except for some special
> handling of OF nodes - can be unified in one place.
> 
> This series moves hogging into GPIO core and bases it on fwnode API
> (with a single helper from OF to translate devicetree properties into
> lookup flags), converts the two remaining users of machine hogs to using
> software node approach and removes machine hog support entirely. In
> addition, there's a patch extending the configurability of gpio-sim now
> that it uses software nodes for hogs.
> 
> For merging: I think this should go through the GPIO tree with an Ack
> from OMAP1 maintainers.
> 
> Even with the new feature for gpio-sim, this series still removes twice
> the number of lines, it adds.

Lovely! This was in my TODO list somewhere deep, but I never started it for
real (had some very very initial patches)

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
(Maybe I will have time to test it later on, I need to check if there is a use
of them on Intel Galileo Gen1 platform).

-- 
With Best Regards,
Andy Shevchenko