Add the "lenovo,blade" compatible string for the Lenovo YOGA Tablet 8/10
family and add compatible strings for each board
(B6000-F, B6000-H, B8000-F, B8000-H).
These tablets are based on the "blade" platform, featuring 1GB of RAM
and powered by MediaTek MT8125 or MT8389 SoCs. Since these SoCs are
tablet-oriented variants of the MT6589, they are grouped under the
"mediatek,mt6589" compatible string.
Signed-off-by: Akari Tsuyukusa <akkun11.open@gmail.com>
---
Documentation/devicetree/bindings/arm/mediatek.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index 382d0eb4d0af..69dbe389515c 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -44,6 +44,11 @@ properties:
- items:
- enum:
- fairphone,fp1
+ - lenovo,b6000-f
+ - lenovo,b6000-h
+ - lenovo,b8000-f
+ - lenovo,b8000-h
+ - lenovo,blade
- mundoreader,bq-aquaris5
- const: mediatek,mt6589
- items:
--
2.52.0
Il 04/03/26 20:24, Akari Tsuyukusa ha scritto: > Add the "lenovo,blade" compatible string for the Lenovo YOGA Tablet 8/10 > family and add compatible strings for each board > (B6000-F, B6000-H, B8000-F, B8000-H). You're adding support (a devicetree) only for the B8000-F though... > > These tablets are based on the "blade" platform, featuring 1GB of RAM > and powered by MediaTek MT8125 or MT8389 SoCs. Since these SoCs are > tablet-oriented variants of the MT6589, they are grouped under the > "mediatek,mt6589" compatible string. > > Signed-off-by: Akari Tsuyukusa <akkun11.open@gmail.com> > --- > Documentation/devicetree/bindings/arm/mediatek.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index 382d0eb4d0af..69dbe389515c 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -44,6 +44,11 @@ properties: > - items: > - enum: > - fairphone,fp1 > + - lenovo,b6000-f > + - lenovo,b6000-h > + - lenovo,b8000-f > + - lenovo,b8000-h > + - lenovo,blade > - mundoreader,bq-aquaris5 > - const: mediatek,mt6589 > - items: Did you really test this with dtbs_check? ...also, is the "lenovo,blade" really used for anything (bootloader)? You can either fix that or just remove the lenovo,blade compatible... but please, test with `make dtbs_check` before sending a v2 :-) Cheers, Angelo
On Thu, Mar 5, 2026 at 6:49 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > Did you really test this with dtbs_check? > > test with `make dtbs_check` before sending a v2 :-) I think I did it, but I may have missed warnings or errors. (I was sleepy so I don't remember much, lack of sleep is very bad...) I must check dtbs_check before sending v2. > ...also, is the "lenovo,blade" really used for anything (bootloader)? > > You can either fix that or just remove the lenovo,blade compatible... but please, There is no user of it, I'll remove in v2. Thank you for the guidance. Best regards, Akari
On Thu, Mar 05, 2026 at 04:24:16AM +0900, Akari Tsuyukusa wrote: > Add the "lenovo,blade" compatible string for the Lenovo YOGA Tablet 8/10 > family and add compatible strings for each board > (B6000-F, B6000-H, B8000-F, B8000-H). > > These tablets are based on the "blade" platform, featuring 1GB of RAM > and powered by MediaTek MT8125 or MT8389 SoCs. Since these SoCs are > tablet-oriented variants of the MT6589, they are grouped under the > "mediatek,mt6589" compatible string. > > Signed-off-by: Akari Tsuyukusa <akkun11.open@gmail.com> > --- > Documentation/devicetree/bindings/arm/mediatek.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index 382d0eb4d0af..69dbe389515c 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -44,6 +44,11 @@ properties: > - items: > - enum: > - fairphone,fp1 > + - lenovo,b6000-f > + - lenovo,b6000-h > + - lenovo,b8000-f > + - lenovo,b8000-h I don't see users of few of these. Also, explain in commit msg differences between 'f' and 'h'. Best regards, Krzysztof
On 05/03/2026 09:27, Krzysztof Kozlowski wrote: > On Thu, Mar 05, 2026 at 04:24:16AM +0900, Akari Tsuyukusa wrote: >> Add the "lenovo,blade" compatible string for the Lenovo YOGA Tablet 8/10 >> family and add compatible strings for each board >> (B6000-F, B6000-H, B8000-F, B8000-H). >> >> These tablets are based on the "blade" platform, featuring 1GB of RAM >> and powered by MediaTek MT8125 or MT8389 SoCs. Since these SoCs are >> tablet-oriented variants of the MT6589, they are grouped under the >> "mediatek,mt6589" compatible string. >> >> Signed-off-by: Akari Tsuyukusa <akkun11.open@gmail.com> >> --- >> Documentation/devicetree/bindings/arm/mediatek.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml >> index 382d0eb4d0af..69dbe389515c 100644 >> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml >> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml >> @@ -44,6 +44,11 @@ properties: >> - items: >> - enum: >> - fairphone,fp1 >> + - lenovo,b6000-f >> + - lenovo,b6000-h >> + - lenovo,b8000-f >> + - lenovo,b8000-h > > I don't see users of few of these. Also, explain in commit msg > differences between 'f' and 'h'. I don't see the "blade" used either. Best regards, Krzysztof
On Thu, Mar 5, 2026 at 5:27 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > - items: > > - enum: > > - fairphone,fp1 > > + - lenovo,b6000-f > > + - lenovo,b6000-h > > + - lenovo,b8000-f > > + - lenovo,b8000-h > > I don't see users of few of these. Also, explain in commit msg > differences between 'f' and 'h'. On Thu, Mar 5, 2026 at 5:35 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > I don't see the "blade" used either. Hi Kozlowski, thank you for your review. I will remove the unused compatible strings (b6000-f, b6000-h, b8000-h and blade) in v2. I will also add an explanation to the commit message that '-f' stands for Wi-Fi-only models and '-h' stands for 3G models. Note, "blade" can be found in "ro.product.board" (build.prop). B8000-F: blade10_row_wifi B6000-H: blade8_row_3gdata Best regards, Akari
© 2016 - 2026 Red Hat, Inc.