1. Patchew
  2. linux
  3. View series

[PATCH] xfs: don't clobber bi_status in xfs_zone_alloc_and_submit

Andreas Gruenbacher posted 1 patch 1 month ago 
fs/xfs/xfs_zone_alloc.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
[PATCH] xfs: don't clobber bi_status in xfs_zone_alloc_and_submit
Posted by Andreas Gruenbacher 1 month ago 
Function xfs_zone_alloc_and_submit() sets bio->bi_status and then it
calls bio_io_error() which overwrites that value again.  Fix that by
completing the bio separately after setting bio->bi_status.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
 fs/xfs/xfs_zone_alloc.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/fs/xfs/xfs_zone_alloc.c b/fs/xfs/xfs_zone_alloc.c
index e3d19b6dc64a..c3328b9dda37 100644
--- a/fs/xfs/xfs_zone_alloc.c
+++ b/fs/xfs/xfs_zone_alloc.c
@@ -862,7 +862,7 @@ xfs_zone_alloc_and_submit(
 	bool			is_seq;
 
 	if (xfs_is_shutdown(mp))
-		goto out_error;
+		goto out_io_error;
 
 	/*
 	 * If we don't have a locally cached zone in this write context, see if
@@ -875,7 +875,7 @@ xfs_zone_alloc_and_submit(
 select_zone:
 		*oz = xfs_select_zone(mp, write_hint, pack_tight);
 		if (!*oz)
-			goto out_error;
+			goto out_io_error;
 		xfs_set_cached_zone(ip, *oz);
 	}
 
@@ -902,7 +902,10 @@ xfs_zone_alloc_and_submit(
 
 out_split_error:
 	ioend->io_bio.bi_status = errno_to_blk_status(PTR_ERR(split));
-out_error:
+	bio_endio(&ioend->io_bio);
+	return;
+
+out_io_error:
 	bio_io_error(&ioend->io_bio);
 }
 
-- 
2.52.0
Re: [PATCH] xfs: don't clobber bi_status in xfs_zone_alloc_and_submit
Posted by Christoph Hellwig 1 month ago 
On Wed, Mar 04, 2026 at 07:59:20PM +0100, Andreas Gruenbacher wrote:
> Function xfs_zone_alloc_and_submit() sets bio->bi_status and then it
> calls bio_io_error() which overwrites that value again.  Fix that by
> completing the bio separately after setting bio->bi_status.

Looks good, but can you drop the pointless goto label renaming?
I'd also be tempted to just open code the split error case instead
of adding a label for it.
Re: [PATCH] xfs: don't clobber bi_status in xfs_zone_alloc_and_submit
Posted by Andreas Gruenbacher 1 month ago 
On Thu, Mar 5, 2026 at 5:34 PM Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, Mar 04, 2026 at 07:59:20PM +0100, Andreas Gruenbacher wrote:
> > Function xfs_zone_alloc_and_submit() sets bio->bi_status and then it
> > calls bio_io_error() which overwrites that value again.  Fix that by
> > completing the bio separately after setting bio->bi_status.
>
> Looks good, but can you drop the pointless goto label renaming?
> I'd also be tempted to just open code the split error case instead
> of adding a label for it.

Feel free to adjust things as you see fit.

Andreas
Re: [PATCH] xfs: don't clobber bi_status in xfs_zone_alloc_and_submit
Posted by Carlos Maiolino 1 month ago 
On Thu, Mar 05, 2026 at 06:02:51AM -0800, Christoph Hellwig wrote:
> On Wed, Mar 04, 2026 at 07:59:20PM +0100, Andreas Gruenbacher wrote:
> > Function xfs_zone_alloc_and_submit() sets bio->bi_status and then it
> > calls bio_io_error() which overwrites that value again.  Fix that by
> > completing the bio separately after setting bio->bi_status.
> 
> Looks good, but can you drop the pointless goto label renaming?
> I'd also be tempted to just open code the split error case instead
> of adding a label for it.
> 

/me goes pull it off the next pull-request
Re: [PATCH] xfs: don't clobber bi_status in xfs_zone_alloc_and_submit
Posted by Carlos Maiolino 1 month ago 
On Wed, 04 Mar 2026 19:59:20 +0100, Andreas Gruenbacher wrote:
> Function xfs_zone_alloc_and_submit() sets bio->bi_status and then it
> calls bio_io_error() which overwrites that value again.  Fix that by
> completing the bio separately after setting bio->bi_status.
> 
> 

Applied to for-next, thanks!

[1/1] xfs: don't clobber bi_status in xfs_zone_alloc_and_submit
      commit: 5be2161f245bab6aaf0723fdd0c9635dfcaf9de5

Best regards,
-- 
Carlos Maiolino <cem@kernel.org>
Re: [PATCH] xfs: don't clobber bi_status in xfs_zone_alloc_and_submit
Posted by Darrick J. Wong 1 month ago 
On Wed, Mar 04, 2026 at 07:59:20PM +0100, Andreas Gruenbacher wrote:
> Function xfs_zone_alloc_and_submit() sets bio->bi_status and then it
> calls bio_io_error() which overwrites that value again.  Fix that by
> completing the bio separately after setting bio->bi_status.
> 
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>

Yeah, that make sense to me that we shouldn't override the value set in
out_split_error.

Cc: <stable@vger.kernel.org> # v6.15
Fixes: 4e4d5207557770 ("xfs: add the zoned space allocator")
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_zone_alloc.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/xfs/xfs_zone_alloc.c b/fs/xfs/xfs_zone_alloc.c
> index e3d19b6dc64a..c3328b9dda37 100644
> --- a/fs/xfs/xfs_zone_alloc.c
> +++ b/fs/xfs/xfs_zone_alloc.c
> @@ -862,7 +862,7 @@ xfs_zone_alloc_and_submit(
>  	bool			is_seq;
>  
>  	if (xfs_is_shutdown(mp))
> -		goto out_error;
> +		goto out_io_error;
>  
>  	/*
>  	 * If we don't have a locally cached zone in this write context, see if
> @@ -875,7 +875,7 @@ xfs_zone_alloc_and_submit(
>  select_zone:
>  		*oz = xfs_select_zone(mp, write_hint, pack_tight);
>  		if (!*oz)
> -			goto out_error;
> +			goto out_io_error;
>  		xfs_set_cached_zone(ip, *oz);
>  	}
>  
> @@ -902,7 +902,10 @@ xfs_zone_alloc_and_submit(
>  
>  out_split_error:
>  	ioend->io_bio.bi_status = errno_to_blk_status(PTR_ERR(split));
> -out_error:
> +	bio_endio(&ioend->io_bio);
> +	return;
> +
> +out_io_error:
>  	bio_io_error(&ioend->io_bio);
>  }
>  
> -- 
> 2.52.0
> 
>
Re: [PATCH] xfs: don't clobber bi_status in xfs_zone_alloc_and_submit
Posted by Carlos Maiolino 1 month ago 
On Wed, Mar 04, 2026 at 11:53:03AM -0800, Darrick J. Wong wrote:
> On Wed, Mar 04, 2026 at 07:59:20PM +0100, Andreas Gruenbacher wrote:
> > Function xfs_zone_alloc_and_submit() sets bio->bi_status and then it
> > calls bio_io_error() which overwrites that value again.  Fix that by
> > completing the bio separately after setting bio->bi_status.
> > 
> > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> 
> Yeah, that make sense to me that we shouldn't override the value set in
> out_split_error.
> 
> Cc: <stable@vger.kernel.org> # v6.15
> Fixes: 4e4d5207557770 ("xfs: add the zoned space allocator")
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

I can add that at commit time, no need to send again Andreas.


For the patch itself:
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

> 
> --D
> 
> > ---
> >  fs/xfs/xfs_zone_alloc.c | 9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> > 
> > diff --git a/fs/xfs/xfs_zone_alloc.c b/fs/xfs/xfs_zone_alloc.c
> > index e3d19b6dc64a..c3328b9dda37 100644
> > --- a/fs/xfs/xfs_zone_alloc.c
> > +++ b/fs/xfs/xfs_zone_alloc.c
> > @@ -862,7 +862,7 @@ xfs_zone_alloc_and_submit(
> >  	bool			is_seq;
> >  
> >  	if (xfs_is_shutdown(mp))
> > -		goto out_error;
> > +		goto out_io_error;
> >  
> >  	/*
> >  	 * If we don't have a locally cached zone in this write context, see if
> > @@ -875,7 +875,7 @@ xfs_zone_alloc_and_submit(
> >  select_zone:
> >  		*oz = xfs_select_zone(mp, write_hint, pack_tight);
> >  		if (!*oz)
> > -			goto out_error;
> > +			goto out_io_error;
> >  		xfs_set_cached_zone(ip, *oz);
> >  	}
> >  
> > @@ -902,7 +902,10 @@ xfs_zone_alloc_and_submit(
> >  
> >  out_split_error:
> >  	ioend->io_bio.bi_status = errno_to_blk_status(PTR_ERR(split));
> > -out_error:
> > +	bio_endio(&ioend->io_bio);
> > +	return;
> > +
> > +out_io_error:
> >  	bio_io_error(&ioend->io_bio);
> >  }
> >  
> > -- 
> > 2.52.0
> > 
> >

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.