[RFC v1 08/18] PCI: fu740: Allow asynchronous probing for background link training

Anand Moon posted 18 patches 1 month, 1 week ago
[RFC v1 08/18] PCI: fu740: Allow asynchronous probing for background link training
Posted by Anand Moon 1 month, 1 week ago
Establishing a PCIe link can take a while, allow asynchronous probing so
that link establishment can happen in the background while other devices
are being probed.

Fix the identation of the callback functions.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 drivers/pci/controller/dwc/pcie-fu740.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/controller/dwc/pcie-fu740.c b/drivers/pci/controller/dwc/pcie-fu740.c
index 66367252032b..aa6a15baf3fd 100644
--- a/drivers/pci/controller/dwc/pcie-fu740.c
+++ b/drivers/pci/controller/dwc/pcie-fu740.c
@@ -346,9 +346,10 @@ static const struct of_device_id fu740_pcie_of_match[] = {
 
 static struct platform_driver fu740_pcie_driver = {
 	.driver = {
-		   .name = "fu740-pcie",
-		   .of_match_table = fu740_pcie_of_match,
-		   .suppress_bind_attrs = true,
+		.name = "fu740-pcie",
+		.of_match_table = fu740_pcie_of_match,
+		.suppress_bind_attrs = true,
+		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
 	},
 	.probe = fu740_pcie_probe,
 	.shutdown = fu740_pcie_shutdown,
-- 
2.50.1
Re: [RFC v1 08/18] PCI: fu740: Allow asynchronous probing for background link training
Posted by Frank Li 1 month, 1 week ago
From: Frank Li (AI-BOT) <frank.li@nxp.com>

Commit message has a typo:

> Fix the identation of the callback functions.

Should be "indentation" (two 'n's).

The code changes look good otherwise. The indentation fix aligns with kernel
style (8-char tabs), and adding PROBE_PREFER_ASYNCHRONOUS is a straightforward
addition that matches the stated intent.

AI bot review and may be useless.
Re: [RFC v1 08/18] PCI: fu740: Allow asynchronous probing for background link training
Posted by Krzysztof Kozlowski 1 month, 1 week ago
On 04/03/2026 15:55, Frank Li wrote:
> From: Frank Li (AI-BOT) <frank.li@nxp.com>
> 
> Commit message has a typo:
> 
>> Fix the identation of the callback functions.
> 
> Should be "indentation" (two 'n's).
> 
> The code changes look good otherwise. The indentation fix aligns with kernel
> style (8-char tabs), and adding PROBE_PREFER_ASYNCHRONOUS is a straightforward
> addition that matches the stated intent.
> 
> AI bot review and may be useless.

So don't send us useless reviews. Trim your reply list, so only you see
them.

Best regards,
Krzysztof