[PATCH] pmdomain: arm: Add print after a successful probe for SCMI power domains

Ulf Hansson posted 1 patch 1 month, 1 week ago
drivers/pmdomain/arm/scmi_pm_domain.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] pmdomain: arm: Add print after a successful probe for SCMI power domains
Posted by Ulf Hansson 1 month, 1 week ago
It can be discussed how useful a print is after a successful probe. In the
SCMI power domain case it's seems valuable, as it let us inform about the
number of initialized power domains too, which is fetched from firmware.

Therefore, let's add a print about this, which also aligns with the
behaviour of the SCMI perf domain driver.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/pmdomain/arm/scmi_pm_domain.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pmdomain/arm/scmi_pm_domain.c b/drivers/pmdomain/arm/scmi_pm_domain.c
index b5e2ffd5ea64..5454faed7d5d 100644
--- a/drivers/pmdomain/arm/scmi_pm_domain.c
+++ b/drivers/pmdomain/arm/scmi_pm_domain.c
@@ -113,6 +113,7 @@ static int scmi_pm_domain_probe(struct scmi_device *sdev)
 		goto err_rm_genpds;
 
 	dev_set_drvdata(dev, scmi_pd_data);
+	dev_info(dev, "Initialized %d power domains", num_domains);
 
 	return 0;
 err_rm_genpds:
-- 
2.43.0
Re: [PATCH] pmdomain: arm: Add print after a successful probe for SCMI power domains
Posted by Sudeep Holla 1 month, 1 week ago
On Wed, Mar 04, 2026 at 11:14:57AM +0100, Ulf Hansson wrote:
> It can be discussed how useful a print is after a successful probe. In the
> SCMI power domain case it's seems valuable, as it let us inform about the
> number of initialized power domains too, which is fetched from firmware.
> 
> Therefore, let's add a print about this, which also aligns with the
> behaviour of the SCMI perf domain driver.
> 

I always assumed it was already there as dev_debug() but I am wrong.

Acked-by: Sudeep Holla <sudeep.holla@kernel.org>

-- 
Regards,
Sudeep
Re: [PATCH] pmdomain: arm: Add print after a successful probe for SCMI power domains
Posted by Cristian Marussi 1 month, 1 week ago
On Wed, Mar 04, 2026 at 11:14:57AM +0100, Ulf Hansson wrote:
> It can be discussed how useful a print is after a successful probe. In the
> SCMI power domain case it's seems valuable, as it let us inform about the
> number of initialized power domains too, which is fetched from firmware.

Hi,

yes indeed we tend to print such 'summary' info at the end of a
successful probe in other SCMI drivers.

LGTM.
Review-by: Cristian Marussi <cristian.marussi@arm.com>

Thanks,
Cristian
Re: [PATCH] pmdomain: arm: Add print after a successful probe for SCMI power domains
Posted by Ulf Hansson 1 month, 1 week ago
On Wed, 4 Mar 2026 at 11:24, Cristian Marussi <cristian.marussi@arm.com> wrote:
>
> On Wed, Mar 04, 2026 at 11:14:57AM +0100, Ulf Hansson wrote:
> > It can be discussed how useful a print is after a successful probe. In the
> > SCMI power domain case it's seems valuable, as it let us inform about the
> > number of initialized power domains too, which is fetched from firmware.
>
> Hi,
>
> yes indeed we tend to print such 'summary' info at the end of a
> successful probe in other SCMI drivers.
>
> LGTM.
> Review-by: Cristian Marussi <cristian.marussi@arm.com>

Thanks! I have queued this up for v7.1.

Kind regards
Uffe