[PATCH 05/14] regulator: drop unneeded dependencies on OF_GPIO

Bartosz Golaszewski posted 14 patches 1 month, 1 week ago
There is a newer version of this series
[PATCH 05/14] regulator: drop unneeded dependencies on OF_GPIO
Posted by Bartosz Golaszewski 1 month, 1 week ago
OF_GPIO is selected automatically on all OF systems. Any symbols it
controls also provide stubs so there's really no reason to select it
explicitly.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
 drivers/regulator/Kconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index d10b6f9243d51574a9ac662b93d4678cd7d94a4f..10e64e3ffb1f5f60e0b62b16ab513f002a42fa1f 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -1232,7 +1232,6 @@ config REGULATOR_RASPBERRYPI_TOUCHSCREEN_ATTINY
 	depends on ARM || ARM64 || COMPILE_TEST
 	depends on BACKLIGHT_CLASS_DEVICE
 	depends on I2C
-	depends on OF_GPIO
 	select REGMAP_I2C
 	help
 	  This driver supports ATTINY regulator on the Raspberry Pi 7-inch
@@ -1332,7 +1331,6 @@ config REGULATOR_RT5133
 	depends on I2C && GPIOLIB && OF
 	select REGMAP
 	select CRC8
-	select OF_GPIO
 	help
 	  This driver adds support for RT5133 PMIC regulators.
 	  RT5133 is an integrated chip. It includes 8 LDOs and 3 GPOs that

-- 
2.47.3
Re: [PATCH 05/14] regulator: drop unneeded dependencies on OF_GPIO
Posted by Mark Brown 1 month, 1 week ago
On Wed, Mar 04, 2026 at 10:02:26AM +0100, Bartosz Golaszewski wrote:
> OF_GPIO is selected automatically on all OF systems. Any symbols it
> controls also provide stubs so there's really no reason to select it
> explicitly.

> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index d10b6f9243d51574a9ac662b93d4678cd7d94a4f..10e64e3ffb1f5f60e0b62b16ab513f002a42fa1f 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -1232,7 +1232,6 @@ config REGULATOR_RASPBERRYPI_TOUCHSCREEN_ATTINY
>  	depends on ARM || ARM64 || COMPILE_TEST
>  	depends on BACKLIGHT_CLASS_DEVICE
>  	depends on I2C
> -	depends on OF_GPIO
>  	select REGMAP_I2C
>  	help
>  	  This driver supports ATTINY regulator on the Raspberry Pi 7-inch

This is a depends rather than a select, though it's fairly redundant
with the arch:

Acked-by: Mark Brown <broonie@kernel.org>