1. Patchew
  2. linux
  3. View series

[PATCH] dt-bindings: serial: 8250: spacemit: fix clock property for K3 SoC

Yixun Lan posted 1 patch 1 month, 1 week ago 
Documentation/devicetree/bindings/serial/8250.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
[PATCH] dt-bindings: serial: 8250: spacemit: fix clock property for K3 SoC
Posted by Yixun Lan 1 month, 1 week ago 
The UART of SpacemiT K3 SoC has same clock property as K1 generation which
request two clock sources, fix the binding otherwise will get DT check
warnings.

Fixes: b5024e804ee0 ("dt-bindings: serial: 8250: add SpacemiT K3 UART compatible")
Signed-off-by: Yixun Lan <dlan@kernel.org>
---
 Documentation/devicetree/bindings/serial/8250.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml
index 73851f19330d..e9e07c2356bc 100644
--- a/Documentation/devicetree/bindings/serial/8250.yaml
+++ b/Documentation/devicetree/bindings/serial/8250.yaml
@@ -63,7 +63,9 @@ allOf:
       properties:
         compatible:
           contains:
-            const: spacemit,k1-uart
+            enum:
+              - spacemit,k1-uart
+              - spacemit,k3-uart
     then:
       properties:
         clock-names:
@@ -76,6 +78,7 @@ allOf:
           contains:
             enum:
               - spacemit,k1-uart
+              - spacemit,k3-uart
               - nxp,lpc1850-uart
     then:
       required:

---
base-commit: ec1fb4e55df47ed043ab2ccc6787e39b9d67e49b
change-id: 20260304-01-uart-clock-names-551463132daa

Best regards,
-- 
Yixun Lan <dlan@kernel.org>
Re: [PATCH] dt-bindings: serial: 8250: spacemit: fix clock property for K3 SoC
Posted by Yixun Lan 1 month ago 
On Wed, 04 Mar 2026 07:19:39 +0000, Yixun Lan wrote:
> The UART of SpacemiT K3 SoC has same clock property as K1 generation which
> request two clock sources, fix the binding otherwise will get DT check
> warnings.
> 
> 

Applied, thanks!

[1/1] dt-bindings: serial: 8250: spacemit: fix clock property for K3 SoC
      https://github.com/spacemit-com/linux/commit/606a6b8bca570aa4f838ddd410345a2937bd98eb

Best regards,
-- 
Yixun Lan <dlan@kernel.org>
Re: [PATCH] dt-bindings: serial: 8250: spacemit: fix clock property for K3 SoC
Posted by Rob Herring (Arm) 1 month ago 
On Wed, 04 Mar 2026 07:19:39 +0000, Yixun Lan wrote:
> The UART of SpacemiT K3 SoC has same clock property as K1 generation which
> request two clock sources, fix the binding otherwise will get DT check
> warnings.
> 
> Fixes: b5024e804ee0 ("dt-bindings: serial: 8250: add SpacemiT K3 UART compatible")
> Signed-off-by: Yixun Lan <dlan@kernel.org>
> ---
>  Documentation/devicetree/bindings/serial/8250.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Re: [PATCH] dt-bindings: serial: 8250: spacemit: fix clock property for K3 SoC
Posted by Yixun Lan 1 month ago 
Hi Greg, Jiri,

  Do you mind if I taking this patch via SpacemiT's SoC tree? and if
possible, it would be nice to have your Acks..
(or either way works for me, if you grab it and merged via tty tree)

On 07:19 Wed 04 Mar     , Yixun Lan wrote:
> The UART of SpacemiT K3 SoC has same clock property as K1 generation which
> request two clock sources, fix the binding otherwise will get DT check
> warnings.
> 
> Fixes: b5024e804ee0 ("dt-bindings: serial: 8250: add SpacemiT K3 UART compatible")
I would just drop the Fixes tag, as I think at the time of Gudong
submitting the patch, the clock driver isn't ready, so he deliberatly
removed this clock contraint and provided with a fixed clock frequency
(the bindings match with DTS)

https://github.com/torvalds/linux/blob/v7.0-rc3/arch/riscv/boot/dts/spacemit/k3.dtsi#L414

> Signed-off-by: Yixun Lan <dlan@kernel.org>
> ---
>  Documentation/devicetree/bindings/serial/8250.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml
> index 73851f19330d..e9e07c2356bc 100644
> --- a/Documentation/devicetree/bindings/serial/8250.yaml
> +++ b/Documentation/devicetree/bindings/serial/8250.yaml
> @@ -63,7 +63,9 @@ allOf:
>        properties:
>          compatible:
>            contains:
> -            const: spacemit,k1-uart
> +            enum:
> +              - spacemit,k1-uart
> +              - spacemit,k3-uart
>      then:
>        properties:
>          clock-names:
> @@ -76,6 +78,7 @@ allOf:
>            contains:
>              enum:
>                - spacemit,k1-uart
> +              - spacemit,k3-uart
>                - nxp,lpc1850-uart
>      then:
>        required:
> 
> ---
> base-commit: ec1fb4e55df47ed043ab2ccc6787e39b9d67e49b
> change-id: 20260304-01-uart-clock-names-551463132daa
> 
> Best regards,
> -- 
> Yixun Lan <dlan@kernel.org>
> 

-- 
Yixun Lan (dlan)
Re: [PATCH] dt-bindings: serial: 8250: spacemit: fix clock property for K3 SoC
Posted by Greg Kroah-Hartman 1 month ago 
On Tue, Mar 10, 2026 at 05:34:46PM +0800, Yixun Lan wrote:
> Hi Greg, Jiri,
> 
>   Do you mind if I taking this patch via SpacemiT's SoC tree? and if
> possible, it would be nice to have your Acks..
> (or either way works for me, if you grab it and merged via tty tree)
> 
> On 07:19 Wed 04 Mar     , Yixun Lan wrote:
> > The UART of SpacemiT K3 SoC has same clock property as K1 generation which
> > request two clock sources, fix the binding otherwise will get DT check
> > warnings.
> > 
> > Fixes: b5024e804ee0 ("dt-bindings: serial: 8250: add SpacemiT K3 UART compatible")
> I would just drop the Fixes tag, as I think at the time of Gudong
> submitting the patch, the clock driver isn't ready, so he deliberatly
> removed this clock contraint and provided with a fixed clock frequency
> (the bindings match with DTS)
> 
> https://github.com/torvalds/linux/blob/v7.0-rc3/arch/riscv/boot/dts/spacemit/k3.dtsi#L414

You need to get a DT maintainer to review it before you can apply it.
If you want to take it through your tree once that happens, that's fine
with me.

thanks,

greg k-h
Re: [PATCH] dt-bindings: serial: 8250: spacemit: fix clock property for K3 SoC
Posted by Yixun Lan 1 month ago 
Hi Greg,

On 15:13 Thu 12 Mar     , Greg Kroah-Hartman wrote:
> On Tue, Mar 10, 2026 at 05:34:46PM +0800, Yixun Lan wrote:
> > Hi Greg, Jiri,
> > 
> >   Do you mind if I taking this patch via SpacemiT's SoC tree? and if
> > possible, it would be nice to have your Acks..
> > (or either way works for me, if you grab it and merged via tty tree)
> > 
> > On 07:19 Wed 04 Mar     , Yixun Lan wrote:
> > > The UART of SpacemiT K3 SoC has same clock property as K1 generation which
> > > request two clock sources, fix the binding otherwise will get DT check
> > > warnings.
> > > 
> > > Fixes: b5024e804ee0 ("dt-bindings: serial: 8250: add SpacemiT K3 UART compatible")
> > I would just drop the Fixes tag, as I think at the time of Gudong
> > submitting the patch, the clock driver isn't ready, so he deliberatly
> > removed this clock contraint and provided with a fixed clock frequency
> > (the bindings match with DTS)
> > 
> > https://github.com/torvalds/linux/blob/v7.0-rc3/arch/riscv/boot/dts/spacemit/k3.dtsi#L414
> 
> You need to get a DT maintainer to review it before you can apply it.
Ok, so Rob gave an Ack

> If you want to take it through your tree once that happens, that's fine
> with me.
Thanks, so this imply an Ack, but could give an explict Acked-by?
then I will proceed..

-- 
Yixun Lan (dlan)
Re: [PATCH] dt-bindings: serial: 8250: spacemit: fix clock property for K3 SoC
Posted by Greg Kroah-Hartman 1 month ago 
On Fri, Mar 13, 2026 at 09:19:10AM +0800, Yixun Lan wrote:
> Hi Greg,
> 
> On 15:13 Thu 12 Mar     , Greg Kroah-Hartman wrote:
> > On Tue, Mar 10, 2026 at 05:34:46PM +0800, Yixun Lan wrote:
> > > Hi Greg, Jiri,
> > > 
> > >   Do you mind if I taking this patch via SpacemiT's SoC tree? and if
> > > possible, it would be nice to have your Acks..
> > > (or either way works for me, if you grab it and merged via tty tree)
> > > 
> > > On 07:19 Wed 04 Mar     , Yixun Lan wrote:
> > > > The UART of SpacemiT K3 SoC has same clock property as K1 generation which
> > > > request two clock sources, fix the binding otherwise will get DT check
> > > > warnings.
> > > > 
> > > > Fixes: b5024e804ee0 ("dt-bindings: serial: 8250: add SpacemiT K3 UART compatible")
> > > I would just drop the Fixes tag, as I think at the time of Gudong
> > > submitting the patch, the clock driver isn't ready, so he deliberatly
> > > removed this clock contraint and provided with a fixed clock frequency
> > > (the bindings match with DTS)
> > > 
> > > https://github.com/torvalds/linux/blob/v7.0-rc3/arch/riscv/boot/dts/spacemit/k3.dtsi#L414
> > 
> > You need to get a DT maintainer to review it before you can apply it.
> Ok, so Rob gave an Ack
> 
> > If you want to take it through your tree once that happens, that's fine
> > with me.
> Thanks, so this imply an Ack, but could give an explict Acked-by?
> then I will proceed..

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.