[PATCH net-next 2/4] dt-bindings: net: cdns,macb: forbid phy nodes for Microchip p64h

Charles Perry posted 4 patches 1 month ago
[PATCH net-next 2/4] dt-bindings: net: cdns,macb: forbid phy nodes for Microchip p64h
Posted by Charles Perry 1 month ago
The GEM IPs within Microchip p64h have their MDIO controllers
unconnected from any physical pin.

When compiling a p64h device tree with a phy on a GEM node with
CHECK_DTBS=1, this generates an error like:

```
linux/arch/riscv/boot/dts/microchip/p64h-hb130x.dtb:
ethernet@40004180000 (microchip,p64h-gem): ethernet-phy@0: False
schema does not allow {'reg': [[0]]}
	from schema $id:
http://devicetree.org/schemas/net/cdns,macb.yaml#
```

Signed-off-by: Charles Perry <charles.perry@microchip.com>
---
 Documentation/devicetree/bindings/net/cdns,macb.yaml | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
index dff350302098..be66cc9a42fd 100644
--- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
+++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
@@ -197,6 +197,17 @@ allOf:
       required:
         - phys
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: microchip,p64h-gem
+    then:
+      patternProperties:
+        "^ethernet-phy@[0-9a-f]$": false
+      properties:
+        mdio: false
+
 unevaluatedProperties: false
 
 examples:
-- 
2.47.3
Re: [PATCH net-next 2/4] dt-bindings: net: cdns,macb: forbid phy nodes for Microchip p64h
Posted by Conor Dooley 1 month ago
On Tue, Mar 03, 2026 at 10:03:16AM -0800, Charles Perry wrote:
> The GEM IPs within Microchip p64h have their MDIO controllers
> unconnected from any physical pin.
> 
> When compiling a p64h device tree with a phy on a GEM node with
> CHECK_DTBS=1, this generates an error like:
> 
> ```
> linux/arch/riscv/boot/dts/microchip/p64h-hb130x.dtb:
> ethernet@40004180000 (microchip,p64h-gem): ethernet-phy@0: False
> schema does not allow {'reg': [[0]]}
> 	from schema $id:
> http://devicetree.org/schemas/net/cdns,macb.yaml#
> ```

This should just be part of the patch adding the compatible. Adding it
incorrectly only to fix it up one patch later doesn't make sense.
Additionally, remove this information about the error adding this
produces, all you need here is the justification for it.

pw-bot: changes-requested

> 
> Signed-off-by: Charles Perry <charles.perry@microchip.com>
> ---
>  Documentation/devicetree/bindings/net/cdns,macb.yaml | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index dff350302098..be66cc9a42fd 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -197,6 +197,17 @@ allOf:
>        required:
>          - phys
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: microchip,p64h-gem
> +    then:
> +      patternProperties:
> +        "^ethernet-phy@[0-9a-f]$": false
> +      properties:
> +        mdio: false
> +
>  unevaluatedProperties: false
>  
>  examples:
> -- 
> 2.47.3
> 
Re: [PATCH net-next 2/4] dt-bindings: net: cdns,macb: forbid phy nodes for Microchip p64h
Posted by Charles Perry 1 month ago
On Tue, Mar 03, 2026 at 06:11:42PM +0000, Conor Dooley wrote:
> On Tue, Mar 03, 2026 at 10:03:16AM -0800, Charles Perry wrote:
> > The GEM IPs within Microchip p64h have their MDIO controllers
> > unconnected from any physical pin.
> > 
> > When compiling a p64h device tree with a phy on a GEM node with
> > CHECK_DTBS=1, this generates an error like:
> > 
> > ```
> > linux/arch/riscv/boot/dts/microchip/p64h-hb130x.dtb:
> > ethernet@40004180000 (microchip,p64h-gem): ethernet-phy@0: False
> > schema does not allow {'reg': [[0]]}
> > 	from schema $id:
> > http://devicetree.org/schemas/net/cdns,macb.yaml#
> > ```
> 
> This should just be part of the patch adding the compatible. Adding it
> incorrectly only to fix it up one patch later doesn't make sense.
> Additionally, remove this information about the error adding this
> produces, all you need here is the justification for it.
> 

Ok

Thanks,
Charles

> pw-bot: changes-requested
> 
> > 
> > Signed-off-by: Charles Perry <charles.perry@microchip.com>
> > ---
> >  Documentation/devicetree/bindings/net/cdns,macb.yaml | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> > index dff350302098..be66cc9a42fd 100644
> > --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> > +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> > @@ -197,6 +197,17 @@ allOf:
> >        required:
> >          - phys
> >  
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: microchip,p64h-gem
> > +    then:
> > +      patternProperties:
> > +        "^ethernet-phy@[0-9a-f]$": false
> > +      properties:
> > +        mdio: false
> > +
> >  unevaluatedProperties: false
> >  
> >  examples:
> > -- 
> > 2.47.3
> >