[PATCH 2/6] dt-bindings: remoteproc: k3-r5f: Add memory-region-names

Markus Schneider-Pargmann (TI) posted 6 patches 1 month, 1 week ago
There is a newer version of this series
[PATCH 2/6] dt-bindings: remoteproc: k3-r5f: Add memory-region-names
Posted by Markus Schneider-Pargmann (TI) 1 month, 1 week ago
Add names to the memory-region-names for easier idenfitication of memory
regions.

Signed-off-by: Markus Schneider-Pargmann (TI) <msp@baylibre.com>
---
 .../bindings/remoteproc/ti,k3-r5f-rproc.yaml          | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
index 6aadc61e20f9f4c27f5b9c87ab2025a02776c5de..76ef23afe8c9f7f155dfec7fcabc7c60b8b286c6 100644
--- a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
@@ -182,6 +182,25 @@ patternProperties:
           - description: DM RM/PM trace and firmware code/data
         additionalItems: true
 
+      memory-region-names:
+        description: |
+          Optional names for the memory regions specified in the memory-region
+          property.
+        oneOf:
+          - description: Basic configuration with DMA and firmware regions
+            items:
+              - const: dma
+              - const: firmware
+
+          - description: Extended LPM configuration with split memory regions
+            items:
+              - const: dma
+              - const: ipc
+              - const: lpm-stub
+              - const: lpm-metadata
+              - const: lpm-context
+              - const: dm-firmware
+
 # Optional properties:
 # --------------------
 # The following properties are optional properties for each of the R5F cores:

-- 
2.51.0
Re: [PATCH 2/6] dt-bindings: remoteproc: k3-r5f: Add memory-region-names
Posted by Conor Dooley 1 month ago
On Tue, Mar 03, 2026 at 04:13:00PM +0100, Markus Schneider-Pargmann (TI) wrote:
> Add names to the memory-region-names for easier idenfitication of memory
> regions.
> 
> Signed-off-by: Markus Schneider-Pargmann (TI) <msp@baylibre.com>
> ---
>  .../bindings/remoteproc/ti,k3-r5f-rproc.yaml          | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> index 6aadc61e20f9f4c27f5b9c87ab2025a02776c5de..76ef23afe8c9f7f155dfec7fcabc7c60b8b286c6 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> @@ -182,6 +182,25 @@ patternProperties:
>            - description: DM RM/PM trace and firmware code/data
>          additionalItems: true
>  
> +      memory-region-names:
> +        description: |
> +          Optional names for the memory regions specified in the memory-region

Is this really optional? Shouldn't it be made mandatory so that it is
easy to tell the difference between the two configurations?

> +          property.
> +        oneOf:
> +          - description: Basic configuration with DMA and firmware regions
> +            items:
> +              - const: dma
> +              - const: firmware
> +
> +          - description: Extended LPM configuration with split memory regions
> +            items:
> +              - const: dma
> +              - const: ipc
> +              - const: lpm-stub
> +              - const: lpm-metadata
> +              - const: lpm-context
> +              - const: dm-firmware
> +
>  # Optional properties:
>  # --------------------
>  # The following properties are optional properties for each of the R5F cores:
> 
> -- 
> 2.51.0
> 
Re: [PATCH 2/6] dt-bindings: remoteproc: k3-r5f: Add memory-region-names
Posted by Conor Dooley 1 month ago
On Tue, Mar 03, 2026 at 06:31:56PM +0000, Conor Dooley wrote:
> On Tue, Mar 03, 2026 at 04:13:00PM +0100, Markus Schneider-Pargmann (TI) wrote:
> > Add names to the memory-region-names for easier idenfitication of memory
> > regions.
> > 
> > Signed-off-by: Markus Schneider-Pargmann (TI) <msp@baylibre.com>
> > ---
> >  .../bindings/remoteproc/ti,k3-r5f-rproc.yaml          | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> > index 6aadc61e20f9f4c27f5b9c87ab2025a02776c5de..76ef23afe8c9f7f155dfec7fcabc7c60b8b286c6 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> > @@ -182,6 +182,25 @@ patternProperties:
> >            - description: DM RM/PM trace and firmware code/data
> >          additionalItems: true
> >  
> > +      memory-region-names:
> > +        description: |
> > +          Optional names for the memory regions specified in the memory-region
> 
> Is this really optional? Shouldn't it be made mandatory so that it is
> easy to tell the difference between the two configurations?

Actually, so that you can tell at all, since it looks like anything from
2 to 8 regions is permitted (which this prop doesn't account for I guess,
only allowing 2 or 6 regions).

> 
> > +          property.
> > +        oneOf:
> > +          - description: Basic configuration with DMA and firmware regions
> > +            items:
> > +              - const: dma
> > +              - const: firmware
> > +
> > +          - description: Extended LPM configuration with split memory regions
> > +            items:
> > +              - const: dma
> > +              - const: ipc
> > +              - const: lpm-stub
> > +              - const: lpm-metadata
> > +              - const: lpm-context
> > +              - const: dm-firmware
> > +
> >  # Optional properties:
> >  # --------------------
> >  # The following properties are optional properties for each of the R5F cores:
> > 
> > -- 
> > 2.51.0
> > 


Re: [PATCH 2/6] dt-bindings: remoteproc: k3-r5f: Add memory-region-names
Posted by Markus Schneider-Pargmann 1 month ago
Hi Conor,

On Tue Mar 3, 2026 at 7:33 PM CET, Conor Dooley wrote:
> On Tue, Mar 03, 2026 at 06:31:56PM +0000, Conor Dooley wrote:
>> On Tue, Mar 03, 2026 at 04:13:00PM +0100, Markus Schneider-Pargmann (TI) wrote:
>> > Add names to the memory-region-names for easier idenfitication of memory
>> > regions.
>> > 
>> > Signed-off-by: Markus Schneider-Pargmann (TI) <msp@baylibre.com>
>> > ---
>> >  .../bindings/remoteproc/ti,k3-r5f-rproc.yaml          | 19 +++++++++++++++++++
>> >  1 file changed, 19 insertions(+)
>> > 
>> > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
>> > index 6aadc61e20f9f4c27f5b9c87ab2025a02776c5de..76ef23afe8c9f7f155dfec7fcabc7c60b8b286c6 100644
>> > --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
>> > +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
>> > @@ -182,6 +182,25 @@ patternProperties:
>> >            - description: DM RM/PM trace and firmware code/data
>> >          additionalItems: true
>> >  
>> > +      memory-region-names:
>> > +        description: |
>> > +          Optional names for the memory regions specified in the memory-region
>> 
>> Is this really optional? Shouldn't it be made mandatory so that it is
>> easy to tell the difference between the two configurations?
>
> Actually, so that you can tell at all, since it looks like anything from
> 2 to 8 regions is permitted (which this prop doesn't account for I guess,
> only allowing 2 or 6 regions).

Thanks for your feedback. I will fix both, make memory-region-names
required and fix the inconsistency between both properties regarding
what is allowed.

Best
Markus