iio: adc: ti-ads1119: Drop redundant error message

[PATCH] iio: adc: ti-ads1119: Drop redundant error message

Posted by Felix Gu 1 month, 1 week ago

devm_request_threaded_irq already prints an error message when failure,
so the error message is redundant, drop it.

Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
 drivers/iio/adc/ti-ads1119.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iio/adc/ti-ads1119.c b/drivers/iio/adc/ti-ads1119.c
index c9cedc59cdcd..1157e606bc64 100644
--- a/drivers/iio/adc/ti-ads1119.c
+++ b/drivers/iio/adc/ti-ads1119.c
@@ -740,8 +740,7 @@ static int ads1119_probe(struct i2c_client *client)
 						NULL, IRQF_ONESHOT,
 						"ads1119", indio_dev);
 		if (ret)
-			return dev_err_probe(dev, ret,
-					     "Failed to allocate irq\n");
+			return ret;
 
 		st->trig = devm_iio_trigger_alloc(dev, "%s-dev%d",
 						  indio_dev->name,

---
base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31
change-id: 20260303-ti-ads1119-2-73294fc211a7

Best regards,
-- 
Felix Gu <ustc.gu@gmail.com>

Re: [PATCH] iio: adc: ti-ads1119: Drop redundant error message

Posted by Jonathan Cameron 1 month ago

On Tue, 03 Mar 2026 01:07:29 +0800
Felix Gu <ustc.gu@gmail.com> wrote:

> devm_request_threaded_irq already prints an error message when failure,
> so the error message is redundant, drop it.
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Hmm. I applied this already and for some reason didn't reply to say so.

So applied.

J
> ---
>  drivers/iio/adc/ti-ads1119.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/ti-ads1119.c b/drivers/iio/adc/ti-ads1119.c
> index c9cedc59cdcd..1157e606bc64 100644
> --- a/drivers/iio/adc/ti-ads1119.c
> +++ b/drivers/iio/adc/ti-ads1119.c
> @@ -740,8 +740,7 @@ static int ads1119_probe(struct i2c_client *client)
>  						NULL, IRQF_ONESHOT,
>  						"ads1119", indio_dev);
>  		if (ret)
> -			return dev_err_probe(dev, ret,
> -					     "Failed to allocate irq\n");
> +			return ret;
>  
>  		st->trig = devm_iio_trigger_alloc(dev, "%s-dev%d",
>  						  indio_dev->name,
> 
> ---
> base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31
> change-id: 20260303-ti-ads1119-2-73294fc211a7
> 
> Best regards,

Re: [PATCH] iio: adc: ti-ads1119: Drop redundant error message

Posted by Markus Elfring 1 month, 1 week ago

> devm_request_threaded_irq already prints an error message when failure,

                           ()                               on execution failure.?


> so the error message is redundant, drop it.


Regards,
Markus

Re: [PATCH] iio: adc: ti-ads1119: Drop redundant error message

Posted by Andy Shevchenko 1 month, 1 week ago

On Tue, Mar 03, 2026 at 01:07:29AM +0800, Felix Gu wrote:
> devm_request_threaded_irq already prints an error message when failure,
> so the error message is redundant, drop it.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: adc: ti-ads1119: Drop redundant error message

Posted by Jonathan Cameron 1 month, 1 week ago

On Mon, 2 Mar 2026 19:15:14 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Tue, Mar 03, 2026 at 01:07:29AM +0800, Felix Gu wrote:
> > devm_request_threaded_irq already prints an error message when failure,
> > so the error message is redundant, drop it.  
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 
Applied to the testing branch of iio.git.

Thanks,

Jonathan