crypto: testmgr - Fix stale references to aes-generic

[PATCH] crypto: testmgr - Fix stale references to aes-generic

Posted by Eric Biggers 1 month, 2 weeks ago

Due to commit a2484474272e ("crypto: aes - Replace aes-generic with
wrapper around lib"), the "aes-generic" driver name has been replaced
with "aes-lib".  Update a couple testmgr entries that were added
concurrently with this change.

Fixes: a22d48cbe558 ("crypto: testmgr - Add test vectors for authenc(hmac(sha224),cbc(aes))")
Fixes: 030218dedee2 ("crypto: testmgr - Add test vectors for authenc(hmac(sha384),cbc(aes))")
Cc: Aleksander Jan Bajkowski <olek2@wp.pl>
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---

This patch is targeting libcrypto-fixes for v7.0

 crypto/testmgr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index 49b607f65f636..4985411dedaec 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -4130,11 +4130,11 @@ static const struct alg_test_desc alg_test_descs[] = {
 		.alg = "authenc(hmac(sha1),rfc3686(ctr(aes)))",
 		.test = alg_test_null,
 		.fips_allowed = 1,
 	}, {
 		.alg = "authenc(hmac(sha224),cbc(aes))",
-		.generic_driver = "authenc(hmac-sha224-lib,cbc(aes-generic))",
+		.generic_driver = "authenc(hmac-sha224-lib,cbc(aes-lib))",
 		.test = alg_test_aead,
 		.suite = {
 			.aead = __VECS(hmac_sha224_aes_cbc_tv_temp)
 		}
 	}, {
@@ -4192,11 +4192,11 @@ static const struct alg_test_desc alg_test_descs[] = {
 		.alg = "authenc(hmac(sha256),rfc3686(ctr(aes)))",
 		.test = alg_test_null,
 		.fips_allowed = 1,
 	}, {
 		.alg = "authenc(hmac(sha384),cbc(aes))",
-		.generic_driver = "authenc(hmac-sha384-lib,cbc(aes-generic))",
+		.generic_driver = "authenc(hmac-sha384-lib,cbc(aes-lib))",
 		.test = alg_test_aead,
 		.suite = {
 			.aead = __VECS(hmac_sha384_aes_cbc_tv_temp)
 		}
 	}, {

base-commit: f33ac74f9cc1cdadd3921246832b2084a5dec53a
-- 
2.53.0

Re: [PATCH] crypto: testmgr - Fix stale references to aes-generic

Posted by Eric Biggers 1 month, 1 week ago

On Mon, Mar 02, 2026 at 03:48:56PM -0800, Eric Biggers wrote:
> Due to commit a2484474272e ("crypto: aes - Replace aes-generic with
> wrapper around lib"), the "aes-generic" driver name has been replaced
> with "aes-lib".  Update a couple testmgr entries that were added
> concurrently with this change.
> 
> Fixes: a22d48cbe558 ("crypto: testmgr - Add test vectors for authenc(hmac(sha224),cbc(aes))")
> Fixes: 030218dedee2 ("crypto: testmgr - Add test vectors for authenc(hmac(sha384),cbc(aes))")
> Cc: Aleksander Jan Bajkowski <olek2@wp.pl>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
> 
> This patch is targeting libcrypto-fixes for v7.0
> 

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-fixes

- Eric

Re: [PATCH] crypto: testmgr - Fix stale references to aes-generic

Posted by Aleksander Jan Bajkowski 1 month, 1 week ago

On 3/3/26 00:48, Eric Biggers wrote:
> Due to commit a2484474272e ("crypto: aes - Replace aes-generic with
> wrapper around lib"), the "aes-generic" driver name has been replaced
> with "aes-lib".  Update a couple testmgr entries that were added
> concurrently with this change.
>
> Fixes: a22d48cbe558 ("crypto: testmgr - Add test vectors for authenc(hmac(sha224),cbc(aes))")
> Fixes: 030218dedee2 ("crypto: testmgr - Add test vectors for authenc(hmac(sha384),cbc(aes))")
> Cc: Aleksander Jan Bajkowski <olek2@wp.pl>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
Acked-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> ---
>
> This patch is targeting libcrypto-fixes for v7.0
>
>   crypto/testmgr.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/crypto/testmgr.c b/crypto/testmgr.c
> index 49b607f65f636..4985411dedaec 100644
> --- a/crypto/testmgr.c
> +++ b/crypto/testmgr.c
> @@ -4130,11 +4130,11 @@ static const struct alg_test_desc alg_test_descs[] = {
>   		.alg = "authenc(hmac(sha1),rfc3686(ctr(aes)))",
>   		.test = alg_test_null,
>   		.fips_allowed = 1,
>   	}, {
>   		.alg = "authenc(hmac(sha224),cbc(aes))",
> -		.generic_driver = "authenc(hmac-sha224-lib,cbc(aes-generic))",
> +		.generic_driver = "authenc(hmac-sha224-lib,cbc(aes-lib))",
>   		.test = alg_test_aead,
>   		.suite = {
>   			.aead = __VECS(hmac_sha224_aes_cbc_tv_temp)
>   		}
>   	}, {
> @@ -4192,11 +4192,11 @@ static const struct alg_test_desc alg_test_descs[] = {
>   		.alg = "authenc(hmac(sha256),rfc3686(ctr(aes)))",
>   		.test = alg_test_null,
>   		.fips_allowed = 1,
>   	}, {
>   		.alg = "authenc(hmac(sha384),cbc(aes))",
> -		.generic_driver = "authenc(hmac-sha384-lib,cbc(aes-generic))",
> +		.generic_driver = "authenc(hmac-sha384-lib,cbc(aes-lib))",
>   		.test = alg_test_aead,
>   		.suite = {
>   			.aead = __VECS(hmac_sha384_aes_cbc_tv_temp)
>   		}
>   	}, {
>
> base-commit: f33ac74f9cc1cdadd3921246832b2084a5dec53a