[v2] staging: rtl8723bs: fix bitwise OR operator spacing

[PATCH v2] staging: rtl8723bs: fix bitwise OR operator spacing

Posted by Jose A. Perez de Azpillaga 3 hours ago

Fix spaces between bitwise OR operations rtw_action_frame_parse() for
better readability.

Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
---
v2:
	- Remove curly braces for single-line statement
	- Move `!=` operator to the end of the first line

 drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index dbd4bcc8cd28..9c1ee1411c9b 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -1123,11 +1123,9 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *act

 	fc = le16_to_cpu(((struct ieee80211_hdr_3addr *)frame)->frame_control);

-	if ((fc & (IEEE80211_FCTL_FTYPE|IEEE80211_FCTL_STYPE))
-		!= (IEEE80211_FTYPE_MGMT|IEEE80211_STYPE_ACTION)
-	) {
+	if ((fc & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE)) !=
+	    (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION))
 		return false;
-	}

 	c = frame_body[0];

--
2.53.0

Re: [PATCH v2] staging: rtl8723bs: fix bitwise OR operator spacing

Posted by Ethan Tidmore 3 hours ago

On Mon Mar 2, 2026 at 3:51 PM CST, Jose A. Perez de Azpillaga wrote:
> Fix spaces between bitwise OR operations rtw_action_frame_parse() for
> better readability.
>
> Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
> ---
> v2:
> 	- Remove curly braces for single-line statement
> 	- Move `!=` operator to the end of the first line

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

Thanks,

ET