[v1] staging: rtl8723bs: fix bitwise OR operator spacing

[PATCH] staging: rtl8723bs: fix bitwise OR operator spacing

Posted by Jose A. Perez de Azpillaga 6 hours ago

Fix spaces between bitwise OR operations rtw_action_frame_parse() for
better readability.

Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index dbd4bcc8cd28..446e4051b9ae 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -1123,8 +1123,8 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *act
 
 	fc = le16_to_cpu(((struct ieee80211_hdr_3addr *)frame)->frame_control);
 
-	if ((fc & (IEEE80211_FCTL_FTYPE|IEEE80211_FCTL_STYPE))
-		!= (IEEE80211_FTYPE_MGMT|IEEE80211_STYPE_ACTION)
+	if ((fc & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE))
+		!= (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION)
 	) {
 		return false;
 	}
-- 
2.53.0

Re: [PATCH] staging: rtl8723bs: fix bitwise OR operator spacing

Posted by Ethan Tidmore 4 hours ago

On Mon Mar 2, 2026 at 12:53 PM CST, Jose A. Perez de Azpillaga wrote:
> Fix spaces between bitwise OR operations rtw_action_frame_parse() for
> better readability.
>
> Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> index dbd4bcc8cd28..446e4051b9ae 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> @@ -1123,8 +1123,8 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *act
>  
>  	fc = le16_to_cpu(((struct ieee80211_hdr_3addr *)frame)->frame_control);
>  
> -	if ((fc & (IEEE80211_FCTL_FTYPE|IEEE80211_FCTL_STYPE))
> -		!= (IEEE80211_FTYPE_MGMT|IEEE80211_STYPE_ACTION)
> +	if ((fc & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE))
> +		!= (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION)
>  	) {
>  		return false;
>  	}

Since you're editing this if statement it's preferred that you tidy it
up according to kernel standards that'd be:

	if ((fc & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE)) !=
	    (IEEE80211_FTYPE_MGMT | IEEE80211_STYPE_ACTION))
	    	return false;

Thanks,

ET