[PATCH] staging: rtl8723bs: rename supportRateNum to support_rate_num

Esther Zilberberg posted 1 patch 1 month, 2 weeks ago
There is a newer version of this series
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c  | 18 +++++++++---------
drivers/staging/rtl8723bs/core/rtw_wlan_util.c |  8 ++++----
2 files changed, 13 insertions(+), 13 deletions(-)
[PATCH] staging: rtl8723bs: rename supportRateNum to support_rate_num
Posted by Esther Zilberberg 1 month, 2 weeks ago
Rename supportRateNum to support_rate_num to fix warning
reported by checkpatch.pl.

Signed-off-by: Esther Zilberberg <esty5664@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c  | 18 +++++++++---------
 drivers/staging/rtl8723bs/core/rtw_wlan_util.c |  8 ++++----
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index b1f20aa81efb..8c76f2c5d282 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -935,7 +935,7 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame)
 	unsigned char WMM_IE[] = {0x00, 0x50, 0xf2, 0x02, 0x00, 0x01};
 	int		i, ie_len, wpa_ie_len, left;
 	unsigned char supportRate[16];
-	int					supportRateNum;
+	int					support_rate_num;
 	unsigned short		status = WLAN_STATUS_SUCCESS;
 	unsigned short		frame_type, ie_offset = 0;
 	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
@@ -1022,7 +1022,7 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame)
 	if (!p) {
 		/*  use our own rate set as statoin used */
 		/* memcpy(supportRate, AP_BSSRATE, AP_BSSRATE_LEN); */
-		/* supportRateNum = AP_BSSRATE_LEN; */
+		/* support_rate_num = AP_BSSRATE_LEN; */
 
 		status = WLAN_STATUS_CHALLENGE_FAIL;
 		goto OnAssocReqFail;
@@ -1031,25 +1031,25 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame)
 			ie_len = sizeof(supportRate);
 
 		memcpy(supportRate, p+2, ie_len);
-		supportRateNum = ie_len;
+		support_rate_num = ie_len;
 
 		p = rtw_get_ie(pframe + WLAN_HDR_A3_LEN + ie_offset, WLAN_EID_EXT_SUPP_RATES, &ie_len,
 				pkt_len - WLAN_HDR_A3_LEN - ie_offset);
 		if (p) {
 
-			if (supportRateNum + ie_len <= sizeof(supportRate)) {
-				memcpy(supportRate+supportRateNum, p+2, ie_len);
-				supportRateNum += ie_len;
+			if (support_rate_num + ie_len <= sizeof(supportRate)) {
+				memcpy(supportRate + support_rate_num, p + 2, ie_len);
+				support_rate_num += ie_len;
 			}
 		}
 	}
 
 	/* todo: mask supportRate between AP & STA -> move to update raid */
-	/* get_matched_rate(pmlmeext, supportRate, &supportRateNum, 0); */
+	/* get_matched_rate(pmlmeext, supportRate, &support_rate_num, 0); */
 
 	/* update station supportRate */
-	pstat->bssratelen = supportRateNum;
-	memcpy(pstat->bssrateset, supportRate, supportRateNum);
+	pstat->bssratelen = support_rate_num;
+	memcpy(pstat->bssrateset, supportRate, support_rate_num);
 	update_basic_rate_table_soft_ap(pstat->bssrateset, pstat->bssratelen);
 
 	/* check RSN/WPA/WPS */
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 3242978da36c..ee06c5888942 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -1593,7 +1593,7 @@ int update_sta_support_rate(struct adapter *padapter, u8 *pvar_ie, uint var_ie_l
 {
 	unsigned int	ie_len;
 	struct ndis_80211_var_ie *pIE;
-	int	supportRateNum = 0;
+	int	support_rate_num = 0;
 	struct mlme_ext_priv *pmlmeext = &(padapter->mlmeextpriv);
 	struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info);
 
@@ -1604,11 +1604,11 @@ int update_sta_support_rate(struct adapter *padapter, u8 *pvar_ie, uint var_ie_l
 		return _FAIL;
 
 	memcpy(pmlmeinfo->FW_sta_info[cam_idx].SupportedRates, pIE->data, ie_len);
-	supportRateNum = ie_len;
+	support_rate_num = ie_len;
 
 	pIE = (struct ndis_80211_var_ie *)rtw_get_ie(pvar_ie, WLAN_EID_EXT_SUPP_RATES, &ie_len, var_ie_len);
-	if (pIE && (ie_len <= sizeof(pmlmeinfo->FW_sta_info[cam_idx].SupportedRates) - supportRateNum))
-		memcpy((pmlmeinfo->FW_sta_info[cam_idx].SupportedRates + supportRateNum), pIE->data, ie_len);
+	if (pIE && (ie_len <= sizeof(pmlmeinfo->FW_sta_info[cam_idx].SupportedRates) - support_rate_num))
+		memcpy((pmlmeinfo->FW_sta_info[cam_idx].SupportedRates + support_rate_num), pIE->data, ie_len);
 
 	return _SUCCESS;
 }
-- 
2.43.0
Re: [PATCH] staging: rtl8723bs: rename supportRateNum to support_rate_num
Posted by Ethan Tidmore 1 month, 2 weeks ago
On Mon Mar 2, 2026 at 3:08 AM CST, Esther Zilberberg wrote:
> Rename supportRateNum to support_rate_num to fix warning
> reported by checkpatch.pl.
>
> Signed-off-by: Esther Zilberberg <esty5664@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c  | 18 +++++++++---------
>  drivers/staging/rtl8723bs/core/rtw_wlan_util.c |  8 ++++----
>  2 files changed, 13 insertions(+), 13 deletions(-)

Which branch are you using?

Thanks,

ET
Re: [PATCH] staging: rtl8723bs: rename supportRateNum to support_rate_num
Posted by Esther Zilberberg 1 month, 1 week ago
On Mon, Mar 2, 2026 at 7:43 PM Ethan Tidmore <ethantidmore06@gmail.com> wrote:
>
> On Mon Mar 2, 2026 at 3:08 AM CST, Esther Zilberberg wrote:
> > Rename supportRateNum to support_rate_num to fix warning
> > reported by checkpatch.pl.
> >
> > Signed-off-by: Esther Zilberberg <esty5664@gmail.com>
> > ---
> >  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c  | 18 +++++++++---------
> >  drivers/staging/rtl8723bs/core/rtw_wlan_util.c |  8 ++++----
> >  2 files changed, 13 insertions(+), 13 deletions(-)
>
> Which branch are you using?
>
> Thanks,
>
> ET
I am using the mainline (master) branch.

Thanks,
Esther
Re: [PATCH] staging: rtl8723bs: rename supportRateNum to support_rate_num
Posted by Ethan Tidmore 1 month, 1 week ago
On Wed Mar 4, 2026 at 2:39 PM CST, Esther Zilberberg wrote:
> On Mon, Mar 2, 2026 at 7:43 PM Ethan Tidmore <ethantidmore06@gmail.com> wrote:
>>
>> On Mon Mar 2, 2026 at 3:08 AM CST, Esther Zilberberg wrote:
>> > Rename supportRateNum to support_rate_num to fix warning
>> > reported by checkpatch.pl.
>> >
>> > Signed-off-by: Esther Zilberberg <esty5664@gmail.com>
>> > ---

...

> I am using the mainline (master) branch.
>
> Thanks,
> Esther

When I tried to apply this patch against staging-next it didn't apply
cleanly, so try and rebase it against staging-next.

Thanks,

ET
Re: [PATCH] staging: rtl8723bs: rename supportRateNum to support_rate_num
Posted by Esther Zilberberg 1 month, 1 week ago
On Wed, Mar 4, 2026 at 11:01 PM Ethan Tidmore <ethantidmore06@gmail.com> wrote:
>
> On Wed Mar 4, 2026 at 2:39 PM CST, Esther Zilberberg wrote:
> > On Mon, Mar 2, 2026 at 7:43 PM Ethan Tidmore <ethantidmore06@gmail.com> wrote:
> >>
> >> On Mon Mar 2, 2026 at 3:08 AM CST, Esther Zilberberg wrote:
> >> > Rename supportRateNum to support_rate_num to fix warning
> >> > reported by checkpatch.pl.
> >> >
> >> > Signed-off-by: Esther Zilberberg <esty5664@gmail.com>
> >> > ---
>
> ...
>
> > I am using the mainline (master) branch.
> >
> > Thanks,
> > Esther
>
> When I tried to apply this patch against staging-next it didn't apply
> cleanly, so try and rebase it against staging-next.
>
> Thanks,
>
> ET

Hi,

I have rebased the patch on staging-next and sent v2:
https://lore.kernel.org/linux-staging/20260307234430.5439-1-esty5664@gmail.com/T/#u

Thanks,
Esther