include/linux/cred.h | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
Use the correct function parameter names, function names, or kernel-doc
format, and add function return comment sections to avoid kernel-doc
warnings:
Warning: include/linux/cred.h:43 function parameter 'gi' not described
in 'get_group_info'
Warning: include/linux/cred.h:43 No description found for return value
of 'get_group_info'
Warning: include/linux/cred.h:213 No description found for return value
of 'get_cred_many'
Warning: include/linux/cred.h:260 function parameter '_cred' not described
in 'put_cred_many'
Warning: include/linux/cred.h:260 expecting prototype for put_cred().
Prototype was for put_cred_many() instead
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Paul Moore <paul@paul-moore.com>
Cc: Serge Hallyn <sergeh@kernel.org>
Cc: linux-security-module@vger.kernel.org
include/linux/cred.h | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
--- linux-next-20260227.orig/include/linux/cred.h
+++ linux-next-20260227/include/linux/cred.h
@@ -33,12 +33,14 @@ struct group_info {
/**
* get_group_info - Get a reference to a group info structure
- * @group_info: The group info to reference
+ * @gi: The group info to reference
*
* This gets a reference to a set of supplementary groups.
*
* If the caller is accessing a task's credentials, they must hold the RCU read
* lock when reading.
+ *
+ * Returns: @gi
*/
static inline struct group_info *get_group_info(struct group_info *gi)
{
@@ -209,6 +211,8 @@ DEFINE_CLASS(override_creds,
* usage count. The purpose of this is to attempt to catch at compile time the
* accidental alteration of a set of credentials that should be considered
* immutable.
+ *
+ * Returns: @cred when the references are acquired, NULL otherwise.
*/
static inline const struct cred *get_cred_many(const struct cred *cred, int nr)
{
@@ -246,8 +250,8 @@ static inline const struct cred *get_cre
}
/**
- * put_cred - Release a reference to a set of credentials
- * @cred: The credentials to release
+ * put_cred_many - Release a reference to a set of credentials
+ * @_cred: The credentials to release
* @nr: Number of references to release
*
* Release a reference to a set of credentials, deleting them when the last ref
On Mar 1, 2026 Randy Dunlap <rdunlap@infradead.org> wrote: > > Use the correct function parameter names, function names, or kernel-doc > format, and add function return comment sections to avoid kernel-doc > warnings: > > Warning: include/linux/cred.h:43 function parameter 'gi' not described > in 'get_group_info' > Warning: include/linux/cred.h:43 No description found for return value > of 'get_group_info' > Warning: include/linux/cred.h:213 No description found for return value > of 'get_cred_many' > Warning: include/linux/cred.h:260 function parameter '_cred' not described > in 'put_cred_many' > Warning: include/linux/cred.h:260 expecting prototype for put_cred(). > Prototype was for put_cred_many() instead > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > --- > Cc: Paul Moore <paul@paul-moore.com> > Cc: Serge Hallyn <sergeh@kernel.org> > Cc: linux-security-module@vger.kernel.org > > include/linux/cred.h | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) Merged into lsm/dev, thanks. -- paul-moore.com
© 2016 - 2026 Red Hat, Inc.