[PATCH] lib/glob: clean up "bool abuse" in pointer arithmetic

Josh Law posted 1 patch 1 month, 2 weeks ago
lib/glob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] lib/glob: clean up "bool abuse" in pointer arithmetic
Posted by Josh Law 1 month, 2 weeks ago
From: Josh Law <objecting@objecting.org>

Replace the implicit 'bool' to 'int' conversion with an explicit
ternary operator. This makes the pointer arithmetic clearer and
avoids relying on boolean memory representation for logic flow.

Signed-off-by: Josh Law <objecting@objecting.org>
---
 lib/glob.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/glob.c b/lib/glob.c
index 877bdd0884a6..69311568ad3d 100644
--- a/lib/glob.c
+++ b/lib/glob.c
@@ -73,7 +73,7 @@ bool __pure glob_match(char const *pat, char const *str)
 			if (c == '\0')	/* No possible match */
 				return false;
 			bool match = false, inverted = (*pat == '!');
-			char const *class = pat + inverted;
+			char const *class = inverted ? pat + 1 : pat;
 			unsigned char a = *class++;
 
 			/*
-- 
2.43.0