drivers/nfc/nxp-nci/firmware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
From: Tomasz Unger <tomasz.unger@yahoo.pl>
Replace strcpy() with strscpy() which limits the copy to the size of
the destination buffer. Since fw_info->name is an array, the
two-argument variant of strscpy() is used - the compiler deduces
the buffer size automatically.
This is a defensive cleanup replacing the deprecated strcpy()
with the preferred strscpy().
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
Testing:
- checkpatch.pl: 0 errors, 0 warnings
- make M=drivers/nfc/nxp-nci/: compiled successfully, 0 errors, 0 warnings
- Module loaded successfully in QEMU (x86_64) with buildroot:
modprobe nxp-nci - no errors, confirmed via lsmod
drivers/nfc/nxp-nci/firmware.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nfc/nxp-nci/firmware.c b/drivers/nfc/nxp-nci/firmware.c
index 381b5bb75477..a9533977aff8 100644
--- a/drivers/nfc/nxp-nci/firmware.c
+++ b/drivers/nfc/nxp-nci/firmware.c
@@ -211,7 +211,7 @@ int nxp_nci_fw_download(struct nci_dev *ndev, const char *firmware_name)
goto fw_download_exit;
}
- strcpy(fw_info->name, firmware_name);
+ strscpy(fw_info->name, firmware_name);
r = request_firmware(&fw_info->fw, firmware_name,
ndev->nfc_dev->dev.parent);
--
2.53.0
On Sun, Mar 01, 2026 at 02:56:33PM +0100, tomasz.unger@yahoo.pl wrote: > From: Tomasz Unger <tomasz.unger@yahoo.pl> > > Replace strcpy() with strscpy() which limits the copy to the size of > the destination buffer. Since fw_info->name is an array, the > two-argument variant of strscpy() is used - the compiler deduces > the buffer size automatically. > > This is a defensive cleanup replacing the deprecated strcpy() > with the preferred strscpy(). > > Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> > --- > Testing: > - checkpatch.pl: 0 errors, 0 warnings > - make M=drivers/nfc/nxp-nci/: compiled successfully, 0 errors, 0 warnings > - Module loaded successfully in QEMU (x86_64) with buildroot: > modprobe nxp-nci - no errors, confirmed via lsmod Reviewed-by: Simon Horman <horms@kernel.org>
© 2016 - 2026 Red Hat, Inc.