media: ti: vpe: Add missing v4l2_device_unregister in vip_remove()

[PATCH] media: ti: vpe: Add missing v4l2_device_unregister in vip_remove()

Posted by Felix Gu 1 month, 2 weeks ago

The v4l2_device is registered during probe but was not being unregistered
during remove. Add the missing v4l2_device_unregister() call to properly
clean up resources.

Fixes: fc2873aa4a21 ("media: ti: vpe: Add the VIP driver")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
 drivers/media/platform/ti/vpe/vip.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/ti/vpe/vip.c b/drivers/media/platform/ti/vpe/vip.c
index a4b616a5ece7..0e91e87bda9b 100644
--- a/drivers/media/platform/ti/vpe/vip.c
+++ b/drivers/media/platform/ti/vpe/vip.c
@@ -3641,6 +3641,7 @@ static void vip_remove(struct platform_device *pdev)
 	}
 
 	v4l2_ctrl_handler_free(&shared->ctrl_handler);
+	v4l2_device_unregister(&shared->v4l2_dev);
 
 	pm_runtime_put_sync(&pdev->dev);
 	pm_runtime_disable(&pdev->dev);

---
base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31
change-id: 20260301-vip-c6e932239447

Best regards,
-- 
Felix Gu <ustc.gu@gmail.com>

Re: [PATCH] media: ti: vpe: Add missing v4l2_device_unregister in vip_remove()

Posted by Yemike Abhilash Chandra 1 month, 1 week ago


On 01/03/26 19:09, Felix Gu wrote:
> The v4l2_device is registered during probe but was not being unregistered
> during remove. Add the missing v4l2_device_unregister() call to properly
> clean up resources.
> 
> Fixes: fc2873aa4a21 ("media: ti: vpe: Add the VIP driver")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
> ---

Reviewed-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>

>   drivers/media/platform/ti/vpe/vip.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/ti/vpe/vip.c b/drivers/media/platform/ti/vpe/vip.c
> index a4b616a5ece7..0e91e87bda9b 100644
> --- a/drivers/media/platform/ti/vpe/vip.c
> +++ b/drivers/media/platform/ti/vpe/vip.c
> @@ -3641,6 +3641,7 @@ static void vip_remove(struct platform_device *pdev)
>   	}
>   
>   	v4l2_ctrl_handler_free(&shared->ctrl_handler);
> +	v4l2_device_unregister(&shared->v4l2_dev);
>   
>   	pm_runtime_put_sync(&pdev->dev);
>   	pm_runtime_disable(&pdev->dev);
> 
> ---
> base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31
> change-id: 20260301-vip-c6e932239447
> 
> Best regards,