[PATCH] staging: vme_user: remove unimplemented #if 0 code blocks

Albab Hasan posted 1 patch 1 month, 2 weeks ago
drivers/staging/vme_user/vme_user.h | 10 ----------
1 file changed, 10 deletions(-)
[PATCH] staging: vme_user: remove unimplemented #if 0 code blocks
Posted by Albab Hasan 1 month, 2 weeks ago
Remove dead code in #if 0 blocks from struct vme_master
and struct vme_slave. these were never implemented or
compiled in.

checkpatch.pl reports:

WARNING: Consider removing the code enclosed by this #if 0 and its #endif

No functional changes.

Signed-off-by: Albab Hasan <albabhasan276@gmail.com>
---
 drivers/staging/vme_user/vme_user.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/staging/vme_user/vme_user.h b/drivers/staging/vme_user/vme_user.h
index 19ecb05781cc..9e010974351d 100644
--- a/drivers/staging/vme_user/vme_user.h
+++ b/drivers/staging/vme_user/vme_user.h
@@ -14,11 +14,6 @@ struct vme_master {
 	__u32 aspace;		/* Address Space */
 	__u32 cycle;		/* Cycle properties */
 	__u32 dwidth;		/* Maximum Data Width */
-#if 0
-	char prefetchenable;		/* Prefetch Read Enable State */
-	int prefetchsize;		/* Prefetch Read Size (Cache Lines) */
-	char wrpostenable;		/* Write Post State */
-#endif
 } __packed;
 
 /*
@@ -35,11 +30,6 @@ struct vme_slave {
 	__u64 size;		/* Window Size */
 	__u32 aspace;		/* Address Space */
 	__u32 cycle;		/* Cycle properties */
-#if 0
-	char wrpostenable;		/* Write Post State */
-	char rmwlock;			/* Lock PCI during RMW Cycles */
-	char data64bitcapable;		/* non-VMEbus capable of 64-bit Data */
-#endif
 } __packed;
 
 struct vme_irq_id {
-- 
2.43.0
Re: [PATCH] staging: vme_user: remove unimplemented #if 0 code blocks
Posted by Ethan Tidmore 1 month, 2 weeks ago
On Sat Feb 28, 2026 at 9:38 AM CST, Albab Hasan wrote:
> Remove dead code in #if 0 blocks from struct vme_master
> and struct vme_slave. these were never implemented or
> compiled in.
>
> checkpatch.pl reports:
>
> WARNING: Consider removing the code enclosed by this #if 0 and its #endif
>
> No functional changes.
>
> Signed-off-by: Albab Hasan <albabhasan276@gmail.com>
> ---

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

Thanks,

ET