HID: hid-lenovo-go-s: Remove unneeded semicolon

[PATCH] HID: hid-lenovo-go-s: Remove unneeded semicolon

Posted by Chen Ni 1 month, 2 weeks ago

Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
semantic patch at scripts/coccinelle/misc/semicolon.cocci.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/hid/hid-lenovo-go-s.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-lenovo-go-s.c b/drivers/hid/hid-lenovo-go-s.c
index cacc5bd5ed2b..d1eb067509f6 100644
--- a/drivers/hid/hid-lenovo-go-s.c
+++ b/drivers/hid/hid-lenovo-go-s.c
@@ -1102,7 +1102,7 @@ static void hid_gos_brightness_set(struct led_classdev *led_cdev,
 	default:
 		dev_err(led_cdev->dev, "Failed to write RGB profile: %i\n",
 			ret);
-	};
+	}
 }
 
 #define LEGOS_DEVICE_ATTR_RW(_name, _attrname, _rtype, _group)                 \
-- 
2.25.1

Re: [PATCH] HID: hid-lenovo-go-s: Remove unneeded semicolon

Posted by Derek John Clark 1 month, 1 week ago

On Fri, Feb 27, 2026 at 7:44 PM Chen Ni <nichen@iscas.ac.cn> wrote:
>
> Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
> semantic patch at scripts/coccinelle/misc/semicolon.cocci.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/hid/hid-lenovo-go-s.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-lenovo-go-s.c b/drivers/hid/hid-lenovo-go-s.c
> index cacc5bd5ed2b..d1eb067509f6 100644
> --- a/drivers/hid/hid-lenovo-go-s.c
> +++ b/drivers/hid/hid-lenovo-go-s.c
> @@ -1102,7 +1102,7 @@ static void hid_gos_brightness_set(struct led_classdev *led_cdev,
>         default:
>                 dev_err(led_cdev->dev, "Failed to write RGB profile: %i\n",
>                         ret);
> -       };
> +       }
>  }
>
>  #define LEGOS_DEVICE_ATTR_RW(_name, _attrname, _rtype, _group)                 \
> --
> 2.25.1
>

Reviewed-by: Derek J. Clark <derekjohn.clark@gmail.com>

Re: [PATCH] HID: hid-lenovo-go-s: Remove unneeded semicolon

Posted by Mark Pearson 1 month, 2 weeks ago

On Fri, Feb 27, 2026, at 10:43 PM, Chen Ni wrote:
> Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
> semantic patch at scripts/coccinelle/misc/semicolon.cocci.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/hid/hid-lenovo-go-s.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-lenovo-go-s.c 
> b/drivers/hid/hid-lenovo-go-s.c
> index cacc5bd5ed2b..d1eb067509f6 100644
> --- a/drivers/hid/hid-lenovo-go-s.c
> +++ b/drivers/hid/hid-lenovo-go-s.c
> @@ -1102,7 +1102,7 @@ static void hid_gos_brightness_set(struct 
> led_classdev *led_cdev,
>  	default:
>  		dev_err(led_cdev->dev, "Failed to write RGB profile: %i\n",
>  			ret);
> -	};
> +	}
>  }
> 
>  #define LEGOS_DEVICE_ATTR_RW(_name, _attrname, _rtype, _group)         
>         \
> -- 
> 2.25.1

Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>