crash_dump: Fix typo in function name read_key_from_user_keying

[PATCH] crash_dump: Fix typo in function name read_key_from_user_keying

Posted by Thorsten Blum 1 month, 2 weeks ago

The function read_key_from_user_keying() is missing an 'r' in its name.
Fix the typo by renaming it to read_key_from_user_keyring().

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 kernel/crash_dump_dm_crypt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/crash_dump_dm_crypt.c b/kernel/crash_dump_dm_crypt.c
index 27a144920562..dcb69e96c6ff 100644
--- a/kernel/crash_dump_dm_crypt.c
+++ b/kernel/crash_dump_dm_crypt.c
@@ -139,7 +139,7 @@ static int restore_dm_crypt_keys_to_thread_keyring(void)
 	return 0;
 }
 
-static int read_key_from_user_keying(struct dm_crypt_key *dm_key)
+static int read_key_from_user_keyring(struct dm_crypt_key *dm_key)
 {
 	const struct user_key_payload *ukp;
 	struct key *key;
@@ -387,7 +387,7 @@ static int build_keys_header(void)
 
 		strscpy(keys_header->keys[i].key_desc, key->description,
 			KEY_DESC_MAX_LEN);
-		r = read_key_from_user_keying(&keys_header->keys[i]);
+		r = read_key_from_user_keyring(&keys_header->keys[i]);
 		if (r != 0) {
 			kexec_dprintk("Failed to read key %s\n",
 				      keys_header->keys[i].key_desc);
-- 
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4

Re: [PATCH] crash_dump: Fix typo in function name read_key_from_user_keying

Posted by Baoquan He 1 month, 2 weeks ago

On 02/28/26 at 12:04am, Thorsten Blum wrote:
> The function read_key_from_user_keying() is missing an 'r' in its name.
> Fix the typo by renaming it to read_key_from_user_keyring().
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  kernel/crash_dump_dm_crypt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/crash_dump_dm_crypt.c b/kernel/crash_dump_dm_crypt.c
> index 27a144920562..dcb69e96c6ff 100644
> --- a/kernel/crash_dump_dm_crypt.c
> +++ b/kernel/crash_dump_dm_crypt.c
> @@ -139,7 +139,7 @@ static int restore_dm_crypt_keys_to_thread_keyring(void)
>  	return 0;
>  }
>  
> -static int read_key_from_user_keying(struct dm_crypt_key *dm_key)
> +static int read_key_from_user_keyring(struct dm_crypt_key *dm_key)

Good catch.

Acked-by: Baoquan He <bhe@redhat.com>

By the way, it's better to wrap these cleanup/fix patches into a
patchset for easier reviewing and merging when you are exploring code
flow of one feature/component. Anyway, thanks.

>  {
>  	const struct user_key_payload *ukp;
>  	struct key *key;
> @@ -387,7 +387,7 @@ static int build_keys_header(void)
>  
>  		strscpy(keys_header->keys[i].key_desc, key->description,
>  			KEY_DESC_MAX_LEN);
> -		r = read_key_from_user_keying(&keys_header->keys[i]);
> +		r = read_key_from_user_keyring(&keys_header->keys[i]);
>  		if (r != 0) {
>  			kexec_dprintk("Failed to read key %s\n",
>  				      keys_header->keys[i].key_desc);
> -- 
> Thorsten Blum <thorsten.blum@linux.dev>
> GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4
> 
>