[PATCH net-next v5 4/5] net: cadence: macb: enable EEE for Raspberry Pi RP1

Nicolai Buchwitz posted 5 patches 1 month, 1 week ago
[PATCH net-next v5 4/5] net: cadence: macb: enable EEE for Raspberry Pi RP1
Posted by Nicolai Buchwitz 1 month, 1 week ago
Set MACB_CAPS_EEE for the Raspberry Pi 5 RP1 southbridge
(Cadence GEM_GXL rev 0x00070109 paired with BCM54213PE PHY).

EEE has been verified on RP1 hardware: the LPI counter registers
at 0x270-0x27c return valid data, the TXLPIEN bit in NCR (bit 19)
controls LPI transmission correctly, and ethtool --show-eee reports
the negotiated state after link-up.

Other GEM variants that share the same LPI register layout (SAMA5D2,
SAME70, PIC32CZ) can be enabled by adding MACB_CAPS_EEE to their
respective config entries once tested.

Reviewed-by: Théo Lebrun <theo.lebrun@bootlin.com>
Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
---
 drivers/net/ethernet/cadence/macb_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 3e724417d444..0196a13c0688 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -5529,7 +5529,8 @@ static const struct macb_config eyeq5_config = {
 static const struct macb_config raspberrypi_rp1_config = {
 	.caps = MACB_CAPS_GIGABIT_MODE_AVAILABLE | MACB_CAPS_CLK_HW_CHG |
 		MACB_CAPS_JUMBO |
-		MACB_CAPS_GEM_HAS_PTP,
+		MACB_CAPS_GEM_HAS_PTP |
+		MACB_CAPS_EEE,
 	.dma_burst_length = 16,
 	.clk_init = macb_clk_init,
 	.init = macb_init,
-- 
2.51.0

Re: [PATCH net-next v5 4/5] net: cadence: macb: enable EEE for Raspberry Pi RP1
Posted by Claudiu Beznea 1 month, 1 week ago

On 2/27/26 17:06, Nicolai Buchwitz wrote:
> Set MACB_CAPS_EEE for the Raspberry Pi 5 RP1 southbridge
> (Cadence GEM_GXL rev 0x00070109 paired with BCM54213PE PHY).
> 
> EEE has been verified on RP1 hardware: the LPI counter registers
> at 0x270-0x27c return valid data, the TXLPIEN bit in NCR (bit 19)
> controls LPI transmission correctly, and ethtool --show-eee reports
> the negotiated state after link-up.
> 
> Other GEM variants that share the same LPI register layout (SAMA5D2,
> SAME70, PIC32CZ) can be enabled by adding MACB_CAPS_EEE to their
> respective config entries once tested.
> 
> Reviewed-by: Théo Lebrun<theo.lebrun@bootlin.com>
> Signed-off-by: Nicolai Buchwitz<nb@tipi-net.de>

Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>