[PATCH] integrity: digsig: Add blank line after declarations

Chi Wang posted 1 patch 1 month, 1 week ago
security/integrity/digsig.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] integrity: digsig: Add blank line after declarations
Posted by Chi Wang 1 month, 1 week ago
From: Chi Wang <wangchi@kylinos.cn>

Fixes checkpatch warning:
WARNING: Missing a blank line after declarations
+                       int err = PTR_ERR(keyring[id]);
+                       pr_err("no %s keyring: %d\n", keyring_name[id], err);

Add a blank line after the variable declaration to comply with
the kernel coding style.

Signed-off-by: Chi Wang <wangchi@kylinos.cn>
---
 security/integrity/digsig.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c
index aec350abad86..5e7ba7d3cf99 100644
--- a/security/integrity/digsig.c
+++ b/security/integrity/digsig.c
@@ -49,6 +49,7 @@ static struct key *integrity_keyring_from_id(const unsigned int id)
 			request_key(&key_type_keyring, keyring_name[id], NULL);
 		if (IS_ERR(keyring[id])) {
 			int err = PTR_ERR(keyring[id]);
+
 			pr_err("no %s keyring: %d\n", keyring_name[id], err);
 			keyring[id] = NULL;
 			return ERR_PTR(err);
-- 
2.25.1
Re: [PATCH] integrity: digsig: Add blank line after declarations
Posted by Mimi Zohar 1 month, 1 week ago
On Fri, 2026-02-27 at 14:23 +0800, Chi Wang wrote:
> From: Chi Wang <wangchi@kylinos.cn>
> 
> Fixes checkpatch warning:
> WARNING: Missing a blank line after declarations
> +                       int err = PTR_ERR(keyring[id]);
> +                       pr_err("no %s keyring: %d\n", keyring_name[id], err);
> 
> Add a blank line after the variable declaration to comply with
> the kernel coding style.
> 
> Signed-off-by: Chi Wang <wangchi@kylinos.cn>

Agreed checkpatch complains today, but probably not back in 2011 when the patch
was upstreamed.  Cosmetic changes are normally upstreamed only with other
changes.

thanks,

Mimi