[PATCH 3/3] iio: filter: admv8818: Minor cleanups

Ethan Tidmore posted 3 patches 1 month, 1 week ago
[PATCH 3/3] iio: filter: admv8818: Minor cleanups
Posted by Ethan Tidmore 1 month, 1 week ago
Resolve every checkpatch error in the driver.

Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
---
 drivers/iio/filter/admv8818.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/filter/admv8818.c b/drivers/iio/filter/admv8818.c
index 2d12700d717f..1af263007322 100644
--- a/drivers/iio/filter/admv8818.c
+++ b/drivers/iio/filter/admv8818.c
@@ -240,7 +240,6 @@ static int __admv8818_lpf_select(struct admv8818_state *st, u64 freq)
 		freq_step = div_u64(freq_step, ADMV8818_NUM_STATES - 1);
 
 		for (state = ADMV8818_STATE_MAX; state >= ADMV8818_STATE_MIN; --state) {
-
 			freq_corner = freq_range_lpf[band][ADMV8818_BAND_CORNER_LOW] +
 				      state * freq_step;
 
@@ -385,8 +384,8 @@ static int admv8818_read_lpf_freq(struct admv8818_state *st, u64 *lpf_freq)
 }
 
 static int admv8818_write_raw_get_fmt(struct iio_dev *indio_dev,
-								struct iio_chan_spec const *chan,
-								long mask)
+				      struct iio_chan_spec const *chan,
+				      long mask)
 {
 	switch (mask) {
 	case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY:
@@ -722,7 +721,6 @@ static int admv8818_read_properties(struct admv8818_state *st)
 	else
 		return ret;
 
-
 	ret = device_property_read_u32(&spi->dev, "adi,hpf-margin-mhz", &mhz);
 	if (ret == 0)
 		st->hpf_margin_hz = (u64)mhz * HZ_PER_MHZ;
-- 
2.53.0
Re: [PATCH 3/3] iio: filter: admv8818: Minor cleanups
Posted by Andy Shevchenko 1 month, 1 week ago
On Fri, Feb 27, 2026 at 12:14:24AM -0600, Ethan Tidmore wrote:
> Resolve every checkpatch error in the driver.

Poorly written commit message and Subject. Please, be more explicit:

Ex.:

  iio: filter: ...: Fix indentation issues in a couple of places

  Fix indentation issue of the parameters in admv8818_write_raw_get_fmt()
  and remove extra blank lines elsewhere.

Read this: https://chris.beams.io/git-commit

-- 
With Best Regards,
Andy Shevchenko