[PATCH v2] staging: rtl8723bs: fix CamelCase variable name

Rivka Bukchin posted 1 patch 1 month, 1 week ago
drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH v2] staging: rtl8723bs: fix CamelCase variable name
Posted by Rivka Bukchin 1 month, 1 week ago
Rename pHT_info_ie to ht_info_ie to address checkpatch warning.

Signed-off-by: Rivka Bukchin <rivkab300@gmail.com>

---
v2:
- Use full real name in Signed-off-by and From fields
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 67197c7d4..9ab2219cd 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -802,7 +802,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 	int ret = _SUCCESS;
 	u8 *p;
 	u8 *pHT_caps_ie = NULL;
-	u8 *pHT_info_ie = NULL;
+	u8 *ht_info_ie = NULL;
 	struct sta_info *psta = NULL;
 	u16 cap, ht_cap = false;
 	uint ie_len = 0;
@@ -1060,7 +1060,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 		       &ie_len,
 		       (pbss_network->ie_length - _BEACON_IE_OFFSET_));
 	if (p && ie_len > 0)
-		pHT_info_ie = p;
+		ht_info_ie = p;
 
 	switch (network_type) {
 	case WIRELESS_11B:
@@ -1097,7 +1097,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 
 		HT_caps_handler(padapter, (struct ndis_80211_var_ie *)pHT_caps_ie);
 
-		HT_info_handler(padapter, (struct ndis_80211_var_ie *)pHT_info_ie);
+		HT_info_handler(padapter, (struct ndis_80211_var_ie *)ht_info_ie);
 	}
 
 	pbss_network->length =
-- 
2.34.1
Re: [PATCH v2] staging: rtl8723bs: fix CamelCase variable name
Posted by Ethan Tidmore 1 month, 1 week ago
On Thu Feb 26, 2026 at 2:43 AM CST, Rivka Bukchin wrote:
> Rename pHT_info_ie to ht_info_ie to address checkpatch warning.
>
> Signed-off-by: Rivka Bukchin <rivkab300@gmail.com>
>
> ---
> v2:
> - Use full real name in Signed-off-by and From fields
> ---
>  drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>

You have a few issues with your commit body, please view this on how to
send a v2:

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

>  	int ret = _SUCCESS;
>  	u8 *p;
>  	u8 *pHT_caps_ie = NULL;

It'd be nice if you changed this to snake_case too.

Thanks,

ET