[PATCH v6 01/12] dt-bindings: document access-controllers property for coresight peripherals

Gatien Chevallier posted 12 patches 1 month ago
[PATCH v6 01/12] dt-bindings: document access-controllers property for coresight peripherals
Posted by Gatien Chevallier 1 month ago
Document the access-controllers for coresight peripherals in case some
access checks need to be performed to use them.

Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml           | 3 +++
 .../devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml          | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml           | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml           | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml           | 3 +++
 Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml          | 3 +++
 6 files changed, 18 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
index 2a91670ccb8c..949444aba1f8 100644
--- a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
+++ b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
@@ -128,6 +128,9 @@ properties:
   "#address-cells":
     const: 1
 
+  access-controllers:
+    maxItems: 1
+
 patternProperties:
   '^trig-conns@([0-9]+)$':
     type: object
diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
index b74db15e5f8a..b0693cd46d27 100644
--- a/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
+++ b/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
@@ -78,6 +78,9 @@ properties:
         description: Output connection to CoreSight Trace bus
         $ref: /schemas/graph.yaml#/properties/port
 
+  access-controllers:
+    maxItems: 1
+
 required:
   - compatible
   - reg
diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml
index 71f2e1ed27e5..10ebbbeadf93 100644
--- a/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml
+++ b/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml
@@ -118,6 +118,9 @@ properties:
         description: Output connection from the ETM to CoreSight Trace bus.
         $ref: /schemas/graph.yaml#/properties/port
 
+  access-controllers:
+    maxItems: 1
+
 required:
   - compatible
   - clocks
diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml
index 378380c3f5aa..f243e76f597f 100644
--- a/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml
+++ b/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml
@@ -73,6 +73,9 @@ properties:
         description: Output connection to the CoreSight Trace bus.
         $ref: /schemas/graph.yaml#/properties/port
 
+  access-controllers:
+    maxItems: 1
+
 required:
   - compatible
   - reg
diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
index 96dd5b5f771a..9dc096698c65 100644
--- a/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
+++ b/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
@@ -128,6 +128,9 @@ properties:
       - const: tracedata
       - const: metadata
 
+  access-controllers:
+    maxItems: 1
+
 required:
   - compatible
   - reg
diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml
index a207f6899e67..29bbc3961fdf 100644
--- a/Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml
+++ b/Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml
@@ -70,6 +70,9 @@ properties:
         description: Input connection from the CoreSight Trace bus.
         $ref: /schemas/graph.yaml#/properties/port
 
+  access-controllers:
+    maxItems: 1
+
 required:
   - compatible
   - reg

-- 
2.43.0
Re: [PATCH v6 01/12] dt-bindings: document access-controllers property for coresight peripherals
Posted by Suzuki K Poulose 1 month ago
Hi

On 26/02/2026 10:30, Gatien Chevallier wrote:
> Document the access-controllers for coresight peripherals in case some
> access checks need to be performed to use them.
> 
> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>   Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml           | 3 +++
>   .../devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml          | 3 +++
>   Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml           | 3 +++
>   Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml           | 3 +++
>   Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml           | 3 +++
>   Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml          | 3 +++

Are you sure, you are not missing "replicator" in the list ?

Otherwise, looks good to me.

Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>



>   6 files changed, 18 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
> index 2a91670ccb8c..949444aba1f8 100644
> --- a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
> @@ -128,6 +128,9 @@ properties:
>     "#address-cells":
>       const: 1
>   
> +  access-controllers:
> +    maxItems: 1
> +
>   patternProperties:
>     '^trig-conns@([0-9]+)$':
>       type: object
> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
> index b74db15e5f8a..b0693cd46d27 100644
> --- a/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
> @@ -78,6 +78,9 @@ properties:
>           description: Output connection to CoreSight Trace bus
>           $ref: /schemas/graph.yaml#/properties/port
>   
> +  access-controllers:
> +    maxItems: 1
> +
>   required:
>     - compatible
>     - reg
> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml
> index 71f2e1ed27e5..10ebbbeadf93 100644
> --- a/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml
> @@ -118,6 +118,9 @@ properties:
>           description: Output connection from the ETM to CoreSight Trace bus.
>           $ref: /schemas/graph.yaml#/properties/port
>   
> +  access-controllers:
> +    maxItems: 1
> +
>   required:
>     - compatible
>     - clocks
> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml
> index 378380c3f5aa..f243e76f597f 100644
> --- a/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml
> @@ -73,6 +73,9 @@ properties:
>           description: Output connection to the CoreSight Trace bus.
>           $ref: /schemas/graph.yaml#/properties/port
>   
> +  access-controllers:
> +    maxItems: 1
> +
>   required:
>     - compatible
>     - reg
> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
> index 96dd5b5f771a..9dc096698c65 100644
> --- a/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
> @@ -128,6 +128,9 @@ properties:
>         - const: tracedata
>         - const: metadata
>   
> +  access-controllers:
> +    maxItems: 1
> +
>   required:
>     - compatible
>     - reg
> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml
> index a207f6899e67..29bbc3961fdf 100644
> --- a/Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml
> @@ -70,6 +70,9 @@ properties:
>           description: Input connection from the CoreSight Trace bus.
>           $ref: /schemas/graph.yaml#/properties/port
>   
> +  access-controllers:
> +    maxItems: 1
> +
>   required:
>     - compatible
>     - reg
>
Re: [PATCH v6 01/12] dt-bindings: document access-controllers property for coresight peripherals
Posted by Gatien CHEVALLIER 1 month ago

On 2/26/26 11:46, Suzuki K Poulose wrote:
> Hi
> 
> On 26/02/2026 10:30, Gatien Chevallier wrote:
>> Document the access-controllers for coresight peripherals in case some
>> access checks need to be performed to use them.
>>
>> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>> ---
>>   Documentation/devicetree/bindings/arm/arm,coresight- 
>> cti.yaml           | 3 +++
>>   .../devicetree/bindings/arm/arm,coresight-dynamic- 
>> funnel.yaml          | 3 +++
>>   Documentation/devicetree/bindings/arm/arm,coresight- 
>> etm.yaml           | 3 +++
>>   Documentation/devicetree/bindings/arm/arm,coresight- 
>> stm.yaml           | 3 +++
>>   Documentation/devicetree/bindings/arm/arm,coresight- 
>> tmc.yaml           | 3 +++
>>   Documentation/devicetree/bindings/arm/arm,coresight- 
>> tpiu.yaml          | 3 +++
> 
> Are you sure, you are not missing "replicator" in the list ?
> 
> Otherwise, looks good to me.
> 
> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> 

The replicator is not present on the Linux side on stm32mp1x platforms
(Only present for the Cortex M4 co-processor on stm32mp15x platforms).
On stm32mp2x platforms, it will be necessary so it will be added in the
related P-R because we'll need the same debug access check mechanism.

> 
> 
>>   6 files changed, 18 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight- 
>> cti.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
>> index 2a91670ccb8c..949444aba1f8 100644
>> --- a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
>> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
>> @@ -128,6 +128,9 @@ properties:
>>     "#address-cells":
>>       const: 1
>> +  access-controllers:
>> +    maxItems: 1
>> +
>>   patternProperties:
>>     '^trig-conns@([0-9]+)$':
>>       type: object
>> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight- 
>> dynamic-funnel.yaml b/Documentation/devicetree/bindings/arm/ 
>> arm,coresight-dynamic-funnel.yaml
>> index b74db15e5f8a..b0693cd46d27 100644
>> --- a/Documentation/devicetree/bindings/arm/arm,coresight-dynamic- 
>> funnel.yaml
>> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-dynamic- 
>> funnel.yaml
>> @@ -78,6 +78,9 @@ properties:
>>           description: Output connection to CoreSight Trace bus
>>           $ref: /schemas/graph.yaml#/properties/port
>> +  access-controllers:
>> +    maxItems: 1
>> +
>>   required:
>>     - compatible
>>     - reg
>> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight- 
>> etm.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml
>> index 71f2e1ed27e5..10ebbbeadf93 100644
>> --- a/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml
>> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml
>> @@ -118,6 +118,9 @@ properties:
>>           description: Output connection from the ETM to CoreSight 
>> Trace bus.
>>           $ref: /schemas/graph.yaml#/properties/port
>> +  access-controllers:
>> +    maxItems: 1
>> +
>>   required:
>>     - compatible
>>     - clocks
>> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight- 
>> stm.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml
>> index 378380c3f5aa..f243e76f597f 100644
>> --- a/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml
>> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml
>> @@ -73,6 +73,9 @@ properties:
>>           description: Output connection to the CoreSight Trace bus.
>>           $ref: /schemas/graph.yaml#/properties/port
>> +  access-controllers:
>> +    maxItems: 1
>> +
>>   required:
>>     - compatible
>>     - reg
>> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight- 
>> tmc.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
>> index 96dd5b5f771a..9dc096698c65 100644
>> --- a/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
>> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
>> @@ -128,6 +128,9 @@ properties:
>>         - const: tracedata
>>         - const: metadata
>> +  access-controllers:
>> +    maxItems: 1
>> +
>>   required:
>>     - compatible
>>     - reg
>> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight- 
>> tpiu.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml
>> index a207f6899e67..29bbc3961fdf 100644
>> --- a/Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml
>> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml
>> @@ -70,6 +70,9 @@ properties:
>>           description: Input connection from the CoreSight Trace bus.
>>           $ref: /schemas/graph.yaml#/properties/port
>> +  access-controllers:
>> +    maxItems: 1
>> +
>>   required:
>>     - compatible
>>     - reg
>>
> 

Re: [PATCH v6 01/12] dt-bindings: document access-controllers property for coresight peripherals
Posted by Suzuki K Poulose 1 month ago
On 26/02/2026 10:54, Gatien CHEVALLIER wrote:
> 
> 
> On 2/26/26 11:46, Suzuki K Poulose wrote:
>> Hi
>>
>> On 26/02/2026 10:30, Gatien Chevallier wrote:
>>> Document the access-controllers for coresight peripherals in case some
>>> access checks need to be performed to use them.
>>>
>>> Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
>>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>>> ---
>>>   Documentation/devicetree/bindings/arm/arm,coresight- 
>>> cti.yaml           | 3 +++
>>>   .../devicetree/bindings/arm/arm,coresight-dynamic- 
>>> funnel.yaml          | 3 +++
>>>   Documentation/devicetree/bindings/arm/arm,coresight- 
>>> etm.yaml           | 3 +++
>>>   Documentation/devicetree/bindings/arm/arm,coresight- 
>>> stm.yaml           | 3 +++
>>>   Documentation/devicetree/bindings/arm/arm,coresight- 
>>> tmc.yaml           | 3 +++
>>>   Documentation/devicetree/bindings/arm/arm,coresight- 
>>> tpiu.yaml          | 3 +++
>>
>> Are you sure, you are not missing "replicator" in the list ?
>>
>> Otherwise, looks good to me.
>>
>> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>>
> 
> The replicator is not present on the Linux side on stm32mp1x platforms
> (Only present for the Cortex M4 co-processor on stm32mp15x platforms).
> On stm32mp2x platforms, it will be necessary so it will be added in the
> related P-R because we'll need the same debug access check mechanism.

Fair enough. It looked a bit odd to me with TMC and TPIU both in the
list without a Replicator.

Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>


> 
>>
>>
>>>   6 files changed, 18 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight- 
>>> cti.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
>>> index 2a91670ccb8c..949444aba1f8 100644
>>> --- a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
>>> @@ -128,6 +128,9 @@ properties:
>>>     "#address-cells":
>>>       const: 1
>>> +  access-controllers:
>>> +    maxItems: 1
>>> +
>>>   patternProperties:
>>>     '^trig-conns@([0-9]+)$':
>>>       type: object
>>> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight- 
>>> dynamic-funnel.yaml b/Documentation/devicetree/bindings/arm/ 
>>> arm,coresight-dynamic-funnel.yaml
>>> index b74db15e5f8a..b0693cd46d27 100644
>>> --- a/Documentation/devicetree/bindings/arm/arm,coresight-dynamic- 
>>> funnel.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-dynamic- 
>>> funnel.yaml
>>> @@ -78,6 +78,9 @@ properties:
>>>           description: Output connection to CoreSight Trace bus
>>>           $ref: /schemas/graph.yaml#/properties/port
>>> +  access-controllers:
>>> +    maxItems: 1
>>> +
>>>   required:
>>>     - compatible
>>>     - reg
>>> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight- 
>>> etm.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml
>>> index 71f2e1ed27e5..10ebbbeadf93 100644
>>> --- a/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml
>>> @@ -118,6 +118,9 @@ properties:
>>>           description: Output connection from the ETM to CoreSight 
>>> Trace bus.
>>>           $ref: /schemas/graph.yaml#/properties/port
>>> +  access-controllers:
>>> +    maxItems: 1
>>> +
>>>   required:
>>>     - compatible
>>>     - clocks
>>> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight- 
>>> stm.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml
>>> index 378380c3f5aa..f243e76f597f 100644
>>> --- a/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml
>>> @@ -73,6 +73,9 @@ properties:
>>>           description: Output connection to the CoreSight Trace bus.
>>>           $ref: /schemas/graph.yaml#/properties/port
>>> +  access-controllers:
>>> +    maxItems: 1
>>> +
>>>   required:
>>>     - compatible
>>>     - reg
>>> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight- 
>>> tmc.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
>>> index 96dd5b5f771a..9dc096698c65 100644
>>> --- a/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
>>> @@ -128,6 +128,9 @@ properties:
>>>         - const: tracedata
>>>         - const: metadata
>>> +  access-controllers:
>>> +    maxItems: 1
>>> +
>>>   required:
>>>     - compatible
>>>     - reg
>>> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight- 
>>> tpiu.yaml b/Documentation/devicetree/bindings/arm/arm,coresight- 
>>> tpiu.yaml
>>> index a207f6899e67..29bbc3961fdf 100644
>>> --- a/Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml
>>> @@ -70,6 +70,9 @@ properties:
>>>           description: Input connection from the CoreSight Trace bus.
>>>           $ref: /schemas/graph.yaml#/properties/port
>>> +  access-controllers:
>>> +    maxItems: 1
>>> +
>>>   required:
>>>     - compatible
>>>     - reg
>>>
>>
>