[PATCHv2 4/4] ARM: dts: BCM5301X: AC5300: set WAN MAC from nvram

Rosen Penev posted 4 patches 1 month, 1 week ago
[PATCHv2 4/4] ARM: dts: BCM5301X: AC5300: set WAN MAC from nvram
Posted by Rosen Penev 1 month, 1 week ago
The WAN MAC is offset by 1. Set in dts to avoid having to handle this in
userspace.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dts b/arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dts
index 01ec8c03686a..f7da8e58b8a0 100644
--- a/arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dts
+++ b/arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dts
@@ -127,6 +127,9 @@ &srab {
 	ports {
 		port@0 {
 			label = "wan";
+
+			nvmem-cells = <&et0macaddr 1>;
+			nvmem-cell-names = "mac-address";
 		};
 
 		port@1 {
-- 
2.53.0
Re: [PATCHv2 4/4] ARM: dts: BCM5301X: AC5300: set WAN MAC from nvram
Posted by Florian Fainelli 3 weeks ago
From: Florian Fainelli <f.fainelli@gmail.com>

On Wed, 25 Feb 2026 15:08:27 -0800, Rosen Penev <rosenp@gmail.com> wrote:
> The WAN MAC is offset by 1. Set in dts to avoid having to handle this in
> userspace.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
Re: [PATCHv2 4/4] ARM: dts: BCM5301X: AC5300: set WAN MAC from nvram
Posted by Rosen Penev 3 weeks ago
On Mon, Mar 16, 2026 at 1:44 PM Florian Fainelli
<florian.fainelli@broadcom.com> wrote:
>
> From: Florian Fainelli <f.fainelli@gmail.com>
>
> On Wed, 25 Feb 2026 15:08:27 -0800, Rosen Penev <rosenp@gmail.com> wrote:
> > The WAN MAC is offset by 1. Set in dts to avoid having to handle this in
> > userspace.
> >
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > ---
>
> Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
There was a copy/paste error here. et0macaddr should be et1macaddr.
Should I resend?
> --
> Florian
Re: [PATCHv2 4/4] ARM: dts: BCM5301X: AC5300: set WAN MAC from nvram
Posted by Florian Fainelli 3 weeks ago
On 3/16/26 14:09, Rosen Penev wrote:
> On Mon, Mar 16, 2026 at 1:44 PM Florian Fainelli
> <florian.fainelli@broadcom.com> wrote:
>>
>> From: Florian Fainelli <f.fainelli@gmail.com>
>>
>> On Wed, 25 Feb 2026 15:08:27 -0800, Rosen Penev <rosenp@gmail.com> wrote:
>>> The WAN MAC is offset by 1. Set in dts to avoid having to handle this in
>>> userspace.
>>>
>>> Signed-off-by: Rosen Penev <rosenp@gmail.com>
>>> ---
>>
>> Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
> There was a copy/paste error here. et0macaddr should be et1macaddr.
> Should I resend?

Fixed it in place for 
arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dts only, right?
-- 
Florian
Re: [PATCHv2 4/4] ARM: dts: BCM5301X: AC5300: set WAN MAC from nvram
Posted by Rosen Penev 3 weeks ago
On Mon, Mar 16, 2026 at 2:11 PM Florian Fainelli
<florian.fainelli@broadcom.com> wrote:
>
> On 3/16/26 14:09, Rosen Penev wrote:
> > On Mon, Mar 16, 2026 at 1:44 PM Florian Fainelli
> > <florian.fainelli@broadcom.com> wrote:
> >>
> >> From: Florian Fainelli <f.fainelli@gmail.com>
> >>
> >> On Wed, 25 Feb 2026 15:08:27 -0800, Rosen Penev <rosenp@gmail.com> wrote:
> >>> The WAN MAC is offset by 1. Set in dts to avoid having to handle this in
> >>> userspace.
> >>>
> >>> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> >>> ---
> >>
> >> Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
> > There was a copy/paste error here. et0macaddr should be et1macaddr.
> > Should I resend?
>
> Fixed it in place for
> arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dts only, right?
I believe so, yes.
> --
> Florian
Re: [PATCHv2 4/4] ARM: dts: BCM5301X: AC5300: set WAN MAC from nvram
Posted by kernel test robot 1 month, 1 week ago
Hi Rosen,

kernel test robot noticed the following build errors:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v7.0-rc1 next-20260225]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Rosen-Penev/ARM-dts-BCM5301X-EA9200-set-WAN-MAC-from-nvram/20260226-071232
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20260225230827.21715-5-rosenp%40gmail.com
patch subject: [PATCHv2 4/4] ARM: dts: BCM5301X: AC5300: set WAN MAC from nvram
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20260226/202602261850.DL7ZVo3w-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260226/202602261850.DL7ZVo3w-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602261850.DL7ZVo3w-lkp@intel.com/

All errors (new ones prefixed by >>):

   also defined at arch/arm/boot/dts/broadcom/bcm47094-asus-rt-ac5300.dts:128.10-133.5
>> ERROR: Input tree has errors, aborting (use -f to force output)

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki