Remove unused pagevec.h includes from .c files. These were found with
the following command:
grep -rl '#include.*pagevec\.h' --include='*.c' | while read f; do
grep -qE 'PAGEVEC_SIZE|folio_batch' "$f" || echo "$f"
done
There are probably more removal candidates in .h files, but those are
more complex to analyze.
Signed-off-by: Tal Zussman <tz2294@columbia.edu>
---
fs/afs/write.c | 1 -
fs/dax.c | 1 -
fs/ext4/file.c | 1 -
fs/ext4/page-io.c | 1 -
fs/ext4/readpage.c | 1 -
fs/f2fs/file.c | 1 -
fs/mpage.c | 1 -
fs/netfs/buffered_write.c | 1 -
fs/nfs/blocklayout/blocklayout.c | 1 -
fs/nfs/dir.c | 1 -
fs/ocfs2/refcounttree.c | 1 -
fs/smb/client/connect.c | 1 -
fs/smb/client/file.c | 1 -
13 files changed, 13 deletions(-)
diff --git a/fs/afs/write.c b/fs/afs/write.c
index 93ad86ff3345..fcfed9d24e0a 100644
--- a/fs/afs/write.c
+++ b/fs/afs/write.c
@@ -10,7 +10,6 @@
#include <linux/fs.h>
#include <linux/pagemap.h>
#include <linux/writeback.h>
-#include <linux/pagevec.h>
#include <linux/netfs.h>
#include <trace/events/netfs.h>
#include "internal.h"
diff --git a/fs/dax.c b/fs/dax.c
index b78cff9c91b3..a5237169b467 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -15,7 +15,6 @@
#include <linux/memcontrol.h>
#include <linux/mm.h>
#include <linux/mutex.h>
-#include <linux/pagevec.h>
#include <linux/sched.h>
#include <linux/sched/signal.h>
#include <linux/uio.h>
diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index f1dc5ce791a7..5e02f6cf653e 100644
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
@@ -27,7 +27,6 @@
#include <linux/dax.h>
#include <linux/filelock.h>
#include <linux/quotaops.h>
-#include <linux/pagevec.h>
#include <linux/uio.h>
#include <linux/mman.h>
#include <linux/backing-dev.h>
diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c
index a8c95eee91b7..98da200d11c8 100644
--- a/fs/ext4/page-io.c
+++ b/fs/ext4/page-io.c
@@ -16,7 +16,6 @@
#include <linux/string.h>
#include <linux/buffer_head.h>
#include <linux/writeback.h>
-#include <linux/pagevec.h>
#include <linux/mpage.h>
#include <linux/namei.h>
#include <linux/uio.h>
diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c
index 830f3b8a321f..3c7aabde719c 100644
--- a/fs/ext4/readpage.c
+++ b/fs/ext4/readpage.c
@@ -43,7 +43,6 @@
#include <linux/mpage.h>
#include <linux/writeback.h>
#include <linux/backing-dev.h>
-#include <linux/pagevec.h>
#include "ext4.h"
#include <trace/events/ext4.h>
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index c8a2f17a8f11..c6b6a1465d08 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -17,7 +17,6 @@
#include <linux/compat.h>
#include <linux/uaccess.h>
#include <linux/mount.h>
-#include <linux/pagevec.h>
#include <linux/uio.h>
#include <linux/uuid.h>
#include <linux/file.h>
diff --git a/fs/mpage.c b/fs/mpage.c
index 7dae5afc2b9e..e5285fbfcf09 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -28,7 +28,6 @@
#include <linux/mm_inline.h>
#include <linux/writeback.h>
#include <linux/backing-dev.h>
-#include <linux/pagevec.h>
#include "internal.h"
/*
diff --git a/fs/netfs/buffered_write.c b/fs/netfs/buffered_write.c
index 22a4d61631c9..05ea5b0cc0e8 100644
--- a/fs/netfs/buffered_write.c
+++ b/fs/netfs/buffered_write.c
@@ -10,7 +10,6 @@
#include <linux/mm.h>
#include <linux/pagemap.h>
#include <linux/slab.h>
-#include <linux/pagevec.h>
#include "internal.h"
static void __netfs_set_group(struct folio *folio, struct netfs_group *netfs_group)
diff --git a/fs/nfs/blocklayout/blocklayout.c b/fs/nfs/blocklayout/blocklayout.c
index cb0a645aeb50..11f9f69cde61 100644
--- a/fs/nfs/blocklayout/blocklayout.c
+++ b/fs/nfs/blocklayout/blocklayout.c
@@ -36,7 +36,6 @@
#include <linux/namei.h>
#include <linux/bio.h> /* struct bio */
#include <linux/prefetch.h>
-#include <linux/pagevec.h>
#include "../pnfs.h"
#include "../nfs4session.h"
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 2402f57c8e7d..0d276441206b 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -32,7 +32,6 @@
#include <linux/nfs_fs.h>
#include <linux/nfs_mount.h>
#include <linux/pagemap.h>
-#include <linux/pagevec.h>
#include <linux/namei.h>
#include <linux/mount.h>
#include <linux/swap.h>
diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c
index c1cdececdfa4..b4acd081bbc4 100644
--- a/fs/ocfs2/refcounttree.c
+++ b/fs/ocfs2/refcounttree.c
@@ -31,7 +31,6 @@
#include <linux/blkdev.h>
#include <linux/slab.h>
#include <linux/writeback.h>
-#include <linux/pagevec.h>
#include <linux/swap.h>
#include <linux/security.h>
#include <linux/string.h>
diff --git a/fs/smb/client/connect.c b/fs/smb/client/connect.c
index 33dfe116ca52..9e57812b7b95 100644
--- a/fs/smb/client/connect.c
+++ b/fs/smb/client/connect.c
@@ -20,7 +20,6 @@
#include <linux/delay.h>
#include <linux/completion.h>
#include <linux/kthread.h>
-#include <linux/pagevec.h>
#include <linux/freezer.h>
#include <linux/namei.h>
#include <linux/uuid.h>
diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c
index 18f31d4eb98d..853ce1817810 100644
--- a/fs/smb/client/file.c
+++ b/fs/smb/client/file.c
@@ -15,7 +15,6 @@
#include <linux/stat.h>
#include <linux/fcntl.h>
#include <linux/pagemap.h>
-#include <linux/pagevec.h>
#include <linux/writeback.h>
#include <linux/task_io_accounting_ops.h>
#include <linux/delay.h>
--
2.39.5On Wed, Feb 25, 2026 at 06:44:26PM -0500, Tal Zussman wrote: > Remove unused pagevec.h includes from .c files. These were found with > the following command: > > grep -rl '#include.*pagevec\.h' --include='*.c' | while read f; do > grep -qE 'PAGEVEC_SIZE|folio_batch' "$f" || echo "$f" > done > > There are probably more removal candidates in .h files, but those are > more complex to analyze. > > Signed-off-by: Tal Zussman <tz2294@columbia.edu> Nice, LGTM so: Reviewed-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org> > --- > fs/afs/write.c | 1 - > fs/dax.c | 1 - > fs/ext4/file.c | 1 - > fs/ext4/page-io.c | 1 - > fs/ext4/readpage.c | 1 - > fs/f2fs/file.c | 1 - > fs/mpage.c | 1 - > fs/netfs/buffered_write.c | 1 - > fs/nfs/blocklayout/blocklayout.c | 1 - > fs/nfs/dir.c | 1 - > fs/ocfs2/refcounttree.c | 1 - > fs/smb/client/connect.c | 1 - > fs/smb/client/file.c | 1 - > 13 files changed, 13 deletions(-) > > diff --git a/fs/afs/write.c b/fs/afs/write.c > index 93ad86ff3345..fcfed9d24e0a 100644 > --- a/fs/afs/write.c > +++ b/fs/afs/write.c > @@ -10,7 +10,6 @@ > #include <linux/fs.h> > #include <linux/pagemap.h> > #include <linux/writeback.h> > -#include <linux/pagevec.h> > #include <linux/netfs.h> > #include <trace/events/netfs.h> > #include "internal.h" > diff --git a/fs/dax.c b/fs/dax.c > index b78cff9c91b3..a5237169b467 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -15,7 +15,6 @@ > #include <linux/memcontrol.h> > #include <linux/mm.h> > #include <linux/mutex.h> > -#include <linux/pagevec.h> > #include <linux/sched.h> > #include <linux/sched/signal.h> > #include <linux/uio.h> > diff --git a/fs/ext4/file.c b/fs/ext4/file.c > index f1dc5ce791a7..5e02f6cf653e 100644 > --- a/fs/ext4/file.c > +++ b/fs/ext4/file.c > @@ -27,7 +27,6 @@ > #include <linux/dax.h> > #include <linux/filelock.h> > #include <linux/quotaops.h> > -#include <linux/pagevec.h> > #include <linux/uio.h> > #include <linux/mman.h> > #include <linux/backing-dev.h> > diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c > index a8c95eee91b7..98da200d11c8 100644 > --- a/fs/ext4/page-io.c > +++ b/fs/ext4/page-io.c > @@ -16,7 +16,6 @@ > #include <linux/string.h> > #include <linux/buffer_head.h> > #include <linux/writeback.h> > -#include <linux/pagevec.h> > #include <linux/mpage.h> > #include <linux/namei.h> > #include <linux/uio.h> > diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c > index 830f3b8a321f..3c7aabde719c 100644 > --- a/fs/ext4/readpage.c > +++ b/fs/ext4/readpage.c > @@ -43,7 +43,6 @@ > #include <linux/mpage.h> > #include <linux/writeback.h> > #include <linux/backing-dev.h> > -#include <linux/pagevec.h> > > #include "ext4.h" > #include <trace/events/ext4.h> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index c8a2f17a8f11..c6b6a1465d08 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -17,7 +17,6 @@ > #include <linux/compat.h> > #include <linux/uaccess.h> > #include <linux/mount.h> > -#include <linux/pagevec.h> > #include <linux/uio.h> > #include <linux/uuid.h> > #include <linux/file.h> > diff --git a/fs/mpage.c b/fs/mpage.c > index 7dae5afc2b9e..e5285fbfcf09 100644 > --- a/fs/mpage.c > +++ b/fs/mpage.c > @@ -28,7 +28,6 @@ > #include <linux/mm_inline.h> > #include <linux/writeback.h> > #include <linux/backing-dev.h> > -#include <linux/pagevec.h> > #include "internal.h" > > /* > diff --git a/fs/netfs/buffered_write.c b/fs/netfs/buffered_write.c > index 22a4d61631c9..05ea5b0cc0e8 100644 > --- a/fs/netfs/buffered_write.c > +++ b/fs/netfs/buffered_write.c > @@ -10,7 +10,6 @@ > #include <linux/mm.h> > #include <linux/pagemap.h> > #include <linux/slab.h> > -#include <linux/pagevec.h> > #include "internal.h" > > static void __netfs_set_group(struct folio *folio, struct netfs_group *netfs_group) > diff --git a/fs/nfs/blocklayout/blocklayout.c b/fs/nfs/blocklayout/blocklayout.c > index cb0a645aeb50..11f9f69cde61 100644 > --- a/fs/nfs/blocklayout/blocklayout.c > +++ b/fs/nfs/blocklayout/blocklayout.c > @@ -36,7 +36,6 @@ > #include <linux/namei.h> > #include <linux/bio.h> /* struct bio */ > #include <linux/prefetch.h> > -#include <linux/pagevec.h> > > #include "../pnfs.h" > #include "../nfs4session.h" > diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c > index 2402f57c8e7d..0d276441206b 100644 > --- a/fs/nfs/dir.c > +++ b/fs/nfs/dir.c > @@ -32,7 +32,6 @@ > #include <linux/nfs_fs.h> > #include <linux/nfs_mount.h> > #include <linux/pagemap.h> > -#include <linux/pagevec.h> > #include <linux/namei.h> > #include <linux/mount.h> > #include <linux/swap.h> > diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c > index c1cdececdfa4..b4acd081bbc4 100644 > --- a/fs/ocfs2/refcounttree.c > +++ b/fs/ocfs2/refcounttree.c > @@ -31,7 +31,6 @@ > #include <linux/blkdev.h> > #include <linux/slab.h> > #include <linux/writeback.h> > -#include <linux/pagevec.h> > #include <linux/swap.h> > #include <linux/security.h> > #include <linux/string.h> > diff --git a/fs/smb/client/connect.c b/fs/smb/client/connect.c > index 33dfe116ca52..9e57812b7b95 100644 > --- a/fs/smb/client/connect.c > +++ b/fs/smb/client/connect.c > @@ -20,7 +20,6 @@ > #include <linux/delay.h> > #include <linux/completion.h> > #include <linux/kthread.h> > -#include <linux/pagevec.h> > #include <linux/freezer.h> > #include <linux/namei.h> > #include <linux/uuid.h> > diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c > index 18f31d4eb98d..853ce1817810 100644 > --- a/fs/smb/client/file.c > +++ b/fs/smb/client/file.c > @@ -15,7 +15,6 @@ > #include <linux/stat.h> > #include <linux/fcntl.h> > #include <linux/pagemap.h> > -#include <linux/pagevec.h> > #include <linux/writeback.h> > #include <linux/task_io_accounting_ops.h> > #include <linux/delay.h> > > -- > 2.39.5 >
On Wed, Feb 25, 2026 at 3:44 PM Tal Zussman <tz2294@columbia.edu> wrote: > > Remove unused pagevec.h includes from .c files. These were found with > the following command: > > grep -rl '#include.*pagevec\.h' --include='*.c' | while read f; do > grep -qE 'PAGEVEC_SIZE|folio_batch' "$f" || echo "$f" > done > > There are probably more removal candidates in .h files, but those are > more complex to analyze. > > Signed-off-by: Tal Zussman <tz2294@columbia.edu> Acked-by: Chris Li <chrisl@kernel.org> Chris
On 25 Feb 2026, at 18:44, Tal Zussman wrote: > Remove unused pagevec.h includes from .c files. These were found with > the following command: > > grep -rl '#include.*pagevec\.h' --include='*.c' | while read f; do > grep -qE 'PAGEVEC_SIZE|folio_batch' "$f" || echo "$f" > done > > There are probably more removal candidates in .h files, but those are > more complex to analyze. > > Signed-off-by: Tal Zussman <tz2294@columbia.edu> > --- > fs/afs/write.c | 1 - > fs/dax.c | 1 - > fs/ext4/file.c | 1 - > fs/ext4/page-io.c | 1 - > fs/ext4/readpage.c | 1 - > fs/f2fs/file.c | 1 - > fs/mpage.c | 1 - > fs/netfs/buffered_write.c | 1 - > fs/nfs/blocklayout/blocklayout.c | 1 - > fs/nfs/dir.c | 1 - > fs/ocfs2/refcounttree.c | 1 - > fs/smb/client/connect.c | 1 - > fs/smb/client/file.c | 1 - > 13 files changed, 13 deletions(-) > Acked-by: Zi Yan <ziy@nvidia.com> Best Regards, Yan, Zi
On Wed 25-02-26 18:44:26, Tal Zussman wrote: > Remove unused pagevec.h includes from .c files. These were found with > the following command: > > grep -rl '#include.*pagevec\.h' --include='*.c' | while read f; do > grep -qE 'PAGEVEC_SIZE|folio_batch' "$f" || echo "$f" > done > > There are probably more removal candidates in .h files, but those are > more complex to analyze. > > Signed-off-by: Tal Zussman <tz2294@columbia.edu> If it compiles than it's nice to get rid of. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/afs/write.c | 1 - > fs/dax.c | 1 - > fs/ext4/file.c | 1 - > fs/ext4/page-io.c | 1 - > fs/ext4/readpage.c | 1 - > fs/f2fs/file.c | 1 - > fs/mpage.c | 1 - > fs/netfs/buffered_write.c | 1 - > fs/nfs/blocklayout/blocklayout.c | 1 - > fs/nfs/dir.c | 1 - > fs/ocfs2/refcounttree.c | 1 - > fs/smb/client/connect.c | 1 - > fs/smb/client/file.c | 1 - > 13 files changed, 13 deletions(-) > > diff --git a/fs/afs/write.c b/fs/afs/write.c > index 93ad86ff3345..fcfed9d24e0a 100644 > --- a/fs/afs/write.c > +++ b/fs/afs/write.c > @@ -10,7 +10,6 @@ > #include <linux/fs.h> > #include <linux/pagemap.h> > #include <linux/writeback.h> > -#include <linux/pagevec.h> > #include <linux/netfs.h> > #include <trace/events/netfs.h> > #include "internal.h" > diff --git a/fs/dax.c b/fs/dax.c > index b78cff9c91b3..a5237169b467 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -15,7 +15,6 @@ > #include <linux/memcontrol.h> > #include <linux/mm.h> > #include <linux/mutex.h> > -#include <linux/pagevec.h> > #include <linux/sched.h> > #include <linux/sched/signal.h> > #include <linux/uio.h> > diff --git a/fs/ext4/file.c b/fs/ext4/file.c > index f1dc5ce791a7..5e02f6cf653e 100644 > --- a/fs/ext4/file.c > +++ b/fs/ext4/file.c > @@ -27,7 +27,6 @@ > #include <linux/dax.h> > #include <linux/filelock.h> > #include <linux/quotaops.h> > -#include <linux/pagevec.h> > #include <linux/uio.h> > #include <linux/mman.h> > #include <linux/backing-dev.h> > diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c > index a8c95eee91b7..98da200d11c8 100644 > --- a/fs/ext4/page-io.c > +++ b/fs/ext4/page-io.c > @@ -16,7 +16,6 @@ > #include <linux/string.h> > #include <linux/buffer_head.h> > #include <linux/writeback.h> > -#include <linux/pagevec.h> > #include <linux/mpage.h> > #include <linux/namei.h> > #include <linux/uio.h> > diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c > index 830f3b8a321f..3c7aabde719c 100644 > --- a/fs/ext4/readpage.c > +++ b/fs/ext4/readpage.c > @@ -43,7 +43,6 @@ > #include <linux/mpage.h> > #include <linux/writeback.h> > #include <linux/backing-dev.h> > -#include <linux/pagevec.h> > > #include "ext4.h" > #include <trace/events/ext4.h> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index c8a2f17a8f11..c6b6a1465d08 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -17,7 +17,6 @@ > #include <linux/compat.h> > #include <linux/uaccess.h> > #include <linux/mount.h> > -#include <linux/pagevec.h> > #include <linux/uio.h> > #include <linux/uuid.h> > #include <linux/file.h> > diff --git a/fs/mpage.c b/fs/mpage.c > index 7dae5afc2b9e..e5285fbfcf09 100644 > --- a/fs/mpage.c > +++ b/fs/mpage.c > @@ -28,7 +28,6 @@ > #include <linux/mm_inline.h> > #include <linux/writeback.h> > #include <linux/backing-dev.h> > -#include <linux/pagevec.h> > #include "internal.h" > > /* > diff --git a/fs/netfs/buffered_write.c b/fs/netfs/buffered_write.c > index 22a4d61631c9..05ea5b0cc0e8 100644 > --- a/fs/netfs/buffered_write.c > +++ b/fs/netfs/buffered_write.c > @@ -10,7 +10,6 @@ > #include <linux/mm.h> > #include <linux/pagemap.h> > #include <linux/slab.h> > -#include <linux/pagevec.h> > #include "internal.h" > > static void __netfs_set_group(struct folio *folio, struct netfs_group *netfs_group) > diff --git a/fs/nfs/blocklayout/blocklayout.c b/fs/nfs/blocklayout/blocklayout.c > index cb0a645aeb50..11f9f69cde61 100644 > --- a/fs/nfs/blocklayout/blocklayout.c > +++ b/fs/nfs/blocklayout/blocklayout.c > @@ -36,7 +36,6 @@ > #include <linux/namei.h> > #include <linux/bio.h> /* struct bio */ > #include <linux/prefetch.h> > -#include <linux/pagevec.h> > > #include "../pnfs.h" > #include "../nfs4session.h" > diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c > index 2402f57c8e7d..0d276441206b 100644 > --- a/fs/nfs/dir.c > +++ b/fs/nfs/dir.c > @@ -32,7 +32,6 @@ > #include <linux/nfs_fs.h> > #include <linux/nfs_mount.h> > #include <linux/pagemap.h> > -#include <linux/pagevec.h> > #include <linux/namei.h> > #include <linux/mount.h> > #include <linux/swap.h> > diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c > index c1cdececdfa4..b4acd081bbc4 100644 > --- a/fs/ocfs2/refcounttree.c > +++ b/fs/ocfs2/refcounttree.c > @@ -31,7 +31,6 @@ > #include <linux/blkdev.h> > #include <linux/slab.h> > #include <linux/writeback.h> > -#include <linux/pagevec.h> > #include <linux/swap.h> > #include <linux/security.h> > #include <linux/string.h> > diff --git a/fs/smb/client/connect.c b/fs/smb/client/connect.c > index 33dfe116ca52..9e57812b7b95 100644 > --- a/fs/smb/client/connect.c > +++ b/fs/smb/client/connect.c > @@ -20,7 +20,6 @@ > #include <linux/delay.h> > #include <linux/completion.h> > #include <linux/kthread.h> > -#include <linux/pagevec.h> > #include <linux/freezer.h> > #include <linux/namei.h> > #include <linux/uuid.h> > diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c > index 18f31d4eb98d..853ce1817810 100644 > --- a/fs/smb/client/file.c > +++ b/fs/smb/client/file.c > @@ -15,7 +15,6 @@ > #include <linux/stat.h> > #include <linux/fcntl.h> > #include <linux/pagemap.h> > -#include <linux/pagevec.h> > #include <linux/writeback.h> > #include <linux/task_io_accounting_ops.h> > #include <linux/delay.h> > > -- > 2.39.5 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
© 2016 - 2026 Red Hat, Inc.