[v6] Adding brcmstb-hwspinlock support

[PATCH v6 0/3] Adding brcmstb-hwspinlock support

Posted by Kamal Dasu 1 month, 1 week ago

This is a standalone patch for the hardware semaphore feature for
all brcmstb SoCs that have the same hardware semaphore registers.

The semaphore registers belong to the sundry hardware block. The
node describes only the semaphore register range carved out of the
larger sundry block address space.

The compatible string uses "brcm,bcm7038-sun-top-ctrl-semaphore"
based on the BCM7038 SoC where the semaphore registers were first
introduced in settop chips.

The patch has been tested to work as builtin as well as a module.

v6 changes:
Addressed review comments from Krzysztof Kozlowski:
 - Renamed DT binding YAML file from "brcm,brcmstb-hwspinlock.yaml"
   to "brcm,bcm7038-sun-top-ctrl-semaphore.yaml" to match the
   compatible string
 - Updated $id in the YAML to match the new filename
 - Updated MAINTAINERS F: entry to match the new filename

v5 changes:
Addressed review comments from Krzysztof Kozlowski:
 - Changed compatible to "brcm,bcm7038-sun-top-ctrl-semaphore"
   using the SoC where the semaphore hardware was first introduced,
   following the brcm,bcm7038-l1-intc convention

v4 changes:
Addressed review comments from Krzysztof Kozlowski and Rob Herring:
 - Renamed compatible from "brcm,brcmstb-hwspinlock" to
   "brcm,brcmstb-sun-top-ctrl-semaphore" to use the hardware name
 - Added description block to the DT binding YAML explaining what
   the semaphore registers are and their relationship to the sundry
   block
 - Fixed typo in Kconfig "Setttop" -> "Settop"
 - Fixed email typo in MODULE_AUTHOR

v3 changes:
Added detailed explanation in the all commit messages as per review
comments
 - Added description of 'sundry' ip block that the hardware semaphore
   belongs to
 - Added reasoning for using common compatible string

v2 changes:
Addressed following review comments:
 - fixed ordering of obj brcmstb_hwspinlock.o in Makefile
 - fixed ordering of 'config HWSPINLOCK_BRCMSTB' block in Kconfig
 - Renamed BRCMSTB_MAX_SEMAPHORES to BRCMSTB_NUM_SEMAPHORES
 - Removed unnecessary platform_set_drvdata(pdev, bank);

Also addressing duplicate PATCH 1/3 sent in error as part of v1 change.

v1 changes:
based on fixes made to Initial patch:
Link: https://github.com/intel-lab-lkp/linux/commits/
  Kamal-Dasu/dt-bindings-brcmstb-hwspinlock-support-
  for-hwspinlock/20250712-034624
Link: https://lore.kernel.org/r/20250711154221.928164-
  4-kamal.dasu%40broadcom.com
  [PATCH 2/4] hwspinlock: brcmstb hardware semaphore support

All the review comments and build warning have been fixed.

Kamal Dasu (3):
  dt-bindings: hwlock: Adding brcmstb-hwspinlock support
  hwspinlock: brcmstb hardware semaphore support
  MAINTAINERS: adding entry for BRCMSTB HWSPINLOCK driver

 .../brcm,bcm7038-sun-top-ctrl-semaphore.yaml  | 45 +++++++++
 MAINTAINERS                                   |  8 ++
 drivers/hwspinlock/Kconfig                    | 11 ++-
 drivers/hwspinlock/Makefile                   |  1 +
 drivers/hwspinlock/brcmstb_hwspinlock.c       | 96 +++++++++++++++++++
 5 files changed, 160 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/hwlock/brcm,bcm7038-sun-top-ctrl-semaphore.yaml
 create mode 100644 drivers/hwspinlock/brcmstb_hwspinlock.c

-- 
2.34.1

Re: [PATCH v6 0/3] Adding brcmstb-hwspinlock support

Posted by Kamal Dasu 4 weeks ago

On Tue, Feb 24, 2026 at 5:04 PM Kamal Dasu <kamal.dasu@broadcom.com> wrote:
>
> This is a standalone patch for the hardware semaphore feature for
> all brcmstb SoCs that have the same hardware semaphore registers.
>
> The semaphore registers belong to the sundry hardware block. The
> node describes only the semaphore register range carved out of the
> larger sundry block address space.
>
> The compatible string uses "brcm,bcm7038-sun-top-ctrl-semaphore"
> based on the BCM7038 SoC where the semaphore registers were first
> introduced in settop chips.
>
> The patch has been tested to work as builtin as well as a module.
>
> v6 changes:
> Addressed review comments from Krzysztof Kozlowski:
>  - Renamed DT binding YAML file from "brcm,brcmstb-hwspinlock.yaml"
>    to "brcm,bcm7038-sun-top-ctrl-semaphore.yaml" to match the
>    compatible string
>  - Updated $id in the YAML to match the new filename
>  - Updated MAINTAINERS F: entry to match the new filename
>
> v5 changes:
> Addressed review comments from Krzysztof Kozlowski:
>  - Changed compatible to "brcm,bcm7038-sun-top-ctrl-semaphore"
>    using the SoC where the semaphore hardware was first introduced,
>    following the brcm,bcm7038-l1-intc convention
>
> v4 changes:
> Addressed review comments from Krzysztof Kozlowski and Rob Herring:
>  - Renamed compatible from "brcm,brcmstb-hwspinlock" to
>    "brcm,brcmstb-sun-top-ctrl-semaphore" to use the hardware name
>  - Added description block to the DT binding YAML explaining what
>    the semaphore registers are and their relationship to the sundry
>    block
>  - Fixed typo in Kconfig "Setttop" -> "Settop"
>  - Fixed email typo in MODULE_AUTHOR
>
> v3 changes:
> Added detailed explanation in the all commit messages as per review
> comments
>  - Added description of 'sundry' ip block that the hardware semaphore
>    belongs to
>  - Added reasoning for using common compatible string
>
> v2 changes:
> Addressed following review comments:
>  - fixed ordering of obj brcmstb_hwspinlock.o in Makefile
>  - fixed ordering of 'config HWSPINLOCK_BRCMSTB' block in Kconfig
>  - Renamed BRCMSTB_MAX_SEMAPHORES to BRCMSTB_NUM_SEMAPHORES
>  - Removed unnecessary platform_set_drvdata(pdev, bank);
>
> Also addressing duplicate PATCH 1/3 sent in error as part of v1 change.
>
> v1 changes:
> based on fixes made to Initial patch:
> Link: https://github.com/intel-lab-lkp/linux/commits/
>   Kamal-Dasu/dt-bindings-brcmstb-hwspinlock-support-
>   for-hwspinlock/20250712-034624
> Link: https://lore.kernel.org/r/20250711154221.928164-
>   4-kamal.dasu%40broadcom.com
>   [PATCH 2/4] hwspinlock: brcmstb hardware semaphore support
>
> All the review comments and build warning have been fixed.
>
> Kamal Dasu (3):
>   dt-bindings: hwlock: Adding brcmstb-hwspinlock support
>   hwspinlock: brcmstb hardware semaphore support
>   MAINTAINERS: adding entry for BRCMSTB HWSPINLOCK driver
>
>  .../brcm,bcm7038-sun-top-ctrl-semaphore.yaml  | 45 +++++++++
>  MAINTAINERS                                   |  8 ++
>  drivers/hwspinlock/Kconfig                    | 11 ++-
>  drivers/hwspinlock/Makefile                   |  1 +
>  drivers/hwspinlock/brcmstb_hwspinlock.c       | 96 +++++++++++++++++++
>  5 files changed, 160 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/hwlock/brcm,bcm7038-sun-top-ctrl-semaphore.yaml
>  create mode 100644 drivers/hwspinlock/brcmstb_hwspinlock.c
>
> --
> 2.34.1
>

Hi Baolin, Rob,

Gentle ping on this series. Patch 1/3 (dt-bindings) has been reviewed
by Krzysztof and all previous review comments have been addressed.

[PATCH v6 2/3]  hwspinlock: brcmstb hardware semaphore support
[PATCH v6 3/3] MAINTAINERS: adding entry for BRCMSTB HWSPINLOCK driver

Haven't received any feedback yet. Could you please take a look when
you get a chance?

Link: https://lore.kernel.org/linux-remoteproc/20260224220407.2351692-1-kamal.dasu@broadcom.com/


Thanks,
Kamal

Re: [PATCH v6 0/3] Adding brcmstb-hwspinlock support

Posted by Krzysztof Kozlowski 4 weeks ago

On 05/03/2026 20:17, Kamal Dasu wrote:
>>
>>  .../brcm,bcm7038-sun-top-ctrl-semaphore.yaml  | 45 +++++++++
>>  MAINTAINERS                                   |  8 ++
>>  drivers/hwspinlock/Kconfig                    | 11 ++-
>>  drivers/hwspinlock/Makefile                   |  1 +
>>  drivers/hwspinlock/brcmstb_hwspinlock.c       | 96 +++++++++++++++++++
>>  5 files changed, 160 insertions(+), 1 deletion(-)
>>  create mode 100644 Documentation/devicetree/bindings/hwlock/brcm,bcm7038-sun-top-ctrl-semaphore.yaml
>>  create mode 100644 drivers/hwspinlock/brcmstb_hwspinlock.c
>>
>> --
>> 2.34.1
>>
> 
> Hi Baolin, Rob,
> 
> Gentle ping on this series. Patch 1/3 (dt-bindings) has been reviewed
> by Krzysztof and all previous review comments have been addressed.

Why pinging Rob? You got DT review. Or one review is not enough and you
need multiple maintainers engaged?

Best regards,
Krzysztof

Re: [PATCH v6 0/3] Adding brcmstb-hwspinlock support

Posted by Kamal Dasu 4 weeks ago

On Thu, Mar 5, 2026 at 2:59 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 05/03/2026 20:17, Kamal Dasu wrote:
> >>
> >>  .../brcm,bcm7038-sun-top-ctrl-semaphore.yaml  | 45 +++++++++
> >>  MAINTAINERS                                   |  8 ++
> >>  drivers/hwspinlock/Kconfig                    | 11 ++-
> >>  drivers/hwspinlock/Makefile                   |  1 +
> >>  drivers/hwspinlock/brcmstb_hwspinlock.c       | 96 +++++++++++++++++++
> >>  5 files changed, 160 insertions(+), 1 deletion(-)
> >>  create mode 100644 Documentation/devicetree/bindings/hwlock/brcm,bcm7038-sun-top-ctrl-semaphore.yaml
> >>  create mode 100644 drivers/hwspinlock/brcmstb_hwspinlock.c
> >>
> >> --
> >> 2.34.1
> >>
> >
> > Hi Baolin, Rob,
> >
> > Gentle ping on this series. Patch 1/3 (dt-bindings) has been reviewed
> > by Krzysztof and all previous review comments have been addressed.
>
> Why pinging Rob? You got DT review. Or one review is not enough and you
> need multiple maintainers engaged?
>

I am good with the DT review. Rob commented on previous patches so I
added him. I just need the hwspinlock maintainer to review the other
two patches.

> Best regards,
> Krzysztof

Thanks,
Kamal