[PATCH 7.1] ublk: report BLK_SPLIT_INTERVAL_CAPABLE

Caleb Sander Mateos posted 1 patch 1 month, 3 weeks ago
drivers/block/ublk_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH 7.1] ublk: report BLK_SPLIT_INTERVAL_CAPABLE
Posted by Caleb Sander Mateos 1 month, 3 weeks ago
The ublk driver doesn't access request integrity buffers directly, it
only copies them to/from the ublk server in ublk_copy_user_integrity().
ublk_copy_user_integrity() uses bio_for_each_integrity_vec() to walk all
the integrity segments. ublk devices are therefore capable of handling
requests with integrity intervals split across segments. Set
BLK_SPLIT_INTERVAL_CAPABLE in the struct blk_integrity flags for ublk
devices to opt out of the integrity-interval dma_alignment limit.

Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
---
 drivers/block/ublk_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
index 004f367243b6..34ed4f6a02ef 100644
--- a/drivers/block/ublk_drv.c
+++ b/drivers/block/ublk_drv.c
@@ -806,11 +806,11 @@ static void ublk_dev_param_basic_apply(struct ublk_device *ub)
 	set_capacity(ub->ub_disk, p->dev_sectors);
 }
 
 static int ublk_integrity_flags(u32 flags)
 {
-	int ret_flags = 0;
+	int ret_flags = BLK_SPLIT_INTERVAL_CAPABLE;
 
 	if (flags & LBMD_PI_CAP_INTEGRITY) {
 		flags &= ~LBMD_PI_CAP_INTEGRITY;
 		ret_flags |= BLK_INTEGRITY_DEVICE_CAPABLE;
 	}
-- 
2.45.2
Re: [PATCH 7.1] ublk: report BLK_SPLIT_INTERVAL_CAPABLE
Posted by Jens Axboe 1 month, 2 weeks ago
On Tue, 24 Feb 2026 08:57:22 -0700, Caleb Sander Mateos wrote:
> The ublk driver doesn't access request integrity buffers directly, it
> only copies them to/from the ublk server in ublk_copy_user_integrity().
> ublk_copy_user_integrity() uses bio_for_each_integrity_vec() to walk all
> the integrity segments. ublk devices are therefore capable of handling
> requests with integrity intervals split across segments. Set
> BLK_SPLIT_INTERVAL_CAPABLE in the struct blk_integrity flags for ublk
> devices to opt out of the integrity-interval dma_alignment limit.
> 
> [...]

Applied, thanks!

[1/1] ublk: report BLK_SPLIT_INTERVAL_CAPABLE
      commit: c1dfbd7e71b0a75374a4e65c9d4c6eb66a31e6fc

Best regards,
-- 
Jens Axboe
Re: [PATCH 7.1] ublk: report BLK_SPLIT_INTERVAL_CAPABLE
Posted by Ming Lei 1 month, 2 weeks ago
On Tue, Feb 24, 2026 at 08:57:22AM -0700, Caleb Sander Mateos wrote:
> The ublk driver doesn't access request integrity buffers directly, it
> only copies them to/from the ublk server in ublk_copy_user_integrity().
> ublk_copy_user_integrity() uses bio_for_each_integrity_vec() to walk all
> the integrity segments. ublk devices are therefore capable of handling
> requests with integrity intervals split across segments. Set
> BLK_SPLIT_INTERVAL_CAPABLE in the struct blk_integrity flags for ublk
> devices to opt out of the integrity-interval dma_alignment limit.
> 
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
> ---
>  drivers/block/ublk_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
> index 004f367243b6..34ed4f6a02ef 100644
> --- a/drivers/block/ublk_drv.c
> +++ b/drivers/block/ublk_drv.c
> @@ -806,11 +806,11 @@ static void ublk_dev_param_basic_apply(struct ublk_device *ub)
>  	set_capacity(ub->ub_disk, p->dev_sectors);
>  }
>  
>  static int ublk_integrity_flags(u32 flags)
>  {
> -	int ret_flags = 0;
> +	int ret_flags = BLK_SPLIT_INTERVAL_CAPABLE;
>  
>  	if (flags & LBMD_PI_CAP_INTEGRITY) {
>  		flags &= ~LBMD_PI_CAP_INTEGRITY;
>  		ret_flags |= BLK_INTEGRITY_DEVICE_CAPABLE;

Reviewed-by: Ming Lei <ming.lei@redhat.com>

Thanks, 
Ming
Re: [PATCH 7.1] ublk: report BLK_SPLIT_INTERVAL_CAPABLE
Posted by Martin K. Petersen 1 month, 3 weeks ago
Caleb,

> The ublk driver doesn't access request integrity buffers directly, it
> only copies them to/from the ublk server in ublk_copy_user_integrity().
> ublk_copy_user_integrity() uses bio_for_each_integrity_vec() to walk all
> the integrity segments. ublk devices are therefore capable of handling
> requests with integrity intervals split across segments. Set
> BLK_SPLIT_INTERVAL_CAPABLE in the struct blk_integrity flags for ublk
> devices to opt out of the integrity-interval dma_alignment limit.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen
Re: [PATCH 7.1] ublk: report BLK_SPLIT_INTERVAL_CAPABLE
Posted by Keith Busch 1 month, 3 weeks ago
On Tue, Feb 24, 2026 at 08:57:22AM -0700, Caleb Sander Mateos wrote:
> The ublk driver doesn't access request integrity buffers directly, it
> only copies them to/from the ublk server in ublk_copy_user_integrity().
> ublk_copy_user_integrity() uses bio_for_each_integrity_vec() to walk all
> the integrity segments. ublk devices are therefore capable of handling
> requests with integrity intervals split across segments. Set
> BLK_SPLIT_INTERVAL_CAPABLE in the struct blk_integrity flags for ublk
> devices to opt out of the integrity-interval dma_alignment limit.

Looks good:

Reviewed-by: Keith Busch <kbusch@kernel.org>