[PATCH] net/hsr: update outdated comment

kexinsun posted 1 patch 1 month, 1 week ago
net/hsr/hsr_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] net/hsr: update outdated comment
Posted by kexinsun 1 month, 1 week ago
The function hsr_rcv() was renamed hsr_handle_frame() and moved to
net/hsr/hsr_slave.c by commit 81ba6afd6e64 ("net/hsr: Switch from
dev_add_pack() to netdev_rx_handler_register()"). Update the comment
accordingly.

Signed-off-by: kexinsun <kexinsun@smail.nju.edu.cn>
---
 net/hsr/hsr_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c
index d1bfc49b5f01..5c3eca2235ce 100644
--- a/net/hsr/hsr_device.c
+++ b/net/hsr/hsr_device.c
@@ -742,7 +742,7 @@ int hsr_dev_finalize(struct net_device *hsr_dev, struct net_device *slave[2],
 		hsr->proto_ops = &hsr_ops;
 	}
 
-	/* Make sure we recognize frames from ourselves in hsr_rcv() */
+	/* Make sure we recognize frames from ourselves in hsr_handle_frame() */
 	res = hsr_create_self_node(hsr, hsr_dev->dev_addr,
 				   slave[1]->dev_addr);
 	if (res < 0)
-- 
2.25.1
Re: [PATCH] net/hsr: update outdated comment
Posted by Simon Horman 1 month, 1 week ago
On Tue, Feb 24, 2026 at 10:12:05AM +0800, kexinsun wrote:
> The function hsr_rcv() was renamed hsr_handle_frame() and moved to
> net/hsr/hsr_slave.c by commit 81ba6afd6e64 ("net/hsr: Switch from
> dev_add_pack() to netdev_rx_handler_register()"). Update the comment
> accordingly.
> 
> Signed-off-by: kexinsun <kexinsun@smail.nju.edu.cn>

I notice that you have sent a number of similar fixes recently.
I am curious to know how you found these problems.

If you are using a tool, please consider using the Assisted-by tag:
https://docs.kernel.org/process/coding-assistants.html

Also, both git grep and our AI generated code review
tell me that this is not the only instance of hsr_rcv lingering
in comments in this driver. Please update all of them.

-- 
pw-bot: changes-requested