[PATCH] rds: update outdated comment

kexinsun posted 1 patch 1 month, 1 week ago
net/rds/send.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] rds: update outdated comment
Posted by kexinsun 1 month, 1 week ago
The function rds_send_reset() was subsumed by rds_send_path_reset()
by commit d769ef81d5b5 ("RDS: Update rds_conn_shutdown to work with
rds_conn_path").  Update the comment accordingly.

Signed-off-by: kexinsun <kexinsun@smail.nju.edu.cn>
---
 net/rds/send.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/rds/send.c b/net/rds/send.c
index a1039e422a38..d8b14ff9d366 100644
--- a/net/rds/send.c
+++ b/net/rds/send.c
@@ -284,7 +284,7 @@ int rds_send_xmit(struct rds_conn_path *cp)
 		 *
 		 * cp_xmit_rm holds a ref while we're sending this message down
 		 * the connection.  We can use this ref while holding the
-		 * send_sem.. rds_send_reset() is serialized with it.
+		 * send_sem.. rds_send_path_reset() is serialized with it.
 		 */
 		if (!rm) {
 			unsigned int len;
-- 
2.25.1
Re: [PATCH] rds: update outdated comment
Posted by Allison Henderson 1 month, 1 week ago
On Tue, 2026-02-24 at 10:07 +0800, kexinsun wrote:
> The function rds_send_reset() was subsumed by rds_send_path_reset()
> by commit d769ef81d5b5 ("RDS: Update rds_conn_shutdown to work with
> rds_conn_path").  Update the comment accordingly.
> 
> Signed-off-by: kexinsun <kexinsun@smail.nju.edu.cn>
> ---
>  net/rds/send.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/rds/send.c b/net/rds/send.c
> index a1039e422a38..d8b14ff9d366 100644
> --- a/net/rds/send.c
> +++ b/net/rds/send.c
> @@ -284,7 +284,7 @@ int rds_send_xmit(struct rds_conn_path *cp)
>  		 *
>  		 * cp_xmit_rm holds a ref while we're sending this message down
>  		 * the connection.  We can use this ref while holding the
> -		 * send_sem.. rds_send_reset() is serialized with it.
> +		 * send_sem.. rds_send_path_reset() is serialized with it.
>  		 */
>  		if (!rm) {
>  			unsigned int len;

Hi kexinsun,

Thanks for the catch.  Just one small nit:  Your patch should specify the target
branch, version and component like this:

[PATCH net-next v2] net/rds: update outdated comment in rds_send_xmit

Other than that, this patch looks pretty straight forward.  Thank you!

Allison
Re: [PATCH] rds: update outdated comment
Posted by Jakub Kicinski 1 month, 1 week ago
On Wed, 25 Feb 2026 03:03:10 +0000 Allison Henderson wrote:
> Thanks for the catch.  Just one small nit:  Your patch should specify the target
> branch, version and component like this:
> 
> [PATCH net-next v2] net/rds: update outdated comment in rds_send_xmit

That's right, please try to remember the tree name in the future.
Since net-next is our default tree anyway, there's no need to repost