net: freescale: ucc_geth: call of_node_put once

[PATCH net-next] net: freescale: ucc_geth: call of_node_put once

Posted by Rosen Penev 1 month, 1 week ago

Move it up to avoid placing it in both the error and success paths.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/net/ethernet/freescale/ucc_geth.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
index 78d72409b6e0..4d598693d7a6 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -3470,14 +3470,13 @@ static int ucc_geth_probe(struct platform_device* ofdev)
 	phy_node = of_parse_phandle(np, "phy-handle", 0);
 	if (phy_node) {
 		prop = of_get_property(phy_node, "interface", NULL);
+		of_node_put(phy_node);
 		if (prop) {
 			dev_err(&ofdev->dev,
 				"Device-tree property 'interface' is no longer supported. Please use 'phy-connection-type' instead.");
-			of_node_put(phy_node);
 			err = -EINVAL;
 			goto err_put_tbi;
 		}
-		of_node_put(phy_node);
 	}

 	err = of_get_phy_mode(np, &phy_interface);
--
2.53.0

Re: [PATCH net-next] net: freescale: ucc_geth: call of_node_put once

Posted by Simon Horman 1 month, 1 week ago

+ Maxime


On Mon, Feb 23, 2026 at 05:41:41PM -0800, Rosen Penev wrote:
> Move it up to avoid placing it in both the error and success paths.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Reviewed-by: Simon Horman <horms@kernel.org>

> ---
>  drivers/net/ethernet/freescale/ucc_geth.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/drivers/net/ethernet/freescale/ucc_geth.c
> index 78d72409b6e0..4d598693d7a6 100644
> --- a/drivers/net/ethernet/freescale/ucc_geth.c
> +++ b/drivers/net/ethernet/freescale/ucc_geth.c
> @@ -3470,14 +3470,13 @@ static int ucc_geth_probe(struct platform_device* ofdev)
>  	phy_node = of_parse_phandle(np, "phy-handle", 0);
>  	if (phy_node) {
>  		prop = of_get_property(phy_node, "interface", NULL);
> +		of_node_put(phy_node);
>  		if (prop) {
>  			dev_err(&ofdev->dev,
>  				"Device-tree property 'interface' is no longer supported. Please use 'phy-connection-type' instead.");
> -			of_node_put(phy_node);
>  			err = -EINVAL;
>  			goto err_put_tbi;
>  		}
> -		of_node_put(phy_node);
>  	}
> 
>  	err = of_get_phy_mode(np, &phy_interface);
> --
> 2.53.0
> 
>