include/linux/mfd/cgbc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Correct the struct member names to avoid kernel-doc warnings:
Warning: include/linux/mfd/cgbc.h:38 struct member 'version' not
described in 'cgbc_device_data'
Warning: ../include/linux/mfd/cgbc.h:38 struct member 'lock' not
described in 'cgbc_device_data'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Thomas Richard <thomas.richard@bootlin.com>
Cc: Lee Jones <lee@kernel.org>
include/linux/mfd/cgbc.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-next-20260220.orig/include/linux/mfd/cgbc.h
+++ linux-next-20260220/include/linux/mfd/cgbc.h
@@ -26,8 +26,8 @@ struct cgbc_version {
* @io_cmd: Pointer to the command IO memory
* @session: Session id returned by the Board Controller
* @dev: Pointer to kernel device structure
- * @cgbc_version: Board Controller version structure
- * @mutex: Board Controller mutex
+ * @version: Board Controller version structure
+ * @lock: Board Controller mutex
*/
struct cgbc_device_data {
void __iomem *io_session;
On Mon, 23 Feb 2026, Randy Dunlap wrote: > Correct the struct member names to avoid kernel-doc warnings: > > Warning: include/linux/mfd/cgbc.h:38 struct member 'version' not > described in 'cgbc_device_data' > Warning: ../include/linux/mfd/cgbc.h:38 struct member 'lock' not > described in 'cgbc_device_data' > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > --- > Cc: Thomas Richard <thomas.richard@bootlin.com> > Cc: Lee Jones <lee@kernel.org> > > include/linux/mfd/cgbc.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) b4 is having a hard time with this set: Analyzing 4 messages in the thread Assuming new revision: v2 ([PATCH] mfd: rsmu: remove a empty kernel-doc line) Assuming new revision: v3 ([PATCH] mfd: Kontron PLD: fix kernel-doc struct member names) Assuming new revision: v4 ([PATCH] mfd: si476x: fix kernel-doc warnings) Will use the latest revision: v4 You can pick other revisions using the -vN flag Specified msgid is not present in the series, cannot cherrypick Can you please resubmit as a proper set (1/4 -> 4/4)? -- Lee Jones [李琼斯]
On 3/6/26 4:58 AM, Lee Jones wrote: > On Mon, 23 Feb 2026, Randy Dunlap wrote: > >> Correct the struct member names to avoid kernel-doc warnings: >> >> Warning: include/linux/mfd/cgbc.h:38 struct member 'version' not >> described in 'cgbc_device_data' >> Warning: ../include/linux/mfd/cgbc.h:38 struct member 'lock' not >> described in 'cgbc_device_data' >> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> --- >> Cc: Thomas Richard <thomas.richard@bootlin.com> >> Cc: Lee Jones <lee@kernel.org> >> >> include/linux/mfd/cgbc.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > b4 is having a hard time with this set: > > Analyzing 4 messages in the thread > Assuming new revision: v2 ([PATCH] mfd: rsmu: remove a empty kernel-doc line) > Assuming new revision: v3 ([PATCH] mfd: Kontron PLD: fix kernel-doc struct member names) > Assuming new revision: v4 ([PATCH] mfd: si476x: fix kernel-doc warnings) > Will use the latest revision: v4 > You can pick other revisions using the -vN flag > Specified msgid is not present in the series, cannot cherrypick > > Can you please resubmit as a proper set (1/4 -> 4/4)? You also replied that you had applied the "rsmu" patch. Should I just resend the other 3 patches? thanks. -- ~Randy
On Fri, 06 Mar 2026, Randy Dunlap wrote: > > > On 3/6/26 4:58 AM, Lee Jones wrote: > > On Mon, 23 Feb 2026, Randy Dunlap wrote: > > > >> Correct the struct member names to avoid kernel-doc warnings: > >> > >> Warning: include/linux/mfd/cgbc.h:38 struct member 'version' not > >> described in 'cgbc_device_data' > >> Warning: ../include/linux/mfd/cgbc.h:38 struct member 'lock' not > >> described in 'cgbc_device_data' > >> > >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > >> --- > >> Cc: Thomas Richard <thomas.richard@bootlin.com> > >> Cc: Lee Jones <lee@kernel.org> > >> > >> include/linux/mfd/cgbc.h | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > > > b4 is having a hard time with this set: > > > > Analyzing 4 messages in the thread > > Assuming new revision: v2 ([PATCH] mfd: rsmu: remove a empty kernel-doc line) > > Assuming new revision: v3 ([PATCH] mfd: Kontron PLD: fix kernel-doc struct member names) > > Assuming new revision: v4 ([PATCH] mfd: si476x: fix kernel-doc warnings) > > Will use the latest revision: v4 > > You can pick other revisions using the -vN flag > > Specified msgid is not present in the series, cannot cherrypick > > > > Can you please resubmit as a proper set (1/4 -> 4/4)? > > You also replied that you had applied the "rsmu" patch. > Should I just resend the other 3 patches? Thanks for spotting that, I assumed all had failed. Please resend all of 4 of them. -- Lee Jones [李琼斯]
kernel-doc format expects a prototype on the line that immediately
follows the "/**" line, so drop this empty line.
Warning: include/linux/mfd/rsmu.h:21 Cannot find identifier on line: *
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Lee Jones <lee@kernel.org>
include/linux/mfd/rsmu.h | 1 -
1 file changed, 1 deletion(-)
--- linux-next-20260220.orig/include/linux/mfd/rsmu.h
+++ linux-next-20260220/include/linux/mfd/rsmu.h
@@ -19,7 +19,6 @@ enum rsmu_type {
};
/**
- *
* struct rsmu_ddata - device data structure for sub devices.
*
* @dev: i2c/spi device.
On Mon, 23 Feb 2026 12:12:12 -0800, Randy Dunlap wrote:
> kernel-doc format expects a prototype on the line that immediately
> follows the "/**" line, so drop this empty line.
>
> Warning: include/linux/mfd/rsmu.h:21 Cannot find identifier on line: *
>
>
Applied, thanks!
[1/1] mfd: rsmu: remove a empty kernel-doc line
commit: 064877fe76ab44b6290c88ddcb01679fbc5798d8
--
Lee Jones [李琼斯]
Correct the struct member names to avoid kernel-doc warnings:
Warning: include/linux/mfd/kempld.h:114 struct member 'gpio_base' not
described in 'kempld_platform_data'
Warning: include/linux/mfd/kempld.h:114 struct member 'get_hardware_mutex'
not described in 'kempld_platform_data'
Warning: include/linux/mfd/kempld.h:114 struct member
'release_hardware_mutex' not described in 'kempld_platform_data'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Michael Brunner <michael.brunner@kontron.com>
Cc: Lee Jones <lee@kernel.org>
include/linux/mfd/kempld.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- linux-next-20260220.orig/include/linux/mfd/kempld.h
+++ linux-next-20260220/include/linux/mfd/kempld.h
@@ -97,10 +97,10 @@ struct kempld_device_data {
/**
* struct kempld_platform_data - PLD hardware configuration structure
* @pld_clock: PLD clock frequency
- * @gpio_base GPIO base pin number
+ * @gpio_base: GPIO base pin number
* @ioresource: IO addresses of the PLD
- * @get_mutex: PLD specific get_mutex callback
- * @release_mutex: PLD specific release_mutex callback
+ * @get_hardware_mutex: PLD specific get_mutex callback
+ * @release_hardware_mutex: PLD specific release_mutex callback
* @get_info: PLD specific get_info callback
* @register_cells: PLD specific register_cells callback
*/
Add kernel-doc entries for missing fields or correct some typos
in names to eliminate kernel-doc warnings:
Warning: include/linux/mfd/si476x-core.h:156 struct member 'regmap' not
described in 'si476x_core'
Warning: include/linux/mfd/si476x-core.h:156 struct member 'power_state'
not described in 'si476x_core'
Warning: include/linux/mfd/si476x-core.h:156 struct member 'supplies' not
described in 'si476x_core'
Warning: include/linux/mfd/si476x-core.h:156 struct member 'is_alive' not
described in 'si476x_core'
Warning: include/linux/mfd/si476x-core.h:156 struct member 'rds_fifo_depth'
not described in 'si476x_core'
Warning: include/linux/mfd/si476x-core.h:170 function parameter 'core' not
described in 'si476x_core_lock'
Warning: include/linux/mfd/si476x-core.h:179 function parameter 'core' not
described in 'si476x_core_unlock'
Warning: include/linux/mfd/si476x-core.h:259 struct member 'firmware' not
described in 'si476x_func_info'
Warning: include/linux/mfd/si476x-core.h:335 struct member 'rds' not
described in 'si476x_rds_status_report'
I don't know what the 'ble' field is so I didn't add a kernel-doc comment
for it:
Warning: include/linux/mfd/si476x-core.h:335 struct member 'ble' not
described in 'si476x_rds_status_report'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Lee Jones <lee@kernel.org>
include/linux/mfd/si476x-core.h | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
--- linux-next-20260220.orig/include/linux/mfd/si476x-core.h
+++ linux-next-20260220/include/linux/mfd/si476x-core.h
@@ -77,6 +77,7 @@ enum si476x_power_state {
* underlying "core" device which all the MFD cell-devices use.
*
* @client: Actual I2C client used to transfer commands to the chip.
+ * @regmap: Regmap for accessing the device registers
* @chip_id: Last digit of the chip model(E.g. "1" for SI4761)
* @cells: MFD cell devices created by this driver.
* @cmd_lock: Mutex used to serialize all the requests to the core
@@ -100,16 +101,18 @@ enum si476x_power_state {
* @stc: Similar to @cts, but for the STC bit of the status value.
* @power_up_parameters: Parameters used as argument for POWER_UP
* command when the device is started.
- * @state: Current power state of the device.
- * @supplues: Structure containing handles to all power supplies used
+ * @power_state: Current power state of the device.
+ * @supplies: Structure containing handles to all power supplies used
* by the device (NULL ones are ignored).
* @gpio_reset: GPIO pin connectet to the RSTB pin of the chip.
* @pinmux: Chip's configurable pins configuration.
* @diversity_mode: Chips role when functioning in diversity mode.
+ * @is_alive: Chip is initialized and active.
* @status_monitor: Polling worker used in polling use case scenarion
* (when IRQ is not avalible).
* @revision: Chip's running firmware revision number(Used for correct
* command set support).
+ * @rds_fifo_depth: RDS FIFO size: 20 for IRQ mode or 5 for polling mode.
*/
struct si476x_core {
@@ -166,6 +169,7 @@ static inline struct si476x_core *i2c_mf
/**
* si476x_core_lock() - lock the core device to get an exclusive access
* to it.
+ * @core: Core device structure
*/
static inline void si476x_core_lock(struct si476x_core *core)
{
@@ -175,6 +179,7 @@ static inline void si476x_core_lock(stru
/**
* si476x_core_unlock() - unlock the core device to relinquish an
* exclusive access to it.
+ * @core: Core device structure
*/
static inline void si476x_core_unlock(struct si476x_core *core)
{
@@ -246,9 +251,10 @@ static inline int si476x_to_v4l2(struct
* struct si476x_func_info - structure containing result of the
* FUNC_INFO command.
*
+ * @firmware: Firmware version numbers.
* @firmware.major: Firmware major number.
* @firmware.minor[...]: Firmware minor numbers.
- * @patch_id:
+ * @patch_id: Firmware patch level.
* @func: Mode tuner is working in.
*/
struct si476x_func_info {
@@ -318,8 +324,9 @@ enum si476x_smoothmetrics {
* @tp: Current channel's TP flag.
* @pty: Current channel's PTY code.
* @pi: Current channel's PI code.
- * @rdsfifoused: Number of blocks remaining in the RDS FIFO (0 if
- * empty).
+ * @rdsfifoused: Number of blocks remaining in the RDS FIFO (0 if empty).
+ * @ble:
+ * @rds: RDS data descriptor
*/
struct si476x_rds_status_report {
bool rdstpptyint, rdspiint, rdssyncint, rdsfifoint;
© 2016 - 2026 Red Hat, Inc.