[PATCH ath-next] wifi: ath9k: use non devm for nvmem_cell_get

Rosen Penev posted 1 patch 1 month, 3 weeks ago
drivers/net/wireless/ath/ath9k/init.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH ath-next] wifi: ath9k: use non devm for nvmem_cell_get
Posted by Rosen Penev 1 month, 3 weeks ago
There's absolutely no need to extend the lifetime of cell to post
removal of the driver. It's only used in this function.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/net/wireless/ath/ath9k/init.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index 28dc6c0e27aa..38fb1e763c6e 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -588,7 +588,7 @@ static int ath9k_nvmem_request_eeprom(struct ath_softc *sc)
 	size_t len;
 	int err;

-	cell = devm_nvmem_cell_get(sc->dev, "calibration");
+	cell = nvmem_cell_get(sc->dev, "calibration");
 	if (IS_ERR(cell)) {
 		err = PTR_ERR(cell);

@@ -605,6 +605,7 @@ static int ath9k_nvmem_request_eeprom(struct ath_softc *sc)
 	}

 	buf = nvmem_cell_read(cell, &len);
+	nvmem_cell_put(cell);
 	if (IS_ERR(buf))
 		return PTR_ERR(buf);

--
2.53.0
Re: [PATCH ath-next] wifi: ath9k: use non devm for nvmem_cell_get
Posted by Toke Høiland-Jørgensen 1 month, 3 weeks ago
Rosen Penev <rosenp@gmail.com> writes:

> There's absolutely no need to extend the lifetime of cell to post
> removal of the driver. It's only used in this function.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Right, makes sense.

Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>