pinctrl: pic32: allow driver to be compiled with COMPILE_TEST

[PATCH 0/3] pinctrl: pic32: allow driver to be compiled with COMPILE_TEST

Posted by Brian Masney 1 month, 3 weeks ago

While migrating a pic32 clk driver off of a legacy API, I mistakenly
broke one of the drivers, and the issue could have been caught with a
simple compile test. Now that the dependent patches have been merged
into Linus's tree via the MIPS tree, we can now enable COMPILE_TEST
for all of pic32 drivers in this subsystem.

While changes are being made to this driver, let's also fix any
outstanding checkpatch.pl errors with this driver.

Signed-off-by: Brian Masney <bmasney@redhat.com>
---
Brian Masney (3):
      pinctrl: pic32: change all cases of bare 'unsigned' to 'unsigned int'
      pinctrl: pic32: use consistent spacing around '+'
      pinctrl: pic32: allow driver to be compiled with COMPILE_TEST

 drivers/pinctrl/Kconfig         |  2 +-
 drivers/pinctrl/pinctrl-pic32.c | 42 ++++++++++++++++++++---------------------
 2 files changed, 22 insertions(+), 22 deletions(-)
---
base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
change-id: 20260222-pinctrl-pic32-dcb7051a882b

Best regards,
-- 
Brian Masney <bmasney@redhat.com>

Re: [PATCH 0/3] pinctrl: pic32: allow driver to be compiled with COMPILE_TEST

Posted by Linus Walleij 1 month, 3 weeks ago

On Mon, Feb 23, 2026 at 12:33 AM Brian Masney <bmasney@redhat.com> wrote:

> While migrating a pic32 clk driver off of a legacy API, I mistakenly
> broke one of the drivers, and the issue could have been caught with a
> simple compile test. Now that the dependent patches have been merged
> into Linus's tree via the MIPS tree, we can now enable COMPILE_TEST
> for all of pic32 drivers in this subsystem.
>
> While changes are being made to this driver, let's also fix any
> outstanding checkpatch.pl errors with this driver.
>
> Signed-off-by: Brian Masney <bmasney@redhat.com>

Thanks Brian, going the extra mile as always!
Patches applied for v7.1.

Yours,
Linus Walleij

Re: [PATCH 0/3] pinctrl: pic32: allow driver to be compiled with COMPILE_TEST

Posted by Bartosz Golaszewski 1 month, 3 weeks ago

On Mon, 23 Feb 2026 00:33:28 +0100, Brian Masney <bmasney@redhat.com> said:
> While migrating a pic32 clk driver off of a legacy API, I mistakenly
> broke one of the drivers, and the issue could have been caught with a
> simple compile test. Now that the dependent patches have been merged
> into Linus's tree via the MIPS tree, we can now enable COMPILE_TEST
> for all of pic32 drivers in this subsystem.
>
> While changes are being made to this driver, let's also fix any
> outstanding checkpatch.pl errors with this driver.
>
> Signed-off-by: Brian Masney <bmasney@redhat.com>
> ---
> Brian Masney (3):
>       pinctrl: pic32: change all cases of bare 'unsigned' to 'unsigned int'
>       pinctrl: pic32: use consistent spacing around '+'
>       pinctrl: pic32: allow driver to be compiled with COMPILE_TEST
>
>  drivers/pinctrl/Kconfig         |  2 +-
>  drivers/pinctrl/pinctrl-pic32.c | 42 ++++++++++++++++++++---------------------
>  2 files changed, 22 insertions(+), 22 deletions(-)
> ---
> base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
> change-id: 20260222-pinctrl-pic32-dcb7051a882b
>
> Best regards,
> --
> Brian Masney <bmasney@redhat.com>
>
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>