[v2] staging: rtl8723bs: Use kmemdup in sdio_ops.c

[PATCH v2] staging: rtl8723bs: Use kmemdup in sdio_ops.c

Posted by Giorgi Tchankvetadze 1 month, 3 weeks ago

Replace kmalloc() + memcpy() with kmemdup() to simplify the code.
No functional change.

Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
---
Changes in v2: Remove leftover blank line (suggested by Dan Carpenter)

 drivers/staging/rtl8723bs/hal/sdio_ops.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index c9cb20c61a2b..514c857a998e 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -583,12 +583,10 @@ s32 sdio_local_write(
 	)
 		return sd_cmd52_write(intfhdl, addr, cnt, buf);
 
-	tmpbuf = kmalloc(cnt, GFP_ATOMIC);
+	tmpbuf = kmemdup(buf, cnt, GFP_ATOMIC);
 	if (!tmpbuf)
 		return -ENOMEM;
 
-	memcpy(tmpbuf, buf, cnt);
-
 	err = sd_write(intfhdl, addr, cnt, tmpbuf);
 
 	kfree(tmpbuf);
-- 
2.52.0

Re: [PATCH v2] staging: rtl8723bs: Use kmemdup in sdio_ops.c

Posted by Dan Carpenter 1 month, 3 weeks ago

On Sat, Feb 21, 2026 at 05:39:34PM +0400, Giorgi Tchankvetadze wrote:
> Replace kmalloc() + memcpy() with kmemdup() to simplify the code.
> No functional change.
> 
> Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
> ---
> Changes in v2: Remove leftover blank line (suggested by Dan Carpenter)
> 

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter