[PATCH v2] staging: rtl8723bs: Fix spelling mistakes and comment format

tomasz.unger@yahoo.pl posted 1 patch 1 month, 3 weeks ago
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
[PATCH v2] staging: rtl8723bs: Fix spelling mistakes and comment format
Posted by tomasz.unger@yahoo.pl 1 month, 3 weeks ago
From: Tomasz Unger <tomasz.unger@yahoo.pl>

Fix spelling mistakes in comments:
- 'alloction' -> 'allocation'
- 'overwirte' -> 'overwrite'
- 'indx' -> 'index'

Also convert a long single-line comment to multi-line format
as per coding-style.rst.

Found using codespell.

Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
v2:
- Added multi-line comment format as requested by reviewer
- Changed "Found by manual inspection" to "Found using codespell"

 drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 9284657e23c2..b99a60e707c2 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -572,7 +572,7 @@ s16 rtw_camid_alloc(struct adapter *adapter, struct sta_info *sta, u8 kid)
 
 	if ((((mlmeinfo->state & 0x03) == WIFI_FW_AP_STATE) || ((mlmeinfo->state & 0x03) == WIFI_FW_ADHOC_STATE))
 		&& !sta) {
-		/* AP/Ad-hoc mode group key: static alloction to default key by key ID */
+		/* AP/Ad-hoc mode group key: static allocation to default key by key ID */
 		if (kid > 3) {
 			netdev_dbg(adapter->pnetdev,
 				   FUNC_ADPT_FMT " group key with invalid key id:%u\n",
@@ -597,7 +597,10 @@ s16 rtw_camid_alloc(struct adapter *adapter, struct sta_info *sta, u8 kid)
 
 		i = _rtw_camid_search(adapter, addr, kid);
 		if (i >= 0) {
-			/* Fix issue that pairwise and group key have same key id. Pairwise key first, group key can overwirte group only(ex: rekey) */
+			/*
+			 * Fix issue that pairwise and group key have same key id.
+			 * Pairwise key first, group key can overwrite group only(ex: rekey)
+			 */
 			if (sta || _rtw_camid_is_gk(adapter, i))
 				cam_id = i;
 			else
@@ -704,7 +707,7 @@ static void sort_wmm_ac_params(u32 *inx, u32 *edca)
 {
 	u32 i, j, change_inx = false;
 
-	/* entry indx: 0->vo, 1->vi, 2->be, 3->bk. */
+	/* entry index: 0->vo, 1->vi, 2->be, 3->bk. */
 	for (i = 0; i < 4; i++) {
 		for (j = i + 1; j < 4; j++) {
 			/* compare CW and AIFS */
-- 
2.53.0
Re: [PATCH v2] staging: rtl8723bs: Fix spelling mistakes and comment format
Posted by Greg KH 1 month, 3 weeks ago
On Sat, Feb 21, 2026 at 01:07:19PM +0100, tomasz.unger@yahoo.pl wrote:
> From: Tomasz Unger <tomasz.unger@yahoo.pl>
> 
> Fix spelling mistakes in comments:
> - 'alloction' -> 'allocation'
> - 'overwirte' -> 'overwrite'
> - 'indx' -> 'index'
> 
> Also convert a long single-line comment to multi-line format
> as per coding-style.rst.

That is 2 different things, this should be 2 different patches :(

Please resend this as a patch series.

thanks,

greg k-h
Re: [PATCH v2] staging: rtl8723bs: Fix spelling mistakes and comment format
Posted by Ethan Tidmore 1 month, 3 weeks ago
On Sat Feb 21, 2026 at 6:07 AM CST, tomasz.unger wrote:
> From: Tomasz Unger <tomasz.unger@yahoo.pl>
>
> Fix spelling mistakes in comments:
> - 'alloction' -> 'allocation'
> - 'overwirte' -> 'overwrite'
> - 'indx' -> 'index'
>
> Also convert a long single-line comment to multi-line format
> as per coding-style.rst.
>
> Found using codespell.
>
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
> v2:
> - Added multi-line comment format as requested by reviewer
> - Changed "Found by manual inspection" to "Found using codespell"

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

Thanks,

ET