net: wireless: rsi: Don't default to -EOPNOTSUPP in rsi_mac80211_config

[PATCH] net: wireless: rsi: Don't default to -EOPNOTSUPP in rsi_mac80211_config

Posted by Sebastian Krzyszkowiak 1 month, 3 weeks ago

This triggers a WARN_ON in ieee80211_hw_conf_init and isn't the expected
behavior from the driver - other drivers default to 0 too.

Fixes: 0a44dfc07074 ("wifi: mac80211: simplify non-chanctx drivers")
Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
---
 drivers/net/wireless/rsi/rsi_91x_mac80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
index 8c8e074a3a70..c7ae8031436a 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
@@ -668,7 +668,7 @@ static int rsi_mac80211_config(struct ieee80211_hw *hw,
 	struct rsi_hw *adapter = hw->priv;
 	struct rsi_common *common = adapter->priv;
 	struct ieee80211_conf *conf = &hw->conf;
-	int status = -EOPNOTSUPP;
+	int status = 0;
 
 	mutex_lock(&common->mutex);
 

---
base-commit: d79526b89571ae447c1a5cfd3d627efa07098348
change-id: 20260221-rsi-config-ret-6234209a8e37

Best regards,
-- 
Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>

Re: [PATCH] net: wireless: rsi: Don't default to -EOPNOTSUPP in rsi_mac80211_config

Posted by Johannes Berg 1 month, 3 weeks ago

Should have "wifi: rsi: ..." prefix

On Sat, 2026-02-21 at 17:28 +0100, Sebastian Krzyszkowiak wrote:
> This triggers a WARN_ON in ieee80211_hw_conf_init and isn't the expected
> behavior from the driver - other drivers default to 0 too.

This makes sense, but

> Fixes: 0a44dfc07074 ("wifi: mac80211: simplify non-chanctx drivers")

not sure this makes much sense? I guess it added the warning though.

> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
> ---
>  drivers/net/wireless/rsi/rsi_91x_mac80211.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> index 8c8e074a3a70..c7ae8031436a 100644
> --- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> +++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> @@ -668,7 +668,7 @@ static int rsi_mac80211_config(struct ieee80211_hw *hw,
>  	struct rsi_hw *adapter = hw->priv;
>  	struct rsi_common *common = adapter->priv;
>  	struct ieee80211_conf *conf = &hw->conf;
> -	int status = -EOPNOTSUPP;
> +	int status = 0;

I'll note that this just fixes a minor thing in this driver, if you want
to actually use it you probably also want to fix

 - status is overwritten if multiple changes happen

 - WIPHY_PARAM_RTS_THRESHOLD there max absolutely no sense at all

johannes