From: Frieder Schrempf <frieder.schrempf@kontron.de>

To make the code more readable, use the macros for the GPIO and IRQ
settings.

Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mp-kontron-dl.dtso | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-kontron-dl.dtso b/arch/arm64/boot/dts/freescale/imx8mp-kontron-dl.dtso
index 7131e9a499ae1..41a2bb74f1565 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-kontron-dl.dtso
+++ b/arch/arm64/boot/dts/freescale/imx8mp-kontron-dl.dtso
@@ -7,6 +7,7 @@
 /plugin/;
 
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
 #include "imx8mp-pinfunc.h"
 
 &{/} {
@@ -80,11 +81,11 @@ touchscreen@5d {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_touch>;
 		interrupt-parent = <&gpio1>;
-		interrupts = <6 8>;
-		irq-gpios = <&gpio1 6 0>;
+		interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
+		irq-gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>;
 		AVDD28-supply = <&reg_vcc_panel>;
 		VDDIO-supply = <&reg_vcc_panel>;
-		reset-gpios = <&gpio1 7 0>;
+		reset-gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>;
 	};
 };
 
-- 
2.52.0

On 2/20/26 12:36, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> To make the code more readable, use the macros for the GPIO and IRQ
> settings.
>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>


Typically your Signed-off-by tag should come last so you need to swap S-o-b with R-b tags

in the commit message above.

With that you can add my:

Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>

On Fri, Feb 20, 2026 at 8:20 AM Daniel Baluta <daniel.baluta@oss.nxp.com> wrote:
>
> On 2/20/26 12:36, Frieder Schrempf wrote:
> > From: Frieder Schrempf <frieder.schrempf@kontron.de>
> >
> > To make the code more readable, use the macros for the GPIO and IRQ
> > settings.
> >
> > Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> > Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
>
> Typically your Signed-off-by tag should come last so you need to swap S-o-b with R-b tags
>
> in the commit message above.

Is this suggestion valid?

Shouldn't the tags appear in chronological order?

On 2/20/26 13:57, Fabio Estevam wrote:
> On Fri, Feb 20, 2026 at 8:20 AM Daniel Baluta <daniel.baluta@oss.nxp.com> wrote:
>> On 2/20/26 12:36, Frieder Schrempf wrote:
>>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>>
>>> To make the code more readable, use the macros for the GPIO and IRQ
>>> settings.
>>>
>>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>>> Reviewed-by: Frank Li <Frank.Li@nxp.com>
>>
>> Typically your Signed-off-by tag should come last so you need to swap S-o-b with R-b tags
>>
>> in the commit message above.
> Is this suggestion valid?
>
> Shouldn't the tags appear in chronological order?

Tools like b4 indeed are taking the tags in chronological order.
But I always considered that when sending next version you pick all the tags

and then add your Signed-off-by last.

E.g https://www.spinics.net/lists/kernel/msg5995225.html

On 20.02.26 13:27, Daniel Baluta wrote:
> On 2/20/26 13:57, Fabio Estevam wrote:
>> On Fri, Feb 20, 2026 at 8:20 AM Daniel Baluta <daniel.baluta@oss.nxp.com> wrote:
>>> On 2/20/26 12:36, Frieder Schrempf wrote:
>>>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>>>
>>>> To make the code more readable, use the macros for the GPIO and IRQ
>>>> settings.
>>>>
>>>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>>>> Reviewed-by: Frank Li <Frank.Li@nxp.com>
>>>
>>> Typically your Signed-off-by tag should come last so you need to swap S-o-b with R-b tags
>>>
>>> in the commit message above.
>> Is this suggestion valid?
>>
>> Shouldn't the tags appear in chronological order?
> 
> Tools like b4 indeed are taking the tags in chronological order.
> But I always considered that when sending next version you pick all the tags
> 
> and then add your Signed-off-by last.
> 
> E.g https://www.spinics.net/lists/kernel/msg5995225.html

I've always been adding the collected tags below my S-o-b tag. And I've
never heard any complaints from the i.MX subsystem maintainers, so I
assume it is ok like that and there is no need to change anything.

As far as I know most other subsystems also don't have strict rules for
the tag order.