bcm-ns.dtsi specifies a default layout that is not correct for the
RT-AC87U. Also allows setting the WAN MAC address properly.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
.../dts/broadcom/bcm4709-asus-rt-ac87u.dts | 37 +++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac87u.dts b/arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac87u.dts
index 59400217f8c3..f48c44ff01c0 100644
--- a/arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac87u.dts
+++ b/arch/arm/boot/dts/broadcom/bcm4709-asus-rt-ac87u.dts
@@ -77,6 +77,43 @@ &usb3_phy {
status = "okay";
};
+&srab {
+ status = "okay";
+
+ ports {
+ port@0 {
+ label = "wan";
+
+ nvmem-cells = <&et1macaddr 1>;
+ nvmem-cell-names = "mac-address";
+ };
+
+ port@1 {
+ label = "lan1";
+ };
+
+ port@2 {
+ label = "lan2";
+ };
+
+ port@3 {
+ label = "lan3";
+ };
+
+ port@5 {
+ status = "disabled";
+ };
+
+ port@7 {
+ label = "cpu";
+ };
+
+ port@8 {
+ status = "disabled";
+ };
+ };
+};
+
&nandcs {
partitions {
compatible = "fixed-partitions";
--
2.53.0
pt., 20 lut 2026 o 03:14 Rosen Penev <rosenp@gmail.com> napisał(a): > bcm-ns.dtsi specifies a default layout that is not correct for the > RT-AC87U. Also allows setting the WAN MAC address properly. How the basic ports info from bcm-ns.dtsi is not correct for RT-AC87U? I don't see you doing any overwriting or /delete-node/. It seems like a standard NS device with BCM53011 and 8 ports (0, 1, 2, 3, 4, 5, 7, 8), three of them connected to no-SoC Ethernet interfaces. Except for this unclear commit description, your changes look good, thanks! -- Rafał
On Fri, Feb 20, 2026 at 3:18 AM Rafał Miłecki <zajec5@gmail.com> wrote: > > pt., 20 lut 2026 o 03:14 Rosen Penev <rosenp@gmail.com> napisał(a): > > bcm-ns.dtsi specifies a default layout that is not correct for the > > RT-AC87U. Also allows setting the WAN MAC address properly. > > How the basic ports info from bcm-ns.dtsi is not correct for RT-AC87U? > I don't see you doing any overwriting or /delete-node/. It seems like > a standard NS device with BCM53011 and 8 ports (0, 1, 2, 3, 4, 5, 7, > 8), three of them connected to no-SoC Ethernet interfaces. This comes from a local OpenWrt patch. I just added the nvmem definition for WAN. There's also the addition of labels. > > Except for this unclear commit description, your changes look good, thanks! > > -- > Rafał
pt., 20 lut 2026 o 22:18 Rosen Penev <rosenp@gmail.com> napisał(a): > On Fri, Feb 20, 2026 at 3:18 AM Rafał Miłecki <zajec5@gmail.com> wrote: > > pt., 20 lut 2026 o 03:14 Rosen Penev <rosenp@gmail.com> napisał(a): > > > bcm-ns.dtsi specifies a default layout that is not correct for the > > > RT-AC87U. Also allows setting the WAN MAC address properly. > > > > How the basic ports info from bcm-ns.dtsi is not correct for RT-AC87U? > > I don't see you doing any overwriting or /delete-node/. It seems like > > a standard NS device with BCM53011 and 8 ports (0, 1, 2, 3, 4, 5, 7, > > 8), three of them connected to no-SoC Ethernet interfaces. > This comes from a local OpenWrt patch. I just added the nvmem > definition for WAN. > > There's also the addition of labels. Then I guess someone else didn't try hard enough for proper description. It happens with downstream code. Sometimes it suffers from lower quality & hacks. When submitting for upstream you can improve it though :-) You can (and rather should) reword commit description so it's accurate. -- Rafał
© 2016 - 2026 Red Hat, Inc.