mm: fix typo in the comment of mod_zone_state()

[PATCH] mm: fix typo in the comment of mod_zone_state()

Posted by Miquel Sabaté Solà 1 month, 1 week ago

Use the proper function name, followed by parenthesis as usual.

Signed-off-by: Miquel Sabaté Solà <mssola@mssola.com>
---
 mm/vmstat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmstat.c b/mm/vmstat.c
index 65de88cdf40e..f69225122768 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -547,7 +547,7 @@ EXPORT_SYMBOL(__dec_node_page_state);
 #ifdef CONFIG_HAVE_CMPXCHG_LOCAL
 /*
  * If we have cmpxchg_local support then we do not need to incur the overhead
- * that comes with local_irq_save/restore if we use this_cpu_cmpxchg.
+ * that comes with local_irq_save/restore if we use this_cpu_try_cmpxchg().
  *
  * mod_state() modifies the zone counter state through atomic per cpu
  * operations.
--
2.53.0

Re: [PATCH] mm: fix typo in the comment of mod_zone_state()

Posted by Lorenzo Stoakes (Oracle) 3 weeks, 6 days ago

On Fri, Feb 20, 2026 at 12:44:07AM +0100, Miquel Sabaté Solà wrote:
> Use the proper function name, followed by parenthesis as usual.
>
> Signed-off-by: Miquel Sabaté Solà <mssola@mssola.com>

LGTM, so:

Reviewed-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>

> ---
>  mm/vmstat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index 65de88cdf40e..f69225122768 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -547,7 +547,7 @@ EXPORT_SYMBOL(__dec_node_page_state);
>  #ifdef CONFIG_HAVE_CMPXCHG_LOCAL
>  /*
>   * If we have cmpxchg_local support then we do not need to incur the overhead
> - * that comes with local_irq_save/restore if we use this_cpu_cmpxchg.
> + * that comes with local_irq_save/restore if we use this_cpu_try_cmpxchg().
>   *
>   * mod_state() modifies the zone counter state through atomic per cpu
>   * operations.
> --
> 2.53.0

Re: [PATCH] mm: fix typo in the comment of mod_zone_state()

Posted by SeongJae Park 1 month, 1 week ago

On Fri, 20 Feb 2026 00:44:07 +0100 Miquel Sabaté Solà <mssola@mssola.com> wrote:

> Use the proper function name, followed by parenthesis as usual.

I'm not sure if it is really a typo, or was speaking about the general
this_cpu_cmpxchg() variants.  Either way, the change makes sense to me, though.

> 
> Signed-off-by: Miquel Sabaté Solà <mssola@mssola.com>

Acked-by: SeongJae Park <sj@kernel.org>

Thanks,
SJ

[...]