[PATCH 8/9] s390/vtime: Use lockdep_assert_irqs_disabled() instead of BUG_ON()

Heiko Carstens posted 9 patches 1 month, 1 week ago
[PATCH 8/9] s390/vtime: Use lockdep_assert_irqs_disabled() instead of BUG_ON()
Posted by Heiko Carstens 1 month, 1 week ago
Use lockdep_assert_irqs_disabled() instead of BUG_ON(). This avoids
crashing the kernel, and generates better code if CONFIG_PROVE_LOCKING
is disabled.

Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
---
 arch/s390/kernel/vtime.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/s390/kernel/vtime.c b/arch/s390/kernel/vtime.c
index 4111ff4d727c..bf48744d0912 100644
--- a/arch/s390/kernel/vtime.c
+++ b/arch/s390/kernel/vtime.c
@@ -48,8 +48,7 @@ static inline void set_vtimer(u64 expires)
 
 static inline int virt_timer_forward(u64 elapsed)
 {
-	BUG_ON(!irqs_disabled());
-
+	lockdep_assert_irqs_disabled();
 	if (list_empty(&virt_timer_list))
 		return 0;
 	elapsed = atomic64_add_return(elapsed, &virt_timer_elapsed);
-- 
2.51.0
Re: [PATCH 8/9] s390/vtime: Use lockdep_assert_irqs_disabled() instead of BUG_ON()
Posted by Frederic Weisbecker 4 weeks, 1 day ago
Le Wed, Feb 18, 2026 at 03:20:11PM +0100, Heiko Carstens a écrit :
> Use lockdep_assert_irqs_disabled() instead of BUG_ON(). This avoids
> crashing the kernel, and generates better code if CONFIG_PROVE_LOCKING
> is disabled.
> 
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

Reviewed-by: Frederic Weisbecker <frederic@kernel.org>

-- 
Frederic Weisbecker
SUSE Labs