[PATCH v4 0/4] uniwill-laptop: Input-related improvements

Armin Wolf posted 4 patches 1 month, 1 week ago
.../ABI/testing/sysfs-driver-uniwill-laptop   |  10 +-
.../admin-guide/laptops/uniwill-laptop.rst    |   2 +-
drivers/platform/x86/uniwill/uniwill-acpi.c   | 110 ++++++++++++------
drivers/platform/x86/uniwill/uniwill-wmi.h    |   6 +-
4 files changed, 84 insertions(+), 44 deletions(-)
[PATCH v4 0/4] uniwill-laptop: Input-related improvements
Posted by Armin Wolf 1 month, 1 week ago
This patch series contains a set of input-related improvements
for the uniwill-laptop driver. The first patch renames the
"fn_lock_toggle_enable" and "super_key_toggle_enable" sysfs attributes
after it was discovered that the underlying hardware works differently
than previously thought. This technically breaks user space
applications using those sysfs attributes, but AFAIK no such users
currently exist.

The next two patches fix a potential crash and an issue with the fn
lock status not being updated when using a key combination. The
remaining patch ensurea that when the users changes the fn lock
status using a key combination, a poll notification is being issued
on the appropriate sysfs attr.

Tested on a TUXEDO InfinityBook Pro 15 Gen 10 AMD (whitelist entry
comes next).

Changes since v3:
- drop last patch, because it turned out that all super key events
  are also send by the EC when the super key is enabled/disabled
  using the sysfs attribute

Changes since v2:
- rename UNIWILL_OSD_SUPER_KEY_LOCK_CHANGED
- do no use UNIWILL_OSD_SUPER_KEY_LOCK_ENABLE and
  UNIWILL_OSD_SUPER_KEY_LOCK_DISABLE events for triggering
  the poll notification

Changes since v1:
- update admin-guide for uniwill laptops
- rename UNIWILL_OSD_SUPER_KEY_LOCK_ENABLE and
  UNIWILL_OSD_SUPER_KEY_LOCK_DISABLE
- fix small issue in commit description of patch 5

Armin Wolf (4):
  platform/x86: uniwill-laptop: Rename FN lock and super key lock attrs
  platform/x86: uniwill-laptop: Fix crash on unexpected battery event
  platform/x86: uniwill-laptop: Mark FN lock status as being volatile
  platform/x86: uniwill-laptop: Handle FN lock event

 .../ABI/testing/sysfs-driver-uniwill-laptop   |  10 +-
 .../admin-guide/laptops/uniwill-laptop.rst    |   2 +-
 drivers/platform/x86/uniwill/uniwill-acpi.c   | 110 ++++++++++++------
 drivers/platform/x86/uniwill/uniwill-wmi.h    |   6 +-
 4 files changed, 84 insertions(+), 44 deletions(-)

-- 
2.39.5
Re: [PATCH v4 0/4] uniwill-laptop: Input-related improvements
Posted by Ilpo Järvinen 1 month, 1 week ago
On Wed, 18 Feb 2026 01:50:57 +0100, Armin Wolf wrote:

> This patch series contains a set of input-related improvements
> for the uniwill-laptop driver. The first patch renames the
> "fn_lock_toggle_enable" and "super_key_toggle_enable" sysfs attributes
> after it was discovered that the underlying hardware works differently
> than previously thought. This technically breaks user space
> applications using those sysfs attributes, but AFAIK no such users
> currently exist.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/4] platform/x86: uniwill-laptop: Rename FN lock and super key lock attrs
      commit: 2d53dfacf067968a9ff90c03700fb9b28049f4c6
[2/4] platform/x86: uniwill-laptop: Fix crash on unexpected battery event
      commit: 67e7eb4c130a74c5da9ab43316e00ed3186d1811
[3/4] platform/x86: uniwill-laptop: Mark FN lock status as being volatile
      commit: 2be519d94544e226636c185e28ec1a72d01aab87
[4/4] platform/x86: uniwill-laptop: Handle FN lock event
      commit: 9836feedcf559449e82eb0f741084086780104e5

--
 i.