[PATCH 2/5] arm64: dts: qcom: msm8998: Drop redundant VSYNC pin state

Krzysztof Kozlowski posted 5 patches 1 month, 1 week ago
There is a newer version of this series
[PATCH 2/5] arm64: dts: qcom: msm8998: Drop redundant VSYNC pin state
Posted by Krzysztof Kozlowski 1 month, 1 week ago
The active and suspend pin state of VSYNC is exactly the same, so just
use one node for both states.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
index 0cac06f25a77..30222f6608da 100644
--- a/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
+++ b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
@@ -543,14 +543,7 @@ mdss_dsi_suspend_state: mdss-dsi-suspend-state {
 		bias-pull-down;
 	};
 
-	mdss_te_active_state: mdss-te-active-state {
-		pins = "gpio10";
-		function = "mdp_vsync_a";
-		drive-strength = <2>;
-		bias-pull-down;
-	};
-
-	mdss_te_suspend_state: mdss-te-suspend-state {
+	mdss_te_state: mdss-te-state {
 		pins = "gpio10";
 		function = "mdp_vsync_a";
 		drive-strength = <2>;

-- 
2.51.0
Re: [PATCH 2/5] arm64: dts: qcom: msm8998: Drop redundant VSYNC pin state
Posted by Konrad Dybcio 1 month, 1 week ago
On 2/18/26 6:24 PM, Krzysztof Kozlowski wrote:
> The active and suspend pin state of VSYNC is exactly the same, so just
> use one node for both states.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad
Re: [PATCH 2/5] arm64: dts: qcom: msm8998: Drop redundant VSYNC pin state
Posted by Dmitry Baryshkov 1 month, 1 week ago
On Wed, Feb 18, 2026 at 06:24:24PM +0100, Krzysztof Kozlowski wrote:
> The active and suspend pin state of VSYNC is exactly the same, so just
> use one node for both states.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
> index 0cac06f25a77..30222f6608da 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
> @@ -543,14 +543,7 @@ mdss_dsi_suspend_state: mdss-dsi-suspend-state {
>  		bias-pull-down;
>  	};
>  
> -	mdss_te_active_state: mdss-te-active-state {
> -		pins = "gpio10";
> -		function = "mdp_vsync_a";
> -		drive-strength = <2>;
> -		bias-pull-down;
> -	};
> -
> -	mdss_te_suspend_state: mdss-te-suspend-state {
> +	mdss_te_state: mdss-te-state {

Seems also to be unused. Can we drop it?

>  		pins = "gpio10";
>  		function = "mdp_vsync_a";
>  		drive-strength = <2>;
> 
> -- 
> 2.51.0
> 

-- 
With best wishes
Dmitry
Re: [PATCH 2/5] arm64: dts: qcom: msm8998: Drop redundant VSYNC pin state
Posted by Dmitry Baryshkov 1 month, 1 week ago
On Thu, Feb 19, 2026 at 08:51:38AM +0200, Dmitry Baryshkov wrote:
> On Wed, Feb 18, 2026 at 06:24:24PM +0100, Krzysztof Kozlowski wrote:
> > The active and suspend pin state of VSYNC is exactly the same, so just
> > use one node for both states.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > ---
> >  arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts | 9 +--------
> >  1 file changed, 1 insertion(+), 8 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
> > index 0cac06f25a77..30222f6608da 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
> > +++ b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
> > @@ -543,14 +543,7 @@ mdss_dsi_suspend_state: mdss-dsi-suspend-state {
> >  		bias-pull-down;
> >  	};
> >  
> > -	mdss_te_active_state: mdss-te-active-state {
> > -		pins = "gpio10";
> > -		function = "mdp_vsync_a";
> > -		drive-strength = <2>;
> > -		bias-pull-down;
> > -	};
> > -
> > -	mdss_te_suspend_state: mdss-te-suspend-state {
> > +	mdss_te_state: mdss-te-state {
> 
> Seems also to be unused. Can we drop it?

With the same "can be used later" approach:


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>



> 
> >  		pins = "gpio10";
> >  		function = "mdp_vsync_a";
> >  		drive-strength = <2>;
> > 
> > -- 
> > 2.51.0
> > 
> 
> -- 
> With best wishes
> Dmitry

-- 
With best wishes
Dmitry